Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 5 Apr 2022 09:04:04 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Peter Collingbourne <pcc@google.com>
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: document the boot requirements for MTE
Message-ID: <Ykv39KMpKXb2Mr6p@sirena.org.uk>
References: <20220404211858.968452-1-pcc@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="U4yPShB2sk24Ez1L"
Content-Disposition: inline
In-Reply-To: <20220404211858.968452-1-pcc@google.com>
Precedence: bulk


--U4yPShB2sk24Ez1L
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 04, 2022 at 02:18:58PM -0700, Peter Collingbourne wrote:

> +  For CPUs with the Memory Tagging Extension feature:
> +
> +  - If EL3 is present:
> +
> +    - SCR_EL3.ATA (bit 26) must be initialised to 0b1.
> +
> +  - If the kernel is entered at EL1 and EL2 is present:
> +
> +    - HCR_EL2.ATA (bit 56) must be initialised to 0b1.

Very nitpicky but this is only required for FEAT_MTE2 and above, plain
FEAT_MTE doesn't have these traps.  I don't know that this is a thing
that anyone's actually implemented and from v8.7 on it's not permitted
but the above isn't strictly true if someone did for some reason have
the most basic version.

Otherwise

Reviewed-by: Mark Brown <broonie@kernel.org>

--U4yPShB2sk24Ez1L
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJL9/AACgkQJNaLcl1U
h9Advgf+IuZZugXrsq2QTXupthCBNsC0BjU8HXkBBUqx6xRi96h59EIv/TR0K9Tv
o/Ku1OZjykNhby0S0ts/PhxEWP79+z4mpA+kN13hYiTUp9HytXg4hppOtikWnNE5
qVieJHkjEL5QLmqaxEOd3zf9MPotutz9n+AXI4UC+Av6p3cYamCKwpalZKcenm66
1k6/2iJooTZa+U2jEcZE18tokuwbTMC3lkqjyKoNAEXmSq3DkOHbaxblDFm9eXgf
UeYeYH8GPAU5EO7WASyDs5zYVMouxfO9yFpafW0JoK7HuI/AqlFycD98lwbHvufv
6rlXx8H0HRoghHMSO92joqBVQymltA==
=78rB
-----END PGP SIGNATURE-----

--U4yPShB2sk24Ez1L--