Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp617092pxb; Tue, 5 Apr 2022 16:05:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzO4vG7TcAA34Ue9XG/611XK6OgxYflauXptoeknY+86k5pXNKiVxrNbJAYjqiiRfmcpL9E X-Received: by 2002:a05:6a00:23d2:b0:4fa:f262:719 with SMTP id g18-20020a056a0023d200b004faf2620719mr5913154pfc.4.1649199915865; Tue, 05 Apr 2022 16:05:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649199915; cv=none; d=google.com; s=arc-20160816; b=MZm7LxIPyZyg1dOeExQZK9CUn1hhgU3uQTiToFQ9o68ndJ9L1TuaUQqghkcDaDSOCE Suiw0US6e1DBn0evMEKqcW+031PynKLNkjV5bPTR8lm1Aqu5dpzLhybpoqsoQGAK8PQA euUg0HSXhqRHWRXedd1ssNQqzhqVj4KDa/ZVa9Kmw/Ec3NKuwxqa52VMvGxAf4GxCrSK tcEpFp15iBbnAesTO+58nL+NFnYuJvclIcA3wnu9ytvjdDrm6W3wDa6IR1wuBsu8nDUG BDre2vcj8/Th+mwem7hxP5s/TXqrzLxl9eU69oanqXcWeAooOgcBji6KzvEpsxqrvsy1 zutw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WlP/lcCxf/3rnNKicJ/zFvPykcxlzRffnLxEUKoZRNo=; b=RpIajwkl9cluuG6SWbT83viFSHUClIp+xCgEHpOwgi5F3yLPqQLoPQqU5D16Nm2+66 pLgqdDaJ285SS0qxi6/13Bt6gLqLlAVnT7YVFT6JjmUBdvxiek6rKNtZ7bQxVZFnSQx9 r0EorDRfj4iwv+/a0620XzghmAJcQvtIfUKYbYbkS5wfNgmXS15GxL7B28CkBkJ3HaLg wjw9elkSdrHKO7MlezyFzvWn/a7B6XzMZnO7YVat2/GuE3YUODs8cxsCAU0qWc5LBP5r bmF71jUTC3EB3n+AR37t6I7AzNKUKSk5Ijy2whjBgh1xOcZI6pvynpjar6FgtHSKRyEw iKBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IP4bCE9F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id e13-20020a17090a9a8d00b001bf3623d4f5si1946092pjp.50.2022.04.05.16.05.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 16:05:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IP4bCE9F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8002217C42C; Tue, 5 Apr 2022 15:48:17 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381986AbiDEORL (ORCPT + 99 others); Tue, 5 Apr 2022 10:17:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238977AbiDEJdP (ORCPT ); Tue, 5 Apr 2022 05:33:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEFC2A18D; Tue, 5 Apr 2022 02:21:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 58047B81C6F; Tue, 5 Apr 2022 09:21:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84661C385A0; Tue, 5 Apr 2022 09:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649150482; bh=k04tRHaCCcaSw16B5b4zqxD/SIoqsMzrPWW5b4SpaUY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IP4bCE9FnGR3XmotdqsNUhA9O5AVLjTdJXYUF2LeubYjr2BzCH0UocCxNjBY3RAKR rOhxtjQvs6a7ZZtTaGJZOWFa0qWDmSFK+KWGoXvlk3KfHPbCIS4fQfWRjbU+AM33GO 0sesI49MJsNkUdbOTsURO2skeods9o4fKZdqymzk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alistair Delva , Rishabh Bhatnagar , Ohad Ben-Cohen , Bjorn Andersson , Mathieu Poirier , Sibi Sankar , linux-remoteproc@vger.kernel.org, kernel-team@android.com Subject: [PATCH 5.15 070/913] remoteproc: Fix count check in rproc_coredump_write() Date: Tue, 5 Apr 2022 09:18:52 +0200 Message-Id: <20220405070341.922619068@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070339.801210740@linuxfoundation.org> References: <20220405070339.801210740@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alistair Delva commit f89672cc3681952f2d06314981a6b45f8b0045d1 upstream. Check count for 0, to avoid a potential underflow. Make the check the same as the one in rproc_recovery_write(). Fixes: 3afdc59e4390 ("remoteproc: Add coredump debugfs entry") Signed-off-by: Alistair Delva Cc: Rishabh Bhatnagar Cc: stable@vger.kernel.org Cc: Ohad Ben-Cohen Cc: Bjorn Andersson Cc: Mathieu Poirier Cc: Sibi Sankar Cc: linux-remoteproc@vger.kernel.org Cc: kernel-team@android.com Reviewed-by: Bjorn Andersson Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20220119232139.1125908-1-adelva@google.com Signed-off-by: Greg Kroah-Hartman --- drivers/remoteproc/remoteproc_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/remoteproc/remoteproc_debugfs.c +++ b/drivers/remoteproc/remoteproc_debugfs.c @@ -76,7 +76,7 @@ static ssize_t rproc_coredump_write(stru int ret, err = 0; char buf[20]; - if (count > sizeof(buf)) + if (count < 1 || count > sizeof(buf)) return -EINVAL; ret = copy_from_user(buf, user_buf, count);