Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp625410pxb; Tue, 5 Apr 2022 16:22:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJxQ5loRhBwM+1PraDN4tJfA6/iyo+7GDijRPh9EVYPZrUiH3DT+EvgDnoRTL6My3nRihS X-Received: by 2002:a05:6a00:1307:b0:4b0:b1c:6fd9 with SMTP id j7-20020a056a00130700b004b00b1c6fd9mr5957519pfu.27.1649200962456; Tue, 05 Apr 2022 16:22:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649200962; cv=none; d=google.com; s=arc-20160816; b=MctN26J4q/7TUrq6nXgvq+p2m8S8m3UroChNViEc0iCTAuC4ISHOs+EG6/8rJo4phM SVgc2IUEoaBbKJ43knUV8rRe3xEpKx+RSArZzHMwX2MzKgVhQIN7oqpgAt+OmXkzcOSo FXqVR5G5x4QlJfqI6LeOgzI426+t+HyMJ2Ev2M7/Mmb+X3CErqOVEQmrDevUNqTKfJLJ 5orz1rxIiH6SP3A/HoHX0bEjB76oYG8Zej5SbkVmIdseB2uk71yxd7OomaC2QP2eXsza mAV5C366Zxm6NeHXsVVBI7ncZX8eWRTKl62lrO5GUg/C6mT8L9+Ysr3uBimRIGJh6Ozb Oy0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=yY29b4uh1eFSYjvLdwHl+4vS9VdZZCaBZS7/K8+ebms=; b=heFOr4UBP32BmdiSf5yRsM8IMf9fpLnmjxbWNp9x4pbTHnpZgig+by+8frjM7JUu74 L5XJkkCip/ua4WQjUvq8UI5B7M2adUpJUV48Acp0rqun8xl3rZh96ZYlQ3p/kW+eXa2q t96kBqAZ2K0gG52MdDmFzUmccDmrxWUDbiiXCmxe18ENBoGO+66g5OAJxgo0RP6+yFRL HYVKjAdXUmpdyxnNhb9Xmg8eFsCDfQG9b6myZJ5PbEfvdbsVyAqE1AfbVRWEbcgD7cO6 CIhag5YS8ovvJ2393aKOo5nxPyU+xUDTFsBOJTvrrY0nftWyh4q/i9T8RFBqOLJIjQyA sHrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EKVkSJMi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id x6-20020a1709027c0600b00153b2d16435si9421411pll.61.2022.04.05.16.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 16:22:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EKVkSJMi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DCF5623E3DB; Tue, 5 Apr 2022 16:07:24 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379473AbiDELlN (ORCPT + 99 others); Tue, 5 Apr 2022 07:41:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244804AbiDEIwk (ORCPT ); Tue, 5 Apr 2022 04:52:40 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AF292229F; Tue, 5 Apr 2022 01:44:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2519EB81A0C; Tue, 5 Apr 2022 08:44:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F974C385A0; Tue, 5 Apr 2022 08:44:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649148251; bh=4El5mLzPV5FIUFM4OPSsk5ycPZQtCJ+BCLlcToLdjSI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EKVkSJMig3Cpd3oVtToQcApbO2VkKBsgZdpbJJAgghnYED4rzYbN3OZ+TWo5yA7PH VQdUTSgKCxk0l4Gn8vsT/USr82axEQ3/z9XR/dY9yiHyFewcilp1KUkx84VcJwoBMH cTxmeZjgC5U4daSRfSuuYiT10MvM3fE012fH6fT4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eugen Hristev , Jacopo Mondi , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.16 0289/1017] media: atmel: atmel-sama7g5-isc: fix ispck leftover Date: Tue, 5 Apr 2022 09:20:02 +0200 Message-Id: <20220405070402.850159720@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070354.155796697@linuxfoundation.org> References: <20220405070354.155796697@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eugen Hristev [ Upstream commit 1b52ce99e9f2dcda868a1a7026bfb58d04bd6bc8 ] The ispck is not used for sama7g5 variant of the ISC. Calls to ispck have to be removed also from module insert/removal. Fixes: d7f26849ed7c ("media: atmel: fix the ispck initialization") Signed-off-by: Eugen Hristev Reviewed-by: Jacopo Mondi Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/atmel/atmel-sama7g5-isc.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/media/platform/atmel/atmel-sama7g5-isc.c b/drivers/media/platform/atmel/atmel-sama7g5-isc.c index 5d1c76f680f3..2b1082295c13 100644 --- a/drivers/media/platform/atmel/atmel-sama7g5-isc.c +++ b/drivers/media/platform/atmel/atmel-sama7g5-isc.c @@ -556,7 +556,6 @@ static int microchip_xisc_remove(struct platform_device *pdev) v4l2_device_unregister(&isc->v4l2_dev); - clk_disable_unprepare(isc->ispck); clk_disable_unprepare(isc->hclock); isc_clk_cleanup(isc); @@ -568,7 +567,6 @@ static int __maybe_unused xisc_runtime_suspend(struct device *dev) { struct isc_device *isc = dev_get_drvdata(dev); - clk_disable_unprepare(isc->ispck); clk_disable_unprepare(isc->hclock); return 0; @@ -583,10 +581,6 @@ static int __maybe_unused xisc_runtime_resume(struct device *dev) if (ret) return ret; - ret = clk_prepare_enable(isc->ispck); - if (ret) - clk_disable_unprepare(isc->hclock); - return ret; } -- 2.34.1