Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\))
Subject: Re: [PATCH] fs/proc/kcore.c: remove check of list iterator against
 head past the loop body
From:   Jakob Koschel <jakobkoschel@gmail.com>
In-Reply-To: <20220404155516.a5fb4c23ee017a7212e4b22c@linux-foundation.org>
Date:   Tue, 5 Apr 2022 10:48:30 +0200
Cc:     Mike Rapoport <rppt@kernel.org>,
        David Hildenbrand <david@redhat.com>,
        Oscar Salvador <osalvador@suse.de>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>
Content-Transfer-Encoding: quoted-printable
Message-Id: <32C4FBEE-D56B-46AA-AB95-1A17B5CC0A87@gmail.com>
References: <20220331223700.902556-1-jakobkoschel@gmail.com>
 <20220331164843.b531fbf00d6e7afd6cdfe113@linux-foundation.org>
 <A23914B0-BFD7-48D6-ADCF-42062E1D9887@gmail.com>
 <20220404155516.a5fb4c23ee017a7212e4b22c@linux-foundation.org>
To:     Andrew Morton <akpm@linux-foundation.org>
Precedence: bulk


> On 5. Apr 2022, at 00:55, Andrew Morton <akpm@linux-foundation.org> =
wrote:
>=20
> On Fri, 1 Apr 2022 09:19:57 +0200 Jakob Koschel =
<jakobkoschel@gmail.com> wrote:
>=20
>>> Speaking of limiting scope...
>>=20
>> Fair point :-)
>>=20
>> I see you have applied this already to the -mm tree. Shall I still =
move the iterator?
>> The hope is to remove the 'iter' variable altogether when there are =
no uses after
>> the loop anymore.
>=20
> I don't really understand the question.

Basically I was asking if I should send a v2 with the change you =
suggested.
>=20
> My plan is to merge your patch with my fixlet immediately prior to
> sending upstream.

ok, great. Even better, so ignore my question.

Thanks,
Jakob=