Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp657614pxb; Tue, 5 Apr 2022 17:35:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySrBGTIr6iBcX3eJU3cfu28zlf+iFKDrRjOezC9P9EAFsJifCER0UHgVpfhFIN10knNZl7 X-Received: by 2002:a50:9d47:0:b0:40f:9d3d:97b6 with SMTP id j7-20020a509d47000000b0040f9d3d97b6mr6212959edk.392.1649205352160; Tue, 05 Apr 2022 17:35:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649205352; cv=none; d=google.com; s=arc-20160816; b=B90Y52RYipnCTg6hsuC+/ECiPQWskUBP5rnpGsFJ8LjnJta+FWSdv0W5I2w7AFunan gzpNgZajw8abQXtdHzsE66Q66DeBckhqs9ZBDYXGq5sWPnLp1vVx/qppRla/Kj138t78 PxKIJijOGBUGyBGxO6DG0CAQi9QBPzWUFAwreAQT6W2Lwr9dy/fzgZStCHgopfP4+s/c IYW115KzDCMkwvyDfpHtnq3a/HTIpfaBEsm68npUdaux4oPuFk+Vdq3HkcYJqIP03aMP Diz8vFcX8YYtFJbuLOy+r81jKIQ/iJIBa+o0HE1oVPLG5MECrNC80NLE3HJ6Z5Pwqg6C AQTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=q6NIOFO/TmluOAUt8RvqLLJ24W+0msLiVrlXCOIHb80=; b=Lu4H6grc+0gYbZSNs1YxYBz0CTkIKTQtvPeN0upLziNTuiYF6RnN9wL8041RCgbCiF Tsml20+9U808wzpBFWRphXQpUoquaZAxCLgE9gImS0TElpoAE/I3ufwvdCi7W6rgxpvZ o95syhQI4v/aL5ccu45pkPus1Phkcj01z0fC8i2N2Obef3Ow3ACzw3JA/w1MMbj2Wm5u UWtSKrWOUwxNkt0qttf449Px55xSN2sJHjZWJJuR9I2HitwPoL0UZAuCOpU11lJQSOG2 FOhimWld5d2bSGTKdKMvDFBGvOn8cGDl+myOHAIvpbWew716smnBkU+G/ySMcCPegxKg C7Jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=feLJkBX+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oy12-20020a170907104c00b006df76385bffsi9720940ejb.159.2022.04.05.17.35.25; Tue, 05 Apr 2022 17:35:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=feLJkBX+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1390214AbiDENhg (ORCPT + 99 others); Tue, 5 Apr 2022 09:37:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343973AbiDEJQn (ORCPT ); Tue, 5 Apr 2022 05:16:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD0ACD7603; Tue, 5 Apr 2022 02:02:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5BE6061571; Tue, 5 Apr 2022 09:02:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E8B3C385A1; Tue, 5 Apr 2022 09:02:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649149335; bh=PSrBa409QKcUs2W/8ZzSou2iYvI9BebDvX7O4pcvzgo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=feLJkBX+TIvRwJGapUKuvEvLE4RCYMM0JtJ/IsBAtxNFaW94ZaEL1BxKpp9tS61Xq 0zhJi3C0fwfjp1LoMbXKqLPkQf1392dVqGo/3AIHn7shTVdJeHEwLcQcU6UM1/eu2f HCWRm4wU+o/FTSjhFdaGpu5FneSa4RGxA850nNPM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Bjorn Andersson , Sasha Levin Subject: [PATCH 5.16 0680/1017] remoteproc: qcom: Fix missing of_node_put in adsp_alloc_memory_region Date: Tue, 5 Apr 2022 09:26:33 +0200 Message-Id: <20220405070414.462789503@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070354.155796697@linuxfoundation.org> References: <20220405070354.155796697@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit 505b5b1616e200042999de715dbe7c1e2735cd65 ] The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done. Fixes: dc160e449122 ("remoteproc: qcom: Introduce Non-PAS ADSP PIL driver") Signed-off-by: Miaoqian Lin Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20220308031219.4718-1-linmq006@gmail.com Signed-off-by: Sasha Levin --- drivers/remoteproc/qcom_q6v5_adsp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c index 098362e6e233..7c02bc132247 100644 --- a/drivers/remoteproc/qcom_q6v5_adsp.c +++ b/drivers/remoteproc/qcom_q6v5_adsp.c @@ -408,6 +408,7 @@ static int adsp_alloc_memory_region(struct qcom_adsp *adsp) } ret = of_address_to_resource(node, 0, &r); + of_node_put(node); if (ret) return ret; -- 2.34.1