Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp663426pxb; Tue, 5 Apr 2022 17:50:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzH7r/qEQD+ZoXTt8JtERKJb2AOmGOIPQGtx8ZbzmF5O6zPE4DF3LF3BhdjNqJgpijCcRtP X-Received: by 2002:a17:906:c282:b0:6ce:369d:3d5 with SMTP id r2-20020a170906c28200b006ce369d03d5mr5953812ejz.425.1649206252531; Tue, 05 Apr 2022 17:50:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649206252; cv=none; d=google.com; s=arc-20160816; b=DEJ9nxVmy878dF6YG2jkNmTwg0cRpwcTmoBNHrTJx9rnDiZDNLSD4qzkHRjvtyVqQc wI1QECzBnKns3ZjCs195SOfOFUesfGkyu564ZiFAEKw6WMKN8tjPPsR4RPiYbwhgCdH4 wcNRiXgGHVOq+4Gmo4xRqE188zAd8w++j5kBNJoTYkG6rxEr4CvFs9RNeA30r2dWvFZ+ bZdOxR9NlApIk8uTtUQWg/lkG7RwQPvDFHeFWKUyaQkEjACkaashCzo+TrhM5gnF0i9A 9NjnONGW6GB4wdH5QacrhgcVR5kukNxDjnDFw8kg5virAZH3Vf4BOclCqoYY0pA4mQsV cutw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fP1WHPdyjfMBgEt6MReGIWbFbYesc66AhL2RUDo2gDk=; b=mGwgy7MrfdpfsciA3BLHqO1NbrzaxUi2v05AkyxMF/SW9+yzluscUtuMnEYvsoKjiz rbn/6EnEbGhCVAG8PAAQYEJNxbQmwbMUWv5s3LiUoNco3e3ZvdlJWUpyiKrk36xtHjbQ tBnFAjfeR/VilsJV7+NQ0nbqDIRmmyzLBFQBr8pUtZDrnBgQSVEmdFiZG1+PfhMX+uZN lRPofpAbswJBdbFtubUgdgHaWKLoFpsdWcf0SY0PGBUFIoWOZ5JJE1HdCq7GKZA/FKh+ uV3qK/rUOquCVFfy0J7cenii0DVmWxRxcXH3RrjWSqfPdv/TzmiToEwV+cHh4rygYz3o /f2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VzK1y+Jh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i20-20020a05640242d400b00418c2b5beefsi13368747edc.465.2022.04.05.17.50.27; Tue, 05 Apr 2022 17:50:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VzK1y+Jh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347596AbiDELwl (ORCPT + 99 others); Tue, 5 Apr 2022 07:52:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244835AbiDEIwm (ORCPT ); Tue, 5 Apr 2022 04:52:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B9F822515; Tue, 5 Apr 2022 01:44:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 05FC360FFC; Tue, 5 Apr 2022 08:44:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18895C385A1; Tue, 5 Apr 2022 08:44:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649148271; bh=9sSnzbb/dMgrhrea6qtEXkp2a8QMuyd/2mldhGyCdqw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VzK1y+Jh229rqSmHj7JPAlg+qYm4x0BEb2+u6oxQQLX7GZR4vsRqt4BKX5rx60ZKk 97fqUcjgzYPDPGyKOCDAeufusMkTyNrWowtXlYHYW4P76lWy4zlqYKtAWA8Q8i8bdh Y4BwaPCykaytbh+7d0jLTZXlvwpCnuDKOIH7VRHY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.16 0295/1017] media: coda: Fix missing put_device() call in coda_get_vdoa_data Date: Tue, 5 Apr 2022 09:20:08 +0200 Message-Id: <20220405070403.030896549@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070354.155796697@linuxfoundation.org> References: <20220405070354.155796697@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit ca85d271531a1e1c86f24b892f57b7d0a3ddb5a6 ] The reference taken by 'of_find_device_by_node()' must be released when not needed anymore. Add the corresponding 'put_device()' in the error handling path. Fixes: e7f3c5481035 ("[media] coda: use VDOA for un-tiling custom macroblock format") Signed-off-by: Miaoqian Lin Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/coda/coda-common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c index 9a2640a9c75c..4a553f42ff0a 100644 --- a/drivers/media/platform/coda/coda-common.c +++ b/drivers/media/platform/coda/coda-common.c @@ -408,6 +408,7 @@ static struct vdoa_data *coda_get_vdoa_data(void) if (!vdoa_data) vdoa_data = ERR_PTR(-EPROBE_DEFER); + put_device(&vdoa_pdev->dev); out: of_node_put(vdoa_node); -- 2.34.1