Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp673840pxb; Tue, 5 Apr 2022 18:14:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbMxd/QiD0o5kGyv8oND6BknEW72ZGn9xHPh+8E1yISOt1zGQomQUJ8ooDHQ5txEhHBa5N X-Received: by 2002:a17:906:3a15:b0:6cf:ea4e:a1cc with SMTP id z21-20020a1709063a1500b006cfea4ea1ccmr6294962eje.753.1649207644656; Tue, 05 Apr 2022 18:14:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649207644; cv=none; d=google.com; s=arc-20160816; b=Wqc8A3ONxTSw5IAhQtD6FIKMYCauHNDMeqFrF7NNvKRRZ7BliZjhiMo/OG1SjcO5wx gvTmgIhf2TpJ+Ikhdt9N4wR3xM99bOnB9QJbGU9Rej64LNjNlM9uuclF82B92ohyx9nk YxcxabQlXDicMCfYGOGhcirm68XuKc1WTkgKQweAEbJuxtNYbMg6PTOio9iVJGwExFrt XFYy/rBeBEK4Zwvzz2EDU2+wUKnUI4CI0CJZhc8A6xFxmxK9zTmxohXFDsiluM5jV/mX KTbxRc2Q3lPwhMuEOwvahCLX3E1WtvKpABjFxM8KDs0ZlQfADzRrhh2zXwSF8BU5utXZ NJ3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=aIqVSXuCPankcZSdjVabJpGZlmxzKilSW0UOFZQpbmA=; b=fwCbPftb7EydIY7DBPG6O+6+i2hdueIlZj5+FdSu8Cfd1WHfiEU4Au4hKe9MhPdAzL SB4sI0fR7r4shJ1A+o94maG6JlIUHTOj3TrapmeAT7CO107HIbtOKd/H2WG7YE0PNF0o OF29QGGMdcMJPKOkVCrbbEBUCW+VBYv8C+qvAHLMDPJwyoljRwsf9CcZa++xtEHEnaKm 5efKVpWqoR3qD0pAnfBAQPkV+UOXfyfooPiCKd1wypzlktIozdqaAx605xWdoQ0d66bL y4/czxmKpAzsm1e7Ky+Eo0d7t9gx9GeH6p+Ygaop/ubvLQG9tMXrFv11U7Mk3lfpmmFJ uBpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VvKrbTE7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fj11-20020a1709069c8b00b006e00ed811fasi10011332ejc.154.2022.04.05.18.13.37; Tue, 05 Apr 2022 18:14:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VvKrbTE7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349805AbiDELDk (ORCPT + 99 others); Tue, 5 Apr 2022 07:03:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236588AbiDEIlX (ORCPT ); Tue, 5 Apr 2022 04:41:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEBBAE70; Tue, 5 Apr 2022 01:33:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4AA45609D0; Tue, 5 Apr 2022 08:33:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56096C385A1; Tue, 5 Apr 2022 08:33:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649147624; bh=AIwGneCgQREljoh3n2S10EY9Q3wkZzrK2N0v2FayM6A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VvKrbTE7t3CBNOFYSKc0hh2vwpVjTjM12bSud2p1/A3kc5vPPuEnL3yi6hKhZRWZJ R/JYj8ADtLZr/GNHdBZvyLz5b/g9oVgtqPntK0HC8xBG+Kbrv4jU/8tHOwwjv06+kc 5LYKnY6qSH9pKIpm6pZQDqw5ziOs0m8OGpZrYhNo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ang Tien Sung , Dinh Nguyen Subject: [PATCH 5.16 0062/1017] firmware: stratix10-svc: add missing callback parameter on RSU Date: Tue, 5 Apr 2022 09:16:15 +0200 Message-Id: <20220405070356.026249360@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070354.155796697@linuxfoundation.org> References: <20220405070354.155796697@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ang Tien Sung commit b850b7a8b369322adf699ef48ceff4d902525c8c upstream. Fix a bug whereby, the return response of parameter a1 from an SMC call is not properly set to the callback data during an INTEL_SIP_SMC_RSU_ERROR command. Link: https://lore.kernel.org/lkml/20220216081513.28319-1-tien.sung.ang@intel.com Fixes: 6b50d882d38d ("firmware: add remote status update client support") Cc: stable@vger.kernel.org Signed-off-by: Ang Tien Sung Signed-off-by: Dinh Nguyen Link: https://lore.kernel.org/r/20220223144146.399263-1-dinguyen@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/firmware/stratix10-svc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/firmware/stratix10-svc.c +++ b/drivers/firmware/stratix10-svc.c @@ -477,7 +477,7 @@ static int svc_normal_to_secure_thread(v case INTEL_SIP_SMC_RSU_ERROR: pr_err("%s: STATUS_ERROR\n", __func__); cbdata->status = BIT(SVC_STATUS_ERROR); - cbdata->kaddr1 = NULL; + cbdata->kaddr1 = &res.a1; cbdata->kaddr2 = NULL; cbdata->kaddr3 = NULL; pdata->chan->scl->receive_cb(pdata->chan->scl, cbdata);