Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp689060pxb; Tue, 5 Apr 2022 18:53:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpGgGQ2VOMeI4n2bOaDg3NptEJgMYqvTuntKlSgRCjOIMpEiK4NWkhgOV2yVLu+rBAgkub X-Received: by 2002:a17:902:ecd1:b0:154:5393:aaa4 with SMTP id a17-20020a170902ecd100b001545393aaa4mr6098050plh.131.1649210001636; Tue, 05 Apr 2022 18:53:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649210001; cv=none; d=google.com; s=arc-20160816; b=CKNVO/i6yTQnJLIDTKi1R/MgdD1lGaIjQI84Ta6ax55IfXTnwieT7eiTf2PaAbjlRg wK4IDkou08Qhnf+YmfaTDdMiDLSJQt3eU5xySv6uMa6B/QCKzs0pYeWXOG8Dl2AiI2Hf 8woULAflW7gHaPaQRCW1XoDYpjs7F8Zvp6o2YvdlkhjYoapVGtv/XcOzK+PH9TNWVjSo oJUHj7LMiaSill2UJe9I6NGACeWRa8ISrDi9mHybXBU6YDhSqZXuN5SrLXJEGrSiffIr Pe6vdUjUPS8DYTq52+0B85HaZ2n7C6CMORXh4LyYwgZqkDD+3VTPmmtRtX/74hR+Yb1s jxOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/2gyNTjVR1BvBJJCoNJ403R6sjotFdygrLIE4ymB3o8=; b=U/e03mqmDAih/oK/5thle54pNTISBIfq1vl0BhPYqIgTjqiERcSWlEJDDbGUbD4Q/A 9sh5WBhjHoWpfMHbZ0I62p7zHDb27ubzdy7czxjKh6CC9caIZtMLdW5m0WkgH4m3U2AB 2Js/lS6mIkQISv3VrW1iaeEEwbjA5w8q3+bIgCNfsOhIX8f5fbIJiqmHWDRZRnrI491P YUtNtex+Seik97lLszEhNNJmn9xBeLRKis6V5kP1b6OudUStl6K/PAbP5sbVRu55UU0I LF+PO04Y1jr1RUib4DHLIsuJ2nzUtWh6566iCQAdXkhv+cXXxEcVeI2MSPFVssPQwnky 26pw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=vTy9t6kJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x23-20020a63f717000000b0038201af9a5fsi15189218pgh.53.2022.04.05.18.53.06; Tue, 05 Apr 2022 18:53:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=vTy9t6kJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237787AbiDEInX (ORCPT + 99 others); Tue, 5 Apr 2022 04:43:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233032AbiDEIC5 (ORCPT ); Tue, 5 Apr 2022 04:02:57 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BE83580E3; Tue, 5 Apr 2022 01:00:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2B7C3B81B90; Tue, 5 Apr 2022 08:00:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73FDCC340EE; Tue, 5 Apr 2022 08:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649145642; bh=gEk4RkBXFrR/2z0F7FTlWAGPlXH/JhpdoxTHvJntnts=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vTy9t6kJ40JSyerDn/N630ym3xi/pJDjSrXEYgHju5u2SQREJKH2yk9jEDlVU0qRI RY3ZwZy1Leyhm5viUataDPn7fqZ9jYVFo98YhIqfbGbOpoPm9RjZcebzU3dPU56HSz sTfTB+kqQfUL0qh3HZGOUkEew62MlpB3GddNmZso= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Robert Foss , Sasha Levin Subject: [PATCH 5.17 0478/1126] drm/bridge: lt9611: Fix an error handling path in lt9611_probe() Date: Tue, 5 Apr 2022 09:20:25 +0200 Message-Id: <20220405070421.657785788@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070407.513532867@linuxfoundation.org> References: <20220405070407.513532867@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 9987151a90567785beebcbd5c8ac58d05f254137 ] If lt9611_audio_init() fails, some resources still need to be released before returning an error code. Add the missing goto the error handling path. Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge") Signed-off-by: Christophe JAILLET Signed-off-by: Robert Foss Link: https://patchwork.freedesktop.org/patch/msgid/9c20eb74d42f6d4128e58e3e46aa320482472b77.1643468761.git.christophe.jaillet@wanadoo.fr Reviewed-by: Robert Foss Signed-off-by: Sasha Levin --- drivers/gpu/drm/bridge/lontium-lt9611.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c index dafb1b47c15f..00597eb54661 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c @@ -1164,7 +1164,11 @@ static int lt9611_probe(struct i2c_client *client, lt9611_enable_hpd_interrupts(lt9611); - return lt9611_audio_init(dev, lt9611); + ret = lt9611_audio_init(dev, lt9611); + if (ret) + goto err_remove_bridge; + + return 0; err_remove_bridge: drm_bridge_remove(<9611->bridge); -- 2.34.1