Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp702886pxb; Tue, 5 Apr 2022 19:27:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy62t1TIZ/XEhN1qXCnDTH98XrTZKHVWLGPvgb/nua3HJ3s/YnqN1BRI5BvAK56CMYffeNR X-Received: by 2002:a17:906:68c2:b0:6b4:9f26:c099 with SMTP id y2-20020a17090668c200b006b49f26c099mr6363530ejr.41.1649212063096; Tue, 05 Apr 2022 19:27:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649212063; cv=none; d=google.com; s=arc-20160816; b=Q2njRshlQpxJzG7TWfMrvgzWvnke/aqNTZkssFFE0Dnj6FpNg8ZcpKUAiDEpqg3vJD skvr0cnt182K52Avjj8Lkqaa42udlft4fCFlL4OBUTNqNRd8OqZqovJi3W9VFBAU6hSD LrZVNLFvxbptYITsP4fCoyxY+DQjZHg3nMH7lPZRrDSADmL8cDtyZZwil329F9rg1TOt 2LgEGe841yBpUP9QwCa/21PUcdXvsg58Qshb+PsW1V3lZnPoHH+3gIgsSHQrDq58Xd14 rcmdMAlsHY7Todi+pAbQw7tURuVT85vbf3j/CkIAV8zd38g8Prg1JO4w1hHSpmalbvPC NHNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=aeFNuKV6Ij04tP783XW2OB3peXEW/GaCAxdbIJEMvS4=; b=OT0GLDqAYtYm18IQtFeAhZBMhcBWH2v/VAd+bRrVOIDVml96rO2J5YrHsrWoke0O3d pKssl/JPXaBFkw/RdQG2Nc0R6+GOB+ZEL/hXkl75K5233gp0yBLy4FlMDAONTqEp9zoZ 6rl4ydCezYFHgkCMD2AvBEt33lfwUIAo9dSQ+46cT+N5TJJBRTeHYDLphNi9wk0eMMpc togC52u/0D6kWNfDWBXQao0jJbbzyo/umZSMYh+26uV3pBG1IaR7tN+5w5xLqBYNCmcp 0Ka5O7ekkVN0LQdzwY7DccQO6yVbwnQdg+A7DIwIDBuY2auQwmRoUqX12NItWGsqYNPa qaNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RGPnw2wW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i2-20020a170906444200b006df76385da7si6019378ejp.583.2022.04.05.19.27.17; Tue, 05 Apr 2022 19:27:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RGPnw2wW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358286AbiDEODj (ORCPT + 99 others); Tue, 5 Apr 2022 10:03:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235531AbiDEJau (ORCPT ); Tue, 5 Apr 2022 05:30:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D31A48E55; Tue, 5 Apr 2022 02:18:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AD5236164D; Tue, 5 Apr 2022 09:17:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4FAEC385A2; Tue, 5 Apr 2022 09:17:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649150279; bh=nlm8p+tTQwhGjPD/lcR+yMaGdpDQ15VBJt2fFe08qzk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RGPnw2wW3+9wOoH4inwMEo3sosdHxPVt/r9scUAnOdSgTjkzWWKIbUFpL8sDaLPyI JqJRIGpe05fjQPTK2MWQ6DkhBPBWpFgjSD7y4klsyLgNiUTn04h9moNRh1Q4aHHwzn 9Yl7mllGrVG/6Ya9wqzSmOlpN1Ld6A9QgBa3pgVg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Anton Ivanov , Richard Weinberger Subject: [PATCH 5.16 1002/1017] um: Fix uml_mconsole stop/go Date: Tue, 5 Apr 2022 09:31:55 +0200 Message-Id: <20220405070423.943692936@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070354.155796697@linuxfoundation.org> References: <20220405070354.155796697@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Anton Ivanov commit 1a3a6a2a035bb6c3a7ef4c788d8fd69a7b2d6284 upstream. Moving to an EPOLL based IRQ controller broke uml_mconsole stop/go commands. This fixes it and restores stop/go functionality. Fixes: ff6a17989c08 ("Epoll based IRQ controller") Signed-off-by: Anton Ivanov Signed-off-by: Richard Weinberger Signed-off-by: Greg Kroah-Hartman --- arch/um/drivers/mconsole_kern.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/arch/um/drivers/mconsole_kern.c +++ b/arch/um/drivers/mconsole_kern.c @@ -224,7 +224,7 @@ void mconsole_go(struct mc_request *req) void mconsole_stop(struct mc_request *req) { - deactivate_fd(req->originating_fd, MCONSOLE_IRQ); + block_signals(); os_set_fd_block(req->originating_fd, 1); mconsole_reply(req, "stopped", 0, 0); for (;;) { @@ -247,6 +247,7 @@ void mconsole_stop(struct mc_request *re } os_set_fd_block(req->originating_fd, 0); mconsole_reply(req, "", 0, 0); + unblock_signals(); } static DEFINE_SPINLOCK(mc_devices_lock);