Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp710484pxb; Tue, 5 Apr 2022 19:47:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+nZzAhjNs5VCKsDvYUeZ5kcYZPKIN2Yv6+2H8nep6zpwZP+xONNUtI0xhS2Do1PBGNuYp X-Received: by 2002:a17:907:7b92:b0:6db:71f1:fc20 with SMTP id ne18-20020a1709077b9200b006db71f1fc20mr5959012ejc.343.1649213268906; Tue, 05 Apr 2022 19:47:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649213268; cv=none; d=google.com; s=arc-20160816; b=TIJOYMYVqjumtWmRuzDqmpevz6rRVW7u/4vevXeaEqnfAvD0OrAMnqAd+qiJ4+AZi6 AcqspijjzqefJ3BswZ5esYR6z3C83PD7hxyquYazjhCr8NoDXRaBv2g07CB7jlBwEG4U JZNmsszd5usMlOvoCd5GBa1mvZXI0iYlP+WdpfvV1JRpiqym3XBJKEpbv5M/1WN1N5Jp 99N7ZrKLc7cXvixVtCGTqS9hFyfqNbRNs3Vh/4seUkC7XPX+pFyMxNQ8sQcGCj9ItQwu gO/Yos97VdEyijRIhPr3+vjAQkLTp9jbGOKOu5uXv9ma4RFmyMCWPaFel+aPcOpXsELh 2aJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ejfNCBLg/ySFah4/4qZcOM5AUO69i4q3mA/rv+9wN00=; b=Ps3qBoaW1hDcDWZN9+QAmP8wLm1LE8Z1JR1Sm0kmIt79Pd/zD6IA1zdU8ej+X5FJSy Ru1lqxSn1TSsnHUDykzm3vgJC/CzhFxhnUT5JaNNxO4KVbjmT2YoRnpBH8ebZBK4lSP0 XmejL73DSyuE4aSpw6qYIOXbo5SJ3uRTUOX6T9uFAxwZBI1XgjosqrgaFZPNCEytctbW VuzpYANA8QExi5C4AC4Lms6whLCBx6Mlo8zlduVDaN2+mL1W/6IYlb4+aMBoaPs4AUoo YnsNgnMpnAvwvGhnUwRisD+Z+WGfAA3VnL6LKW7UmSketDOzjgeDqIJyU9LEJi8Hph8s Dw/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0A2QG6zc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t9-20020a056402524900b004195f430321si11656840edd.76.2022.04.05.19.47.20; Tue, 05 Apr 2022 19:47:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0A2QG6zc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357851AbiDENJB (ORCPT + 99 others); Tue, 5 Apr 2022 09:09:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344133AbiDEJSV (ORCPT ); Tue, 5 Apr 2022 05:18:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C531D3BA79; Tue, 5 Apr 2022 02:04:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 642E761564; Tue, 5 Apr 2022 09:04:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E011C385A0; Tue, 5 Apr 2022 09:04:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649149464; bh=Vsd42PPUK3t7g0u09QB28bdvrrlD0K9u5QGtoOtoB+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0A2QG6zcRdcl0DGnrL7JXy8S+vu30kJe1qZ+fGG6hjaaj7G5C4c2vVrTpd3ATw3l4 QT7xAo3slekP3QYGUKZXb8Ql+62JbJKisGPwyUm2+oHZ0P8fiDOVF/0Mv6xSk22zlZ sbZi8gBQ3R9wDrUHUt9xxq1tyEcGp3A+wyr7ILcw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stefano Garzarella , "Michael S. Tsirkin" , Stefan Hajnoczi , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.16 0725/1017] vsock/virtio: enable VQs early on probe Date: Tue, 5 Apr 2022 09:27:18 +0200 Message-Id: <20220405070415.786966844@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070354.155796697@linuxfoundation.org> References: <20220405070354.155796697@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stefano Garzarella [ Upstream commit 88704454ef8b00ea91537ae0d47d9348077e0e72 ] virtio spec requires drivers to set DRIVER_OK before using VQs. This is set automatically after probe returns, but virtio-vsock driver uses VQs in the probe function to fill rx and event VQs with new buffers. Let's fix this, calling virtio_device_ready() before using VQs in the probe function. Fixes: 0ea9e1d3a9e3 ("VSOCK: Introduce virtio_transport.ko") Signed-off-by: Stefano Garzarella Acked-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/vmw_vsock/virtio_transport.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c index 4a8548bdf86c..c5f936fbf876 100644 --- a/net/vmw_vsock/virtio_transport.c +++ b/net/vmw_vsock/virtio_transport.c @@ -627,6 +627,8 @@ static int virtio_vsock_probe(struct virtio_device *vdev) vdev->priv = vsock; + virtio_device_ready(vdev); + mutex_lock(&vsock->tx_lock); vsock->tx_run = true; mutex_unlock(&vsock->tx_lock); -- 2.34.1