Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp723718pxb; Tue, 5 Apr 2022 20:25:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuQ4jO0ke48TLxuTBsMkv+IcZMtemWfvXUlwzpSIbRZ3KwU+lG2xcWik/MsZ0v8tu+1U/I X-Received: by 2002:a17:902:a585:b0:14d:58ef:65 with SMTP id az5-20020a170902a58500b0014d58ef0065mr6586827plb.139.1649215519017; Tue, 05 Apr 2022 20:25:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649215519; cv=none; d=google.com; s=arc-20160816; b=ER5gOnjzMmLLLByCA3LgIozXcvw88ZjrBoGGVSSnSeYy21ASSqE6x+LOCyFgXaaQin U6Nz7iJpp2BtB5Y9eJrydTXR8dQytJBxGRE8z/DLTIKaXpjBjOETEPnz2anFJSrYPRM2 6/5Cl3nGkQDe82YhGuqpOpX73kkZfrCsy6/2nvl0TxMJG7gyl85BQKQOkt/MliwWAL1U YsQ+cvQN903ba0b562CU16i988YXQU5Wqeo8SMApYzGxlRhfQF9kgqDm7uk5NUi/HsP4 S5oBh4tXT7HE/AtsR5Rg0/Xi9H14zZ5vWgM/YZTxazYokjNPNSYn6ZdHyJW0MpVokVbS jmlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fP1WHPdyjfMBgEt6MReGIWbFbYesc66AhL2RUDo2gDk=; b=N7L6BBSUB/t5RGN2qfnMad3tQyWNWvgLkZ4SqnlWgmfgmZVXE3CdGgD6KAUMC83RwD xgmFhlC7+EN09gUd+jIwcTsdflRmjRi7zYUwn9M4Jl6hif+7AHK+ckrAINapK8mTBuQw Yf5WQ4DyvMc4tfdzx9RrAaeDYolv8gcxB7pQfHTHQVzwp5JDOU3++lTu75od4OscB5Ok h9sMBZVJEWenl1kVqUuXhV+MbwA97tJzUGiDQQRm42P0WDQm//RQM7zCPEPCQMX87h8A /mPzinINLmpkjZ4lhsyY9iJUmCWcavDsMoswRcO8OIPevVpejISVGSfjCAD5C0lr1Ycv r/qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OJ9hnbEX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id x185-20020a6331c2000000b003816043ef8csi15043563pgx.385.2022.04.05.20.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 20:25:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OJ9hnbEX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9D381ECB3F; Tue, 5 Apr 2022 20:01:45 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382167AbiDEPOa (ORCPT + 99 others); Tue, 5 Apr 2022 11:14:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346602AbiDEJpM (ORCPT ); Tue, 5 Apr 2022 05:45:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BB2C1CFF4; Tue, 5 Apr 2022 02:31:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BE13461368; Tue, 5 Apr 2022 09:31:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA29DC385A6; Tue, 5 Apr 2022 09:31:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649151067; bh=9sSnzbb/dMgrhrea6qtEXkp2a8QMuyd/2mldhGyCdqw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OJ9hnbEXUqp3/0Bh7lbp8XM24AtGQjDR4SPK7wkkYFhah7cD1mKg7wsohK4Fyh+5C ftN4EYLSp9ULaoeURNVTNDDQteYcH8ZfE5tkDlc902lvxCwdGwsqKfV0lywMXB+JOA TtTThINWdUfl+PUkL5U/v7v6B0kW9NIY+Lds6/Xs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.15 281/913] media: coda: Fix missing put_device() call in coda_get_vdoa_data Date: Tue, 5 Apr 2022 09:22:23 +0200 Message-Id: <20220405070348.280625187@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070339.801210740@linuxfoundation.org> References: <20220405070339.801210740@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit ca85d271531a1e1c86f24b892f57b7d0a3ddb5a6 ] The reference taken by 'of_find_device_by_node()' must be released when not needed anymore. Add the corresponding 'put_device()' in the error handling path. Fixes: e7f3c5481035 ("[media] coda: use VDOA for un-tiling custom macroblock format") Signed-off-by: Miaoqian Lin Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/coda/coda-common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c index 9a2640a9c75c..4a553f42ff0a 100644 --- a/drivers/media/platform/coda/coda-common.c +++ b/drivers/media/platform/coda/coda-common.c @@ -408,6 +408,7 @@ static struct vdoa_data *coda_get_vdoa_data(void) if (!vdoa_data) vdoa_data = ERR_PTR(-EPROBE_DEFER); + put_device(&vdoa_pdev->dev); out: of_node_put(vdoa_node); -- 2.34.1