Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 05 Apr 2022 14:29:34 +0200
Message-ID: <s5ha6cz7lxt.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Robin Murphy <robin.murphy@arm.com>
Cc:     perex@perex.cz, tiwai@suse.com, iommu@lists.linux-foundation.org,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: emu10k1: Stop using iommu_present()
In-Reply-To: <5ac9b54285b2189b848da2595408eb3cae8e5e9d.1649160813.git.robin.murphy@arm.com>
References: <5ac9b54285b2189b848da2595408eb3cae8e5e9d.1649160813.git.robin.murphy@arm.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 05 Apr 2022 14:13:33 +0200,
Robin Murphy wrote:
> 
> iommu_get_domain_for_dev() is already perfectly happy to return NULL
> if the given device has no IOMMU. Drop the unnecessary check.
> 
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>

This will change the code behavior.  The current code does nothing if
no IOMMU is found, but after your removal of the check, the code
reaches to emu->iommu_workaround = true incorrectly.


thanks,

Takashi

> ---
>  sound/pci/emu10k1/emu10k1_main.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/sound/pci/emu10k1/emu10k1_main.c b/sound/pci/emu10k1/emu10k1_main.c
> index 86cc1ca025e4..5ffab343b89c 100644
> --- a/sound/pci/emu10k1/emu10k1_main.c
> +++ b/sound/pci/emu10k1/emu10k1_main.c
> @@ -1751,9 +1751,6 @@ static void snd_emu10k1_detect_iommu(struct snd_emu10k1 *emu)
>  
>  	emu->iommu_workaround = false;
>  
> -	if (!iommu_present(emu->card->dev->bus))
> -		return;
> -
>  	domain = iommu_get_domain_for_dev(emu->card->dev);
>  	if (domain && domain->type == IOMMU_DOMAIN_IDENTITY)
>  		return;
> -- 
> 2.28.0.dirty
>