Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp755276pxb; Tue, 5 Apr 2022 21:56:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyW6SU5l6nhEJYMvVh0PWbfj5Z0YzKCHdifbiz62dq10FCmCk5aDZhUMcaKsDzqq8LXDw1X X-Received: by 2002:a05:6a00:26ce:b0:4fa:8304:d37c with SMTP id p14-20020a056a0026ce00b004fa8304d37cmr7016663pfw.49.1649220961990; Tue, 05 Apr 2022 21:56:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649220961; cv=none; d=google.com; s=arc-20160816; b=Xrv6y7A+xayRacQuWQDZS6AWZSrvPOQk1E1Zj0uxFiY9WkGZP1xU+UMH/7ulhUsnft N7TEcoWsv144yklal9cTN6Hi1H5zlcwDM7uabRppEB4nlIbMbaDJ60xcYHGGLMHabqXQ QvlbOgvYerKrooBAlpEZ2E6KZ59edPLHeXDiiuc1Bx32dYkGGGLLLcCfkXnyB9k7GpL6 OFVcJT5SUfoe+fNLFow1rt2siDXgfkvaL+e9S88DDHsAwWFkUI3T6rKgl7M7tikd9Gce 9mv7mksawMkEWJdG9QZ9SWz9m6gTtRmB8ORyyNemDp1rvrT60eEVF2n3OlDWIkrLuL4t t7ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=y3R1n2O6G5UIabDKqzBxjliHjVc41tS1dCIjPVAYcUI=; b=r0rXe96ZPFMnipt8Qv9Yj4QJs+0/mK8jFNUz0g9JMG5DAfy39KN+Z/b7ZFgokcrlDo cOQlrhT7o4+PS5zX9h+CDda7qDWv+Zy2/wnL6spPzb47qCWQSU/RdUa71AgfBTKKS7Bk ncj5fkfwiQ2+j+eU1/HArQDQSJd+FScTemHc97Ux7MGgtubTsLF8DAspLePRSxE4T++l Sj2MHa9Txv/crRS/xj8VsA9pxDla2wA7OVX7XYjXMTlX9aoAAsIFECsjhUAwY/AthuNX fAupbzetPYB5wIEx5T9mvbbgIAaJCm9vl+bBPzmF6WOp1rxwsX5Z2q1pTWN1d+ddgjmE 3nkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=B1mFe8dX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id b13-20020a170902d50d00b00154a965e488si2574140plg.237.2022.04.05.21.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 21:56:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=B1mFe8dX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9C73AD3715; Tue, 5 Apr 2022 20:15:59 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380092AbiDEPNg (ORCPT + 99 others); Tue, 5 Apr 2022 11:13:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346354AbiDEJov (ORCPT ); Tue, 5 Apr 2022 05:44:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52BE0D9EA2; Tue, 5 Apr 2022 02:30:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D1BB861680; Tue, 5 Apr 2022 09:30:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA612C385A0; Tue, 5 Apr 2022 09:30:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649151026; bh=IQlQgUCjG42fAEaq4U78Y6LFtmOpKk1GRDjB9tZcYGc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B1mFe8dX2iqIM8125ET4Wu3LcR3VnVTFMGQKfEZ2XcDm8B/2BqysueAl4rMqJiqDh R0D59DVwGVjxQBQcwOIWD6odsMcHrVQrq9oFfFLLip6jrlvKiMkO3Sk7ET/A1hE2g3 CzGgkfR5ZcABWpAP+4QNLN38OO/V1oKSLvJL7I4o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jonathan Marek , Robert Foss , Julian Grahsl , Bryan ODonoghue , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.15 267/913] media: camss: csid-170: dont enable unused irqs Date: Tue, 5 Apr 2022 09:22:09 +0200 Message-Id: <20220405070347.859924298@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070339.801210740@linuxfoundation.org> References: <20220405070339.801210740@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jonathan Marek [ Upstream commit a6da362491e409de0978d733441e59db6584d69f ] csid_isr() only checks for the reset irq, so enabling any other irqs doesn't make sense. The "RDI irq" comment is also wrong, the register should be CSID_CSI2_RDIN_IRQ_MASK. Without this fix there may be an excessive amount of irqs. Fixes: eebe6d00e9bf ("media: camss: Add support for CSID hardware version Titan 170") Signed-off-by: Jonathan Marek Reviewed-by: Robert Foss Tested-by: Julian Grahsl Tested-by: Bryan O'Donoghue Signed-off-by: Bryan O'Donoghue Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/qcom/camss/camss-csid-170.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss-csid-170.c b/drivers/media/platform/qcom/camss/camss-csid-170.c index aa65043c3303..a006c8dbceb1 100644 --- a/drivers/media/platform/qcom/camss/camss-csid-170.c +++ b/drivers/media/platform/qcom/camss/camss-csid-170.c @@ -444,12 +444,6 @@ static void csid_configure_stream(struct csid_device *csid, u8 enable) val |= 1 << CSI2_RX_CFG1_MISR_EN; writel_relaxed(val, csid->base + CSID_CSI2_RX_CFG1); // csi2_vc_mode_shift_val ? - /* error irqs start at BIT(11) */ - writel_relaxed(~0u, csid->base + CSID_CSI2_RX_IRQ_MASK); - - /* RDI irq */ - writel_relaxed(~0u, csid->base + CSID_TOP_IRQ_MASK); - val = 1 << RDI_CTRL_HALT_CMD; writel_relaxed(val, csid->base + CSID_RDI_CTRL(0)); } -- 2.34.1