Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp761281pxb; Tue, 5 Apr 2022 22:10:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBgBduX2uL9ZXAP4ibSerwLlfTxjnrADxc4xyZRiFaH5wGSTMLKEUOv+wVVxSAYdbYj09E X-Received: by 2002:a17:902:70c1:b0:156:16c0:dc7b with SMTP id l1-20020a17090270c100b0015616c0dc7bmr6915017plt.85.1649221847293; Tue, 05 Apr 2022 22:10:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649221847; cv=none; d=google.com; s=arc-20160816; b=pKEwHZ7qQYxEPpvUOaoVWokboat8/SLUDulN5fvmnWUvyNZunzl7CUTBeDsLvaHMQP MuRsdojWsdxYyGynM6VyJXDQ7BwxvYtku0tdy+DA4fL21qCwr1pOtqwmMy23bvJXwavR raAnmdOfXcHsiriWjwFaH5jE/LO16Qb3qNEPLzm0R2pBuzPozYIm6b84DOMXwr1OddMU JA2BT3HKvmye5qyDAU/kYtUtuv0mQmxM9bg8N/KZfV15ig/ZmvIPWL78dXGpfpYrbxch EdoPUnGwrY05gT8kYvu2udXt8l6Trrx1B2Z6fFSrScddgubjx/chYu8n2by9VFUfdQ2a qrHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BIwqQ+tARFGDyJyDeCNXDQkOgTANkNPp0P3Xzkha8yM=; b=r6LoUk5UfGfKWnQCF781Somhoy3rexK3xwlcSqmel1C8v/5raFukl/BTTWlqDq0vuk jLp0WvSZRJFL8qAq8XPqzuO+pLrY17lkUR//wd/5pmQEl6hoRoWlKrfcphZfwuaCKbOP WC4yJrWG7pbgwLta+S1upLWXPrEWwgrHIKSDgi7LYGCuN1oggE9YRaXY0Qq9NAvbEQoS 0+W95Y5Fk4JKpSy34HFB+x2sYXJuPrW1WdE5mMOgjiWRQecUYMq7HqvHjHbjUbQIJ+8U TSNsDLTfwtSf5Vqr9DUe+UsecVve/vao2JCpOnaaVWOokjRkzDqbYvpRSGj5urQlnTMr Wo8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Dvwbc+8x; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id b4-20020a056a000cc400b004fa7c00d299si16451188pfv.139.2022.04.05.22.10.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 22:10:47 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Dvwbc+8x; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2C8D81F51A5; Tue, 5 Apr 2022 20:37:36 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345446AbiDET5u (ORCPT + 99 others); Tue, 5 Apr 2022 15:57:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348938AbiDEJtM (ORCPT ); Tue, 5 Apr 2022 05:49:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96066B55; Tue, 5 Apr 2022 02:41:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 099E361576; Tue, 5 Apr 2022 09:41:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13E35C385A2; Tue, 5 Apr 2022 09:41:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649151684; bh=uRP3lPFh83fo86mszzm6oL6vhfxl+Y9k7IkMaSWOLwQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dvwbc+8x/D/uWOt/j+Ltw6obUvsjyzNW3v6JAiu3rMsvmtHX60y1feDKOp9SlU/9E Na6RUC+FqameQ93BOLkxbZUR/DpdF0Ei+9/KQomQqdfSKz4X3FGCbmRuNr/JzMALP+ 2ovbOBfaHGIyHC/kWWaIZ2EloZxY1R6R1ZW0BxBM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Thierry Reding , Sasha Levin Subject: [PATCH 5.15 505/913] gpu: host1x: Fix a memory leak in host1x_remove() Date: Tue, 5 Apr 2022 09:26:07 +0200 Message-Id: <20220405070354.994527002@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070339.801210740@linuxfoundation.org> References: <20220405070339.801210740@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 025c6643a81564f066d8381b9e2f4603e0f8438f ] Add a missing 'host1x_channel_list_free()' call in the remove function, as already done in the error handling path of the probe function. Fixes: 8474b02531c4 ("gpu: host1x: Refactor channel allocation code") Signed-off-by: Christophe JAILLET Signed-off-by: Thierry Reding Signed-off-by: Sasha Levin --- drivers/gpu/host1x/dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c index 3872e4cd2698..fc9f54282f7d 100644 --- a/drivers/gpu/host1x/dev.c +++ b/drivers/gpu/host1x/dev.c @@ -526,6 +526,7 @@ static int host1x_remove(struct platform_device *pdev) host1x_syncpt_deinit(host); reset_control_assert(host->rst); clk_disable_unprepare(host->clk); + host1x_channel_list_free(&host->channel_list); host1x_iommu_exit(host); return 0; -- 2.34.1