Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <ac023638-5ce4-1c0b-29e5-e30fc3038e72@infradead.org>
Date:   Tue, 5 Apr 2022 11:04:51 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH net] net: micrel: Fix KS8851 Kconfig
Content-Language: en-US
To:     Horatiu Vultur <horatiu.vultur@microchip.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
        Divya.Koppera@microchip.com, kernel test robot <lkp@intel.com>
References: <20220405065936.4105272-1-horatiu.vultur@microchip.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20220405065936.4105272-1-horatiu.vultur@microchip.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/4/22 23:59, Horatiu Vultur wrote:
> KS8851 selects MICREL_PHY, which depends on PTP_1588_CLOCK_OPTIONAL, so
> make KS8851 also depend on PTP_1588_CLOCK_OPTIONAL.
> 
> Fixes kconfig warning and build errors:
> 
> WARNING: unmet direct dependencies detected for MICREL_PHY
>   Depends on [m]: NETDEVICES [=y] && PHYLIB [=y] && PTP_1588_CLOCK_OPTIONAL [=m]
>     Selected by [y]:
>       - KS8851 [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICREL [=y] && SPI [=y]
> 
> ld.lld: error: undefined symbol: ptp_clock_register referenced by micrel.c
> net/phy/micrel.o:(lan8814_probe) in archive drivers/built-in.a
> ld.lld: error: undefined symbol: ptp_clock_index referenced by micrel.c
> net/phy/micrel.o:(lan8814_ts_info) in archive drivers/built-in.a
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: ece19502834d ("net: phy: micrel: 1588 support for LAN8814 phy")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>

Tested-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  drivers/net/ethernet/micrel/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/micrel/Kconfig b/drivers/net/ethernet/micrel/Kconfig
> index 1b632cdd7630..830363bafcce 100644
> --- a/drivers/net/ethernet/micrel/Kconfig
> +++ b/drivers/net/ethernet/micrel/Kconfig
> @@ -28,6 +28,7 @@ config KS8842
>  config KS8851
>  	tristate "Micrel KS8851 SPI"
>  	depends on SPI
> +	depends on PTP_1588_CLOCK_OPTIONAL
>  	select MII
>  	select CRC32
>  	select EEPROM_93CX6

-- 
~Randy