Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <700e336a-7d2f-e468-f38b-96e6d35174e7@amd.com>
Date:   Tue, 5 Apr 2022 12:53:30 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [RFC PATCH v5 101/104] KVM: TDX: Silently ignore INIT/SIPI
Content-Language: en-US
To:     Paolo Bonzini <pbonzini@redhat.com>, isaku.yamahata@intel.com,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     isaku.yamahata@gmail.com, Jim Mattson <jmattson@google.com>,
        erdemaktas@google.com, Connor Kuehl <ckuehl@redhat.com>,
        Sean Christopherson <seanjc@google.com>
References: <cover.1646422845.git.isaku.yamahata@intel.com>
 <d0eb8fa53e782a244397168df856f9f904e4d1cd.1646422845.git.isaku.yamahata@intel.com>
 <efbe06a7-3624-2a5a-c1c4-be86f63951e3@redhat.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <efbe06a7-3624-2a5a-c1c4-be86f63951e3@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUlON0didXRHYUZrREdyL2d6ZkZrcngzUUlsdCtDQmo5TC84Qmg0UGhBOE03?=
 =?utf-8?B?Z0VBYW8xamFaZThSSUNNYkN2TWUxQ2x0UVFjWGVGb1RObTljWFo2MUM0WnFQ?=
 =?utf-8?B?dW9PWmdLQnkvTmRLTkpFRktEQlYrdnd3REtsWEpWMkovSVVDcGZYeVdna0Jm?=
 =?utf-8?B?NDd2SXQ3Rk53cmQvM3JnelBOSXkzTW0vclU3SmNEU0x2ZWtUM3ZNZTJZWHpT?=
 =?utf-8?B?SWUzVFgxbG5vNjJBazlRVWVqRWozQlVlTXNXdWk0QlBVUmJER0N3VWRxWmw1?=
 =?utf-8?B?aEluc3VrZ3RWWUk4VmRPUk4wVURQYVZwUDlGK0puMXZnTWVqQXhZdW9IQTJP?=
 =?utf-8?B?cnkxMWFhUk52UmxTMW5VZklKcGpNcG5mS0hObkZndkZZRHVGTnB5NWc4aTFF?=
 =?utf-8?B?NTMrZjN4RDU0ZFJ4T3g4V1VsclpMcGkrTXd1QXpLM3FnQUlUeG42MTNvbWls?=
 =?utf-8?B?Zkt3SFRXQklQWDBnemVOZU11K3pKbndLSXlHd3EvMDBFZzNZUmIxb3hMaTN2?=
 =?utf-8?B?N1doT1o4RUhua1BsVS8vREgxQmpGOWs5M0N0U1ZSdkIxZzFrVjU5bXI5WGsy?=
 =?utf-8?B?TXFlekw2dXRzby9aNnVoSytlYjhEa1VOaENmUEVpQlNWY3lyWUpLYUFhNVZP?=
 =?utf-8?B?U1o2N0FxMFlmbnN0OC8xVU1jc1NZa3BvTGwyTGNyVExvc3YyVkhVWHR4QldR?=
 =?utf-8?B?ZzZ5bWNJQklPM1IxSmdhbEJhNExwZ1RLaWdYSXF4cEpZYU5aWkV0alBUN1ds?=
 =?utf-8?B?MlBsN3AxeWRxU3cxOHQwUmUySUVleTRZZWVmTS9zZDB2Z1RyYnpGUWhTWmNo?=
 =?utf-8?B?MitCVGtUMGZDelpJcEI4VDdHNlJuQU1jeC9oWnArWmt0U1JLZER0Sk1FNFBP?=
 =?utf-8?B?TWFIYjJYMGJVOEMrb1NxNmtwUkhaTHNtclhWZW5KTFJ1OGMycWgwWTFzL2tu?=
 =?utf-8?B?Ym5VcXlhMXgzRURuandnbDkvd3puM0N3THdHdXorUkZrSVBXdmljM1oyak5m?=
 =?utf-8?B?SHJwNzRjRWxSR3hOTGkvNmM1RHRiTnh2LzFmdnJtdjB0ZXptYldTY3dHc0lF?=
 =?utf-8?B?ZjZFbFZPc1hPaTlLZEZSUlAxa0FWTnl1U2lpLzVjWExocU1DNVpTM1lWZjkx?=
 =?utf-8?B?bEs1MEQvVkwvRUU0SWxLR2dVd2MxRTFxV0xzRnNvRXg1YTRJY1lOK1lBd2lr?=
 =?utf-8?B?eWlYdWwzRkVsTWhHak9IdzJqTlVRMlg2d0o3S2ZOMENOektMdjBmVEZKQUNi?=
 =?utf-8?B?R0xUM2dxZ0hEbUt4U0phVUEyUjF2YlVwUGtPOTRzMW9oazRmQlhYekJZQ1RV?=
 =?utf-8?B?YThnZXhVTXFjcVV4SUtuODJvY2JvcnRjYmVuNEh6ZUNSRDllR1REVWxSa3h6?=
 =?utf-8?B?Z00zODd4a2lkNGNIRUI1bStsZG5JUXBnZUZuQmtVMmVvWm9Ud2dwd1lDc2tB?=
 =?utf-8?B?TTBNTUl0VnNGenFDRWlqSFNZSUxOV1VXU2ozNTFnMHpjdVBqUmxjTlpCZ2VG?=
 =?utf-8?B?RTk5dktWNTBHWE91WVNiYXFZMDh5Q0ZrUWxqMVhJeDkwVGExMk55NXlOMlFp?=
 =?utf-8?B?eHd2OEx5TERmZVMwU2I1Q2tjYldNZG9kZUhrdzRubTRqM0l1SC9KbXB2RllL?=
 =?utf-8?B?WHNTOWJFMlV5OGdFbjFOSEdKUWszSHNCUUdUTyt5eFRiUUdzUlpnY3p3SUlI?=
 =?utf-8?B?UU9Od1ppd1BUMy9wQmtNNkh0UTNGNE0wTGtFRVEwT0ZuNmZrUmNyZzU3Rk5E?=
 =?utf-8?B?bWFMYU9uMnhJQmVkOXp1RWphUW5vSG14VG0wUXNKUXJ0NjhmZk40ODVZMUt1?=
 =?utf-8?B?V1B6Tzhxei8vN1RqWGF4TGRWNmkxQzYxQlpzQjhpZEZDVzBrSkorMUF0Rnd2?=
 =?utf-8?B?bmR2cldzTlMyNklzWThUb2l3YzlubGhZSXd0dXZHdXV1ZmpvSVY4M2N3RHBk?=
 =?utf-8?B?TS9IbTc4bU9ieXYzQm45UkVHVFVMV0lYTEY1SVBwOWF5VDlEVlFScFRwcHpI?=
 =?utf-8?B?QmEyeU9LdHd4WjJFbzE1R3pDZEhHb3pZckVRQWJTaDJLM2xnbFA1NVhwaEtO?=
 =?utf-8?B?ZU9DYlFRdFgzbElIdXpLeVM4K2RrNk1sQlRmK29ZK0R5SzY4M0QrVGhrK1Bs?=
 =?utf-8?B?R3JrcFVESHJDY040WjlMRVRZSnEzci9sYXpNZjVPL1dNa0NiZ3FheEZ6Tm1R?=
 =?utf-8?B?UEZFemdnL3VQdFVTQWF4S25OUFNFbHBibWdJVU1ERXBhVitRRjdvaVdIVkhW?=
 =?utf-8?B?cEpFK2xPU1hDditPV0U3clFId1M1cjZKMlIwN2J5L1k0UFd3K25QZGNvRVVW?=
 =?utf-8?B?azVXRE1JLzlNd1BJOVZxcjJzeWF0WW5yYmFlM3lmVEJvTmREODMzUT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bef6279a-302a-4310-60e7-08da172d3375
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 17:53:33.2831
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aDjYfTRsBnD3yVp3tXT3tZk0NGY5OwWPAC+2nnaOkx/Akp0FVDe9qeoYDYmYtbnUgnsCH/c9uQitZUeEO3X+KQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1849
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/5/22 10:48, Paolo Bonzini wrote:
> On 3/4/22 20:49, isaku.yamahata@intel.com wrote:
>> +        if (kvm_init_sipi_unsupported(vcpu->kvm))
>> +            /*
>> +             * TDX doesn't support INIT.  Ignore INIT event.  In the
>> +             * case of SIPI, the callback of
>> +             * vcpu_deliver_sipi_vector ignores it.
>> +             */
>>               vcpu->arch.mp_state = KVM_MP_STATE_RUNNABLE;
>> -        else
>> -            vcpu->arch.mp_state = KVM_MP_STATE_INIT_RECEIVED;
>> +        else {
>> +            kvm_vcpu_reset(vcpu, true);
>> +            if (kvm_vcpu_is_bsp(apic->vcpu))
>> +                vcpu->arch.mp_state = KVM_MP_STATE_RUNNABLE;
>> +            else
>> +                vcpu->arch.mp_state = KVM_MP_STATE_INIT_RECEIVED;
>> +        }
> 
> Should you check vcpu->arch.guest_state_protected instead of 
> special-casing TDX?  KVM_APIC_INIT is not valid for SEV-ES either, if I 
> remember correctly.

While the INIT doesn't update any actual state that is in the encrypted 
VMSA, SEV-ES still calls kvm_vcpu_reset() to allow KVM to set any internal 
tracking state, etc. I haven't ever tested SEV-ES where that is bypassed.

Thanks,
Tom

> 
> Paolo