Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <d01942c2-e600-b789-e613-9ead8c11d94a@acm.org>
Date:   Tue, 5 Apr 2022 14:59:37 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 1/4] rpmb: add Replay Protected Memory Block (RPMB)
 subsystem
Content-Language: en-US
To:     =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>,
        linux-kernel@vger.kernel.org
Cc:     maxim.uvarov@linaro.org, joakim.bech@linaro.org,
        ulf.hansson@linaro.org, ilias.apalodimas@linaro.org,
        arnd@linaro.org, ruchika.gupta@linaro.org, tomas.winkler@intel.com,
        yang.huang@intel.com, bing.zhu@intel.com,
        Matti.Moell@opensynergy.com, hmo@opensynergy.com,
        linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>,
        Arnd Bergmann <arnd.bergmann@linaro.org>,
        Eric Biggers <ebiggers@kernel.org>
References: <20220405093759.1126835-1-alex.bennee@linaro.org>
 <20220405093759.1126835-2-alex.bennee@linaro.org>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <20220405093759.1126835-2-alex.bennee@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 4/5/22 02:37, Alex Bennée wrote:
> +int rpmb_get_write_count(struct rpmb_dev *rdev, int len, u8 *request, int rlen, u8 *resp)
> +{
> +	int err;
> +
> +	if (!rdev)
> +		return -EINVAL;
> +
> +	mutex_lock(&rdev->lock);
> +	err = -EOPNOTSUPP;
> +	if (rdev->ops && rdev->ops->get_write_count)
> +		err = rdev->ops->get_write_count(rdev->dev.parent, rdev->target,
> +						 len, request, rlen, resp);
> +	mutex_unlock(&rdev->lock);
> +
> +	return err;
> +}

The names rpmb_get_write_count() and get_write_count() look confusing to 
me since these functions query the write counter. How about adding "er" 
at the end of both function names?

Are there any plans to add an implementation of struct rpmb_ops for UFS 
devices?

Thanks,

Bart.