Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 5 Apr 2022 18:14:11 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Ivan Bornyakov <i.bornyakov@metrotek.ru>
Cc:     hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
        kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, system@metrotek.ru
Subject: Re: [PATCH net] net: phy: marvell-88x2222: set proper phydev->port
Message-ID: <Ykxq0wx7eMiZCXgx@lunn.ch>
References: <20220405150305.151573-1-i.bornyakov@metrotek.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220405150305.151573-1-i.bornyakov@metrotek.ru>
Precedence: bulk

On Tue, Apr 05, 2022 at 06:03:05PM +0300, Ivan Bornyakov wrote:
> phydev->port was not set and always reported as PORT_TP.
> Set phydev->port according to inserted SFP module.

This is definitely something for Russell to review.

But i'm wondering if this is the correct place to do this? What about
at803x and marvell10g? It seems like this should be done once in the
core somewhere, not in each driver.

     Andrew