Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Jane Chu <jane.chu@oracle.com>
To:     david@fromorbit.com, djwong@kernel.org, dan.j.williams@intel.com,
        hch@infradead.org, vishal.l.verma@intel.com, dave.jiang@intel.com,
        agk@redhat.com, snitzer@redhat.com, dm-devel@redhat.com,
        ira.weiny@intel.com, willy@infradead.org, vgoyal@redhat.com,
        linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
        x86@kernel.org
Subject: [PATCH v7 0/6] DAX poison recovery
Date:   Tue,  5 Apr 2022 13:47:41 -0600
Message-Id: <20220405194747.2386619-1-jane.chu@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PCmukRxu47iVWcGbBqd6e1XpF4QapXqzlDwwDzG/+FVqln3b4zvprl+OuJjO?=
 =?us-ascii?Q?eg/L8OtmuVDVdNgYtrrELOJ7ZQxkH4MAh9OYqU2/sbSpGn2/nlmatIZrxFjK?=
 =?us-ascii?Q?Z9tiaXysoBo0e41MiC9JxO0f9BJYIcCIeDi/rjcsZOBYIwq07NxL/tM7+QOS?=
 =?us-ascii?Q?Bn87EaEVNIJeh7z5TrpxTMz8tcCMV7GWKZsBOEBhKuLhsd35IyyIDF6Oh0WU?=
 =?us-ascii?Q?MPzb+leUzukSpSixgo6aNuMj/uyqnvdlVMVd6L70KBZcfJzLH3JoUpWDCnGN?=
 =?us-ascii?Q?LXCMOYn7YgUiItLcD6CHh2VkVRqA0GRs9p3NFAfaU3Osk50HCCCKVccD7/4K?=
 =?us-ascii?Q?Ku0pM0ODl5nIN04YysEcuAF+Th5+G3bpFQ0FT++PYyN9PqzCf2an2vYfssKL?=
 =?us-ascii?Q?yH0NPh53KSJ5MJmmfTlbwT2eVN5XJcCb8tzWBFiFyn842fqtN3vCp26hBLnn?=
 =?us-ascii?Q?ziA6a3u6+q47Jhol5CssHbffaCkuE2X3t2z0Kz0R6Auf6ez4smiKpE/cZcjM?=
 =?us-ascii?Q?YbRarT39AlbYWgQvWzIISyBpaT8Z3dfSzPAIM4i3AT+22wEuSntVUo7xiHXB?=
 =?us-ascii?Q?8h7llIMHgnD4ajO1LD5S1G604K0DaHjnkdf4oLO79WFFULjqx1o0aO5BHbW+?=
 =?us-ascii?Q?xXh9XMYZxQ4WYCCZhYShEVcDZkncbrqpB9GbxZz04yAX2IjKJpckcHypfTPQ?=
 =?us-ascii?Q?VIVeEHs4QB0IT99TiEE01pilqI2Ydd0Bh4V77MYR3dDvo4dax9GIFk5zoCHF?=
 =?us-ascii?Q?zoV3fRD92S+4MrX6wRd39eCKjVKyNxz3DHawXw3Ew8WapLZ8lca4mTqoH897?=
 =?us-ascii?Q?AM1Cb7h6nmdFGNqQkLE1XFlje32PdBfpsxD2aURoHAy8PUyZigFPMzXVEPji?=
 =?us-ascii?Q?ygvrRKL3V7mkOEmu9aucAftego6LBVBQCuKSmoBHcqgIlXWD1rIIIpGjTwE7?=
 =?us-ascii?Q?Jc5DozUpC/ZF6SleShX50HcM857sPxFsZbtG6JIbHo6bSgjUYppkzVvMlJ5i?=
 =?us-ascii?Q?9yPAFt/vjQ+hYKSra0SJy23X1/6GClN8shlLxpeG7n/v9Mw60Z7XWTwYKvg8?=
 =?us-ascii?Q?PN9CKWrKxjH0pYLS6/mYJRJ8qZzxs6adsDVVuaDSD0duq1UccIQD0kpr2Ibu?=
 =?us-ascii?Q?NeXudZCHu5EuI26AB9M4dPBijY5TnXZUfbtQ5uWGeJGGqC05juOgVBVRFg8l?=
 =?us-ascii?Q?oMyf7+a2UvSXNqRbOLL4g7hPLi1srTtJl427f/JAJ5Q6CwV/Xrks/hPLiJmx?=
 =?us-ascii?Q?6QztdgCgDn0gvnktOzOz4Jf2meDbYFi2GGzZJYmPUBAyhHn3XD0xh/U9NTfw?=
 =?us-ascii?Q?ZXPj8Sj51csHWOeY3YkqAi9bfR/Ds5lgp0w1JD1uLf5o73KgXl7vEyHbmHhO?=
 =?us-ascii?Q?mjXUac/0vkttB67y+cvt581x8BLpElvlMfnASNcto8JSylPJMuFNA1W+DRfU?=
 =?us-ascii?Q?AjqC8AKOWlY0mBP9uIKWJ8+JZmwofN5xTIonpp3ypa88LsyM+O9z9u0N6a3q?=
 =?us-ascii?Q?lTN/fmc4qOXNHrDLZ5XlJ8pHd/tFKAleRvNNgpbMFm6xMl8W0rgg/wS3yqIM?=
 =?us-ascii?Q?qe3s/KFmlQoDzAd7QdmEAAx7nfatQW+SZIJQM5SfQ/WhywlOj+GwStacsFYL?=
 =?us-ascii?Q?i+FZTTKFUFBO4iLuJ+nDYzXNMYmIpGSvmcAKomjgKze7CZRC3+tZHB09op6E?=
 =?us-ascii?Q?1/OxV5MPcRy0V/UX7OZagVeyT0F0EEOfSo2AhzPPTThx+rAAfy1sNJkjKGFO?=
 =?us-ascii?Q?kg/5LfgYMT10q32uHoBECN/Ti7O6iEI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f68b033-1382-4494-ce8f-08da173d3646
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 19:48:09.9445
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3QqPLAxT5BSCUMOxVnzIzbG7qLGzsEE4wCsCt8tNK/N5LkygugM4dlgDt5pIcSivCX5Ym/TpGAY2RtBw8NyY/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5475
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-05_06:2022-04-04,2022-04-05 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 spamscore=0
 phishscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204050110
X-Proofpoint-GUID: hHg6cJzhgk-qeylf-mdBDyUZMKlvPFiT
X-Proofpoint-ORIG-GUID: hHg6cJzhgk-qeylf-mdBDyUZMKlvPFiT
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

In this series, dax recovery code path is independent of that of
normal write. Competing dax recovery threads are serialized,
racing read threads are guaranteed not overlapping with the
recovery process.

In this phase, the recovery granularity is page, future patch
will explore recovery in finer granularity.

Changelog:
v6 -> v7:
 . incorporated comments from Christoph, and picked up a reviewed-by
 . add x86@kernel.org per Boris
 . discovered pmem firmware doesn't reliably handle a request to clear
   poison over a large range (such as 2M), hence worked around the
   the feature by limiting the size of the requested range to kernel
   page size. 

v5->v6:
  . per Christoph, move set{clear}_mce_nospec() inline functions out
    of include/linux/set_memory.h and into arch/x86/mm/pat/set_memory.c
    file, so that no need to export _set_memory_present().
  . per Christoph, ratelimit warning message in pmem_do_write()
  . per both Christoph and Dan, switch back to adding a flag to
    dax_direct_access() instead of embedding the flag in kvaddr
  . suggestions from Christoph for improving code structure and
    readability
  . per Dan, add .recovery_write to dev_pagemap.ops instead of adding
    it to dax_operations, such that, the DM layer doesn't need to be
    involved explicitly in dax recoovery write
  . per Dan, is_bad_pmem() takes a seqlock, so no need to place it
    under recovery_lock.
  Many thanks for both reviewers!

v4->v5:
  Fixed build errors reported by kernel test robot

v3->v4:
  Rebased to v5.17-rc1-81-g0280e3c58f92

References:
v4 https://lore.kernel.org/lkml/20220126211116.860012-1-jane.chu@oracle.com/T/
v3 https://lkml.org/lkml/2022/1/11/900
v2 https://lore.kernel.org/all/20211106011638.2613039-1-jane.chu@oracle.com/
Disussions about marking poisoned page as 'np'
https://lore.kernel.org/all/CAPcyv4hrXPb1tASBZUg-GgdVs0OOFKXMXLiHmktg_kFi7YBMyQ@mail.gmail.com/

Jane Chu (6):
  x86/mm: fix comment
  x86/mce: relocate set{clear}_mce_nospec() functions
  mce: fix set_mce_nospec to always unmap the whole page
  dax: add DAX_RECOVERY flag and .recovery_write dev_pgmap_ops
  pmem: refactor pmem_clear_poison()
  pmem: implement pmem_recovery_write()

 arch/x86/include/asm/set_memory.h |  52 -------
 arch/x86/kernel/cpu/mce/core.c    |   6 +-
 arch/x86/mm/pat/set_memory.c      |  43 +++++-
 drivers/dax/super.c               |  17 ++-
 drivers/md/dm-linear.c            |   4 +-
 drivers/md/dm-log-writes.c        |   5 +-
 drivers/md/dm-stripe.c            |   4 +-
 drivers/md/dm-target.c            |   2 +-
 drivers/md/dm-writecache.c        |   5 +-
 drivers/md/dm.c                   |   5 +-
 drivers/nvdimm/pmem.c             | 224 ++++++++++++++++++++++--------
 drivers/nvdimm/pmem.h             |   3 +-
 drivers/s390/block/dcssblk.c      |   4 +-
 fs/dax.c                          |  24 +++-
 fs/fuse/dax.c                     |   4 +-
 include/linux/dax.h               |  11 +-
 include/linux/device-mapper.h     |   2 +-
 include/linux/memremap.h          |   7 +
 include/linux/set_memory.h        |  11 +-
 tools/testing/nvdimm/pmem-dax.c   |   2 +-
 20 files changed, 285 insertions(+), 150 deletions(-)


base-commit: ae085d7f9365de7da27ab5c0d16b12d51ea7fca9
-- 
2.18.4