Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <614a4844-fa5d-8b8e-0628-894394f31608@amd.com>
Date:   Tue, 5 Apr 2022 19:38:27 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] drm/amdgpu: Senseless code and unnecessary memset
Content-Language: en-US
To:     Grigory Vasilyev <h0tc0d3@gmail.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Melissa Wen <mwen@igalia.com>
Cc:     Alex Deucher <alexander.deucher@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Jani Nikula <jani.nikula@intel.com>,
        Jiawei Gu <Jiawei.Gu@amd.com>,
        Lucas De Marchi <lucas.demarchi@intel.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220405173632.2663-1-h0tc0d3@gmail.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220405173632.2663-1-h0tc0d3@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkhTK3MyeUh1N3djaU5BdXFPTlRhelNIaVQ4RDMrV3E0cHFlRGF1VFkxU1Fx?=
 =?utf-8?B?aUtDYWk5c3RUQlQ2Ym1NU0Z1RlVXSlpwcmhyYjNRb3JGNDNMYmJwUjhKc0tp?=
 =?utf-8?B?QnBhOE5hbXgzSEpRKzhXbWZDNm9xRzJXSWxWd1FqNFlucUFsaDdDUGk3MzhY?=
 =?utf-8?B?VktsZkhLcWxSejRXYzJ4REJNQ0FGelhhd3JBZzBYZG41V3V2ZWh1bHNOR3B2?=
 =?utf-8?B?R0c2VUhSYXhYTHdtSTZaalNCRlJNU09mejBKRlR4YVVTeUROeTI3SVNpUm55?=
 =?utf-8?B?ZFNxci9oendrN2tDazBTNGFraFJvVTc1R3FDdnVtVGFYa2hQTVYwTEZtaTBX?=
 =?utf-8?B?OVc4bVNWbWRVMndqRlJUL1JZeGNRYm5BSjZ6ckt3Nlk0MkpBR3JFWkgrN0NC?=
 =?utf-8?B?WjA1M083bTBiVThySndOQ2NMNTJBWHl3TWRxUW9sVnlybzVlSTJjLzhZaVhy?=
 =?utf-8?B?Z1RibCthN3lUSCszeEU0TVhSSjBCV0l2cCtVMUtaOW1PSEFzTEFTNURYcENh?=
 =?utf-8?B?ZEpISzUwekxLQkI0OVVJZXdDUGFheHBBN2xEVFJjK3dkL2VidldxM0h0NEIr?=
 =?utf-8?B?TDY4Ni9zclU4RVhLUll1T0JzL0lQZ1lwSlVoMW1lNkh0THowK1ZmNzZUUkw3?=
 =?utf-8?B?R3dYUlpreVIwSFRyZVVDVTd5L29EeXhSclBrVm1qaTZtUWpjKzk3L1NuMmh2?=
 =?utf-8?B?U25rbXVNVFFGQzBXUFhJWGF2L3dYRXJleE5DUTQvZGZSMFpYeFZ6NFFDL3pZ?=
 =?utf-8?B?cjdzYW1KdDdvUmxmVjhubmRnNE9mWll3cVdDcTlqdXdlcnkvTWxETTQxSDNF?=
 =?utf-8?B?VFp0YmtxZ0lZZERtcGVJcG9WTmJIL2tValdJRWx6MlVHVURHL3JPUXZxQThN?=
 =?utf-8?B?NGtTMXUzWWJNbXg0SnJoRS9aUW51VjZ4aStSNGY1bHF1ZTlva3k1UkIxa1Bo?=
 =?utf-8?B?RzgyWVZFaURFZE11Nnk0U2tVcFQzdkduczJZbGwxQUNnY202bFFEZ1RrMFdY?=
 =?utf-8?B?aCs2S3BGSk1SaC8rWk5CSERKRjB4LzNmR0tRTEtLTmF5MlByREFnYnAyUDFY?=
 =?utf-8?B?VEo3OHFoWWNlSXAzdXM2aHM0QkZiWGgrWGJGMkFIVkV0ZXlBU2lwR1FJMlhZ?=
 =?utf-8?B?N3FZR0VOQTJGakVYcWVud3hWOUNFZ2dyYUhSTjFWWUFJS21oNHBaV1FiaFlN?=
 =?utf-8?B?SVB0M1NsUFZwKytoVWNzSFR6cDRzRTY4RkRhYTU2dmM5bUsvM01lSCtWNFRL?=
 =?utf-8?B?eUFaOHpVRkQ3dmVzTzBQbnphc250dTdoMzN2Y1pRYWlMbDdvWUJXWitZcFJO?=
 =?utf-8?B?cnJTTmhsS3FtTTk5U0FGN2tEQXk3WTEyRVNadHROUW9PV3R3c054MU9UNlQw?=
 =?utf-8?B?N3RvTkhrbHRyOTMvVHg0UFVQNkRhRjRTS3FZRlV5UmNrU1EzSGFGcHJxV3p2?=
 =?utf-8?B?WUFDL05qTXU0RjlES3lTZEY2eHZZMjduZWd3NHM5eFJHTUhWNUtCTXRuNURa?=
 =?utf-8?B?eGh4NFlMLzh4RDh3YloycE1rY0E2MFdmTjJadDVseC9VNFQ0UTZvZmRxMHNU?=
 =?utf-8?B?LzVmKzJZdk9XR3BTUTUraWVQMVFkSW5FaXRnKzN4Nk50OHB4RkpOTkxpWHVl?=
 =?utf-8?B?MzdvL3ZSWXQvZGdQc3Axc1ZiblNRdVNZd1NLczZVTmRTNGNwNXJDZkJyVGQ2?=
 =?utf-8?B?NS9CdmJ1RnRQZXMzSDd5V3U1cTVLbUprV3BaOTI2OGFRdkpEZXU0dU9SUk4y?=
 =?utf-8?B?b3BJdTNGbXVpc3pCS2wveGdkcnJoeWVQZUgrbm1KNWRVVk5XaTgyQ05Kb0gy?=
 =?utf-8?B?SFVJZkdVMnNzbUlPNDhOWXV0SDQxTjR1QUVzT2c5czVXeXc3TVpDM0pJYTQ2?=
 =?utf-8?B?eUUwU2k3ZU43TUgwcDNaekl0UzdLQlByRkpBK2xqd25yNXJUSXNSZHdxWWhH?=
 =?utf-8?B?Nitxd0RlVnVFZmY2NExwYzkzaEZxS25aOTJJYjgxVzNpNFd3N1BJYVBLZ3Y1?=
 =?utf-8?B?ZjhqYVh3dnNXTFU5ZDhQbThQZjZBZ1ZveHpEWHBzVk44TkxZT1h5ZXIxMytG?=
 =?utf-8?B?ak1zUFllSXVmNnpYZ3RhZWRjRzdVWkVUaFhhZitwa0ZrM2JLeVZMblRhc2FS?=
 =?utf-8?B?dkZSU1RNSUtydk9pTGw3Y2NBeTdpV3FkN3puT3Q5a0s0ZzUrd2ZzYWovNmF2?=
 =?utf-8?B?ZlIreS9xdmpZN1hHNkI1ZDN1clRsKytmaDdQb3c3Vmx2Z1E1NHlYblVLTk81?=
 =?utf-8?B?dFBVU2tFMHlaYlhRc3hzRWh6cm54S2h2blRRWnVGNExvOHBZTENGOUNmTFVy?=
 =?utf-8?B?TTd1SEpaandsZWtqbGFZSzF2SWtPYjZvbDZGWCtyK1ExbitIWmlENG1aR0h1?=
 =?utf-8?Q?jiW4QGC4BGZDUD4oomWVXkF8lA8IgjDrVtAltxELkutuR?=
X-MS-Exchange-AntiSpam-MessageData-1: W+Q+OtcK4HEMcA==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2ba8b4e-28b3-4fbe-9957-08da172b1b2b
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 17:38:33.6189
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CDvi12xw8te6riEonHNZm7D/dkYv2ofNUjKf8V43aK7u8kqAZTXqV+uzyH644QNG
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1619
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 05.04.22 um 19:36 schrieb Grigory Vasilyev:
> Using memset on local arrays before exiting the function is pointless.
> Compilator will remove this code. Also for local arrays is preferable to
> use {0} instead of memset. Mistakes are often made when working with
> memset.

Well actually memset is preferred when working with structures which are 
given to the hardware parser because {0} won't initialize paddings.

So please don't use {0} in any of the atom bios code.

Regards,
Christian.

>
> Signed-off-by: Grigory Vasilyev <h0tc0d3@gmail.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/atom.c | 8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/atom.c b/drivers/gpu/drm/amd/amdgpu/atom.c
> index be9d61bcb8ae..537e48fbbe6b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/atom.c
> +++ b/drivers/gpu/drm/amd/amdgpu/atom.c
> @@ -1538,11 +1538,9 @@ struct atom_context *amdgpu_atom_parse(struct card_info *card, void *bios)
>   int amdgpu_atom_asic_init(struct atom_context *ctx)
>   {
>   	int hwi = CU16(ctx->data_table + ATOM_DATA_FWI_PTR);
> -	uint32_t ps[16];
> +	uint32_t ps[16] = {0};
>   	int ret;
>   
> -	memset(ps, 0, 64);
> -
>   	ps[0] = cpu_to_le32(CU32(hwi + ATOM_FWI_DEFSCLK_PTR));
>   	ps[1] = cpu_to_le32(CU32(hwi + ATOM_FWI_DEFMCLK_PTR));
>   	if (!ps[0] || !ps[1])
> @@ -1551,10 +1549,6 @@ int amdgpu_atom_asic_init(struct atom_context *ctx)
>   	if (!CU16(ctx->cmd_table + 4 + 2 * ATOM_CMD_INIT))
>   		return 1;
>   	ret = amdgpu_atom_execute_table(ctx, ATOM_CMD_INIT, ps);
> -	if (ret)
> -		return ret;
> -
> -	memset(ps, 0, 64);
>   
>   	return ret;
>   }