Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <404b3d6e-510e-c15f-a28b-7425bcc67cc2@nokia.com>
Date:   Tue, 5 Apr 2022 16:00:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: mm: swap: locking in release_pages()
Content-Language: en-US
To:     Michal Hocko <mhocko@suse.com>
Cc:     Nicholas Piggin <npiggin@gmail.com>,
        Alexander Duyck <alexanderduyck@fb.com>,
        Matthew Wilcox <willy@infradead.org>,
        Hugh Dickins <hughd@google.com>, Yu Zhao <yuzhao@google.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        Lee Schermerhorn <lee.schermerhorn@hp.com>,
        Sasha Levin <sashal@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <89009285-c75d-0f09-5b08-d133c42a18f9@nokia.com>
 <YkwdRnuQBjoJ01YK@dhcp22.suse.cz>
 <dc5eb22d-5389-bacb-3756-253e774a8394@nokia.com>
 <Ykwr7OHllqM+Dpii@dhcp22.suse.cz>
From:   Alexander Sverdlin <alexander.sverdlin@nokia.com>
In-Reply-To: <Ykwr7OHllqM+Dpii@dhcp22.suse.cz>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b044dlcva2VXeXI1Zm1SNGEyUVJTMk1td0hET20zMkxyRVk1eGpnSUd2UVRY?=
 =?utf-8?B?MnB5OW80a0w2UEllK01FRXVHYVVHQ2Y5UFNTUFZqOXJxK2VrdjhqK2VnbkJu?=
 =?utf-8?B?ZVdsMXVxZkZ5a0lrQmh6Z0QxWmd4YkI2aThSQzFhRkxjNVN5Wkt0NFp4NTYr?=
 =?utf-8?B?OWJyNEU1NXdQUUdqNEhuSVpUdEV4ZFN1Q1JveGsyUmx5WVhvQndKT1ZOSEFj?=
 =?utf-8?B?UHg0UURwNEhOaGtpQUdNVDZWazBUc2VoNUtGN2F5LzU0cENDTEVaVml2SnJ3?=
 =?utf-8?B?SmMvMllBaFpQT2VGOEVMK0NWRjEwYjVhU0VnZ2xlZjJ3SUlGWDYweUZvOXJs?=
 =?utf-8?B?K1ZmejRCSDJxZ2N1MG9XKy84bk5xY2pDcWIxRWpLcWdVeGZCcE1kOU1BNzFX?=
 =?utf-8?B?ZW1oYXoreEJpOFBaMllmblRCUTJKbWpYQWFMeCthYUJkeEFHbGNLOElZZlB4?=
 =?utf-8?B?aGM0ZXFTN2NoK1BwaG1nSFA1L3p0djU0ZDI5RjhDNFFmaFEyeWMxWXBRQXRn?=
 =?utf-8?B?Q1NvVEhEQjEvTGxzTFMrRE9OeWVZeXV1L21IZFg2dU5pNVBkSjhjOXFPczdR?=
 =?utf-8?B?OEVuUEhSQTdhd1pEb0RXWisweGE1VzJFeWNYbXZIZU43K1UxMmtHQUpXdEda?=
 =?utf-8?B?cUtvTE84MjlYdGdESG44K3p4cE1HTkNEM09LbWUvd1RuVWFGUTlVNWNMTjkr?=
 =?utf-8?B?MEN5ZzZOeWhiaTRkd01zZGZuSHF3OUw5cEVxc1dJajhobUVES01ORk1ZUkNs?=
 =?utf-8?B?REpEN2xyWDdHVGF5VmhhaVlXeDhHZ1JNaTdPdDR5dlI5RUhOeFJIa3lJMlAy?=
 =?utf-8?B?amJ5bzRoVThOcU1tWnY2NmJEL2NaeUhCaXJDNHFJdGVwaDk0ZkVISm16N2Zw?=
 =?utf-8?B?OWNDZVFZMDR5RlZzY3JSZG81Tm51V0c1bzI5cGNqOWhhdFF5clhYdEk4OW9S?=
 =?utf-8?B?cGkveVBRT1lOS09qTGNtczdqMkZxZEsxUGRoNCtKMVBlcWIyVXVteWlUQ0ln?=
 =?utf-8?B?S0pIdFlwdUxEQ3drdGUyZ0RVSjFKeHkyZUVEanN5TzBlY0VUMFYweDNEckx5?=
 =?utf-8?B?Qk9KUnFUWVJYNEdMbmthOWJwYjNwYXNldGhmS1dGTEc4THJ4MlMxYk53bkZq?=
 =?utf-8?B?V2NybjFtTzhaaGlCZGV6Q3dicy9ZOFFaOEpNWHlpK2svT0J4VzBQcW1wMVlG?=
 =?utf-8?B?RE5qcHBUTlgwTU5wK3ZLR0pyZ29tTS82TWxPL1ZYUkdoM2JoL3U1SUJhVU5y?=
 =?utf-8?B?UDdJeGZQOXJqdjZCa0lXd3NnSTZpUlBXTjdLeDY1VjRLcW9JejN0RCt3MFZ3?=
 =?utf-8?B?ZGdJbmhoWjBQMHBlRElDeHVBS1dYMEpJY3VOQklxQ1FYWUdiMThuK3JBSnpQ?=
 =?utf-8?B?V3J4RVZwUE5mSkJpU0w3b1hCSVEvU1p3bEE1a1FBWS9hZTA4QWU2Nmk3QnJi?=
 =?utf-8?B?UytDV1pOOE94TnhldVVvYmpmSUQzMFYrekl0VTE2QUc1YWJKWDU0RXdkbHQz?=
 =?utf-8?B?T21qaTNzOWhJSXBGRGtwUFZWUVEySUxwWmxqYWhiSVV6S2RqZG9Mb28wQjl6?=
 =?utf-8?B?THZqWFc1VDBYdmdXdjQrZkRxVzc4UTYrMVBCYmZnMnFEOGRaMk9DMXd5Y1VI?=
 =?utf-8?B?czgxdTFOU1UzUWR3TWdZUGdhVHNnMWxIbFRmcFZWVGhxd2trNitoUGxmMFRY?=
 =?utf-8?B?bERwSzNsNEduNWJ0b0MyN2pSVTJnSndTM2ZtTUxkUENnb1FnL25aL1EzZ2F0?=
 =?utf-8?B?VktDNmIrd0M5bitmZHYxM3FpTDVJbWdXd1JLZGd6NFJheXhkRXFQbVg2cW4y?=
 =?utf-8?B?YXNzOEl5ekRUbS9jUkFQcXBlRld6Tll3OFpOdjI3eHRUdDBmbDB3UCtiQUhh?=
 =?utf-8?B?cjV4U2xpMnFsL0d6T095WjNvS25lVHdwa1o2ZmpaMnVQUTNxV0ZDZkkrOTJZ?=
 =?utf-8?B?TmlpRGVqYUZPNTM2QzdzK0N0UExiY1JScjJRVFFXaUs5dE9oYjUzeVFmWjFK?=
 =?utf-8?B?alJsL2swZWNsb0pPdElEWDNsQmZ1N0NJbndTMlh4M3I2OFJwcURUNHhkUVBK?=
 =?utf-8?B?cWNtWGRUUEpRZVdZRFRJblNidlAyODJYNWlFb01mN1NuRklSV082MS9NUmk1?=
 =?utf-8?B?RXFoR3NoeS9FNGZHT3BZeFpRa0Y1ak44WHd4b0VBdTZ5UlA2aVZINTk0eG9L?=
 =?utf-8?B?Y0s2cjVjNWRPVmRyN2hhWWF6cGtaSFUvSStEdTBtQmhiU1NJZ3l2cGwrNjVs?=
 =?utf-8?B?amVTbGJEdlNHekRaZld4K1EvYnhHY0FQbWY0eVFvNXcwUDZ0bFdUZHFBN3Mr?=
 =?utf-8?B?eWRJVkgyM1FaOEhnNW9jSmUySkJUTHVWMFBLSVRWZUg0RmxKa3JqNi95WmFz?=
 =?utf-8?Q?KKuhv+TJ6o7QSrFvv8XMPjBSCyASZrOdGNNkP?=
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8fe74a1-d546-4863-ee1a-08da170cb551
X-MS-Exchange-CrossTenant-AuthSource: AM0PR07MB4531.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 14:00:57.7781
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ubIoee1YG2NdMqjjnxcW2paBWInq8DQqPP6gq/3WUFVhOXSl7tRI+QJKS9zTyKsXJedW08DsiPqPChOcVAsCT/c0mFC/t0DNGP0G8nZEh2s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0701MB2758
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Michal!

On 05/04/2022 13:45, Michal Hocko wrote:
>>>> 1. Crash of v5.4.170 on an ARM32 machine:
>>>>
>>>> Unable to handle kernel NULL pointer dereference at virtual address 00000104
>>>> pgd = e138149d
>>>> [00000104] *pgd=84d2fd003, *pmd=8ffd6f003
>>>> Internal error: Oops: a07 [#1] PREEMPT SMP ARM
>>>> ...
>>>> CPU: 1 PID: 6172 Comm: AaSysInfoRColle Tainted: G    B      O      5.4.170-... #1
>>>> Hardware name: Keystone
>>>> PC is at release_pages+0x194/0x358
>>>> LR is at release_pages+0x10c/0x358
>>> Which LOC does this correspond to? (faddr2line should give you a nice
>>> output).
>> Sorry, I forgot this info in the initial report:
>>
>> this is indeed the del_page_from_lru_list() in this crash.
> Could you be more specific please? Is the problem in list_del or
> update_lru_size?

static inline void __list_del(struct list_head * prev, struct list_head * next)
{
        next->prev = prev;    <--

-- 
Best regards,
Alexander Sverdlin.