Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <a78166b3-4e99-89c7-c435-d42bd94e9536@intel.com>
Date:   Tue, 5 Apr 2022 11:35:33 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.7.0
Subject: Re: [PATCH RFC] x86/sgx: Simplify struct
 sgx_enclave_restrict_permissions
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>, <linux-sgx@vger.kernel.rog>
CC:     Dave Hansen <dave.hansen@linux.intel.com>,
        Nathaniel McCallum <nathaniel@profian.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "open list:INTEL SGX" <linux-sgx@vger.kernel.org>,
        "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" 
        <linux-kernel@vger.kernel.org>
References: <20220405151642.96096-1-jarkko@kernel.org>
 <76c6e673-71fb-1068-0114-c3eea93a2fd4@intel.com>
 <13a43c8d9e9d103009e652e7e8ff49e6844316d5.camel@kernel.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <13a43c8d9e9d103009e652e7e8ff49e6844316d5.camel@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHB6RkpTa1c0ZnlIM3YvUWJOczBVMlBZOC9TbnBpQkdqUXgzaXgwWlNacEc3?=
 =?utf-8?B?OUlDcXRuNGo0QnJ0czdhcVlvRW5sLzdKbzR3MzJ0L0kxRzBQbXd1dVRjdklJ?=
 =?utf-8?B?SVBXYlhmVnJzc1JpQTJzT1k4VHRLWGNXYktNUTVVN254NHUwT0N0djc3b3VU?=
 =?utf-8?B?ZkxQTnJsWGVPeE56bmgvUkt1M3ltUFRyMWFramJ1RVpvNERzeHVXZGlLT3dD?=
 =?utf-8?B?ZDhsa3U2b0dRL0JqYmtsN0w5SWFEWE1sMml3YzdQWWhnMk9Ua1I3Qk0wSFZn?=
 =?utf-8?B?TCszMDk1bWQ5UnRLZlJFMGxCdWpuNEdwYkVTcXJiZ0VqQ2N4ZjNHbk5xUTJQ?=
 =?utf-8?B?OWxIRFdVZUpidk9UNXk1QXFmWkJZM05LRERMWVBHcU5ndTZwaXMvaE4vc3dG?=
 =?utf-8?B?aWh6LzJjOVZSeVZBNHFReEQ0U1VsZW04d09iWVhEb1pRNUtweGpqR3cwSjQ2?=
 =?utf-8?B?a0Mrd01mSzFXU3NhNGtaelllOGNzQldGRGlGbU1Na1F2cDlzOGJGSkJKMGZI?=
 =?utf-8?B?VE1tZnNkUk04NlM1MklZK01ESHUzMmlwd0lHeFZoaEZUUFVCSWpESlZtTjR0?=
 =?utf-8?B?S2NUTStac2QwTHc4S0RRdTJtbTJaMWxDeFZ6SVNJVHhRT0Y3TkVuWDJQVlNU?=
 =?utf-8?B?bEpObjVoZFI5Qm9ydGFlbGVueUJITTBPb2pJQWQ2TXNxcXRpU1NZUzF6YjlT?=
 =?utf-8?B?TFU2dmxRT1k1eGdielMrclZocG5icVJ0QnhvaEU2aTdvVStkOXJ2cFl1dnh3?=
 =?utf-8?B?T3ZOSm9IRmMxdE1OUWRJdm0xb2JuOXpRQm5xU0hLOXZTU1k5Vjl1cXlHOUdG?=
 =?utf-8?B?Z1RZOU9rM2lpTVhZdmVJVDIrUXBxZU1GZjlBOTY0bU9YZE9nV3NwQzhHOFNO?=
 =?utf-8?B?cW1oZkU2S1VDMCtGN2ZBT0VlZWU1elFNTkova0pwS0xETG1pRHE0VXprK3ds?=
 =?utf-8?B?REhnRHFON3VWcWtNTi9FanlKbFkyTDRVZTV4NHJuNmhXYXBEWXZEVXMwUkth?=
 =?utf-8?B?blRyQi91N0w2TEFPS0JUVDFBcmtpSFF0ODQ0S2xsUkRnVFdDT1dJbk03Tmxy?=
 =?utf-8?B?Wk1lVUVhOUx2bDF3akUvbENsanRTdXA5Z3ZkaTdidjBWN2grQk5hMzNEL29M?=
 =?utf-8?B?U2R0Ukd1OHhuMzAxeFE0ZFdmaVNxU2FFRW5oRlRKd2ZrSE5JM2hUZ25lbTFV?=
 =?utf-8?B?TmN3cm5sNXBWTUk1NEdlSVBrVnJ4bnZXWXFnVmE3aFJDRlVKQ3RkNnhpUlNX?=
 =?utf-8?B?aTlTd2JXQVI0MDBsS1JKam1Zc0ZQanRPbEFncXBtR0ZqeFJTeHVScnpDcnBa?=
 =?utf-8?B?b3A3cUxNTncxZ1FiKzY4WUVXYUhjUW8wUDBxcC9vY200N04rVDJ0TkpNREsy?=
 =?utf-8?B?a0RZSEVQbkMzNXd3RGM3Mlk1S2JMRmoxekNXRDVnSnN0MitYZ2J3dGdCbjZh?=
 =?utf-8?B?Szh2SDR4bmJrTGNVajlycWZpVjFTVlM3RGl0aXdySlVRdTVHeGFvWHBFZUZx?=
 =?utf-8?B?R3JPcm9zTWp6UXhMc1F0TC8yTXhpZzZMSTI4dWdueWdkenNqMjNtYWpLTEov?=
 =?utf-8?B?Y0ZBZ2w1TXNvMTdOMCtkVGtGQ0FTSS9hSDZBSjJQUFFjcU9jWmN2NytBdVIv?=
 =?utf-8?B?WE5tT2N3Z2V6THpoOTFZN3FHUE5Fd29uMGF0cUJOTStLTENsK2RiNFlEd0xE?=
 =?utf-8?B?bnRXT3FKamw2SEpqY0s3WjVmR1NhL3h0WGd2Z0thVzJZRGxtRmsrdzIxS0Uv?=
 =?utf-8?B?SEN1cGVBdjhBdWRhbkZrMG5XbW9lZWVrSFMrK09wam5aUjlMOEV0ZjJCMm5T?=
 =?utf-8?B?VysrK1NyT1M4MmJuRStuL3ljbU9YWXhMaVQydU1TT3ArYTY0R3IxSVdUM2tW?=
 =?utf-8?B?eWZjNXhMTXMxUTlxUHBPQ0lCNi9hUUxkanc0aitCdFZvTkJUSzhUVVRRb2kv?=
 =?utf-8?B?R2lLWXhPNDV4d2k3amFidWRQZzdNaG8wdXhkRkU3a09lV2VKZVFhU3F3YXBE?=
 =?utf-8?B?K2lhZXNYZnlWbDdya2tzeVZOZThZVkkyMDN1ak9yZTVCWmZmWWJ3NmJpd0NI?=
 =?utf-8?B?cVMrcFQ5TURIZ0pEVy9wVEdHME8rOXhkbU5pZDU5OHpQU1owVDZxeXBOVC9w?=
 =?utf-8?B?d0JYaE1wa05CdUFabWtMcnBOejFnaDhsekk0MW9JS3dWWUJ1UEdVUHlxd2Vm?=
 =?utf-8?B?V2Mvb2xydDUvVTJFSkI1NzlXd0F2U0NNY01Td0pSc0VsMXBFR25hVDFTaEVC?=
 =?utf-8?B?cGQyVStFQzJCRWVWNlpHUXd0azd4QkRzNHArRzd0K2FkQlZXeGx2UkZ0MjN3?=
 =?utf-8?B?TWpsazdCck50WGJVMlN6Zjk2R3duajRtZUNvTHA0K3VuYXlmU0dxbGpzMUtO?=
 =?utf-8?Q?6gTjNAukjpvEHoDw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 504ef9cc-bccf-4b46-a299-08da173316e2
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 18:35:42.3256
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oh2m3K3MUYoebY7/3kHW0sTtATCV8unDiuwQACKfUpu3ucGPOBAGFHcwUX/cTby7OZeWaSMNlHMXSGkRZjRgv17N5G2KI3YQvzWZHhln+y4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3875
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 4/5/2022 11:30 AM, Jarkko Sakkinen wrote:
> On Tue, 2022-04-05 at 10:21 -0700, Reinette Chatre wrote:
>> Hi Jarkko,
>>
>> On 4/5/2022 8:16 AM, Jarkko Sakkinen wrote:
>>> The reasoning to change SECINFO to simply flags is stated in this inline
>>> comment:
>>>
>>> /*
>>>  * Return valid permission fields from a secinfo structure provided by
>>>  * user space. The secinfo structure is required to only have bits in
>>>  * the permission fields set.
>>>  */
>>>
>>> It is better to simply change the parameter type than require to use
>>> a malformed version of a data structure.
>>
>> Could you please elaborate what is malformed?
> 
> The structure that is accepted by the API. According to SDM permission
> changes are done with a structure where PT_REG is set, which gives
> -EINVAL. I categorize it as a bug.

I assume that you are referring to this line from the SDM:

IF (EPCM(DS:RCX).PT is not PT_REG)
    THEN #PF(DS:RCX); FI;

Please note that the above tests the PT bit of the EPCM
entry, not the PT field in the provided SECINFO.

Reinette