Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 5 Apr 2022 20:09:46 +0200
From:   David Sterba <dsterba@suse.cz>
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org
Subject: Re: [GIT PULL] Folio fixes for 5.18
Message-ID: <20220405180946.GA15609@suse.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Matthew Wilcox <willy@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org
References: <YkdKgzil38iyc7rX@casper.infradead.org>
 <20220405120848.GV15609@twin.jikos.cz>
 <YkxQkZ24Zz9KCxK1@casper.infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YkxQkZ24Zz9KCxK1@casper.infradead.org>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
Precedence: bulk

On Tue, Apr 05, 2022 at 03:22:09PM +0100, Matthew Wilcox wrote:
> On Tue, Apr 05, 2022 at 02:08:48PM +0200, David Sterba wrote:
> > Matthew, can you please always CC linux-btrfs@vger.kernel.org for any
> > patches that touch code under fs/btrfs? I've only noticed your folio
> > updates in this pull request. Some of the changes are plain API switch,
> > that's fine but I want to know about that, some changes seem to slightly
> > modify logic that I'd really like to review and there are several missed
> > opportunities to fix coding style. Thanks.
> 
> I'm sorry, that's an unreasonable request.  There's ~50 filesystems
> that use address_space_operations and cc'ing individual filesystems
> on VFS-wide changes isn't feaasible.

How many filesystems have you touched in the recent changes? I've
counted about 7 subsystems in commit 704528d895dd ("fs: Remove
->readpages address space operation"), the rest are VFS/MM changes or
individual filesystems in separate patches.

Examples of btrfs-only changes, there are more like that in the pull as
you probably know:

8e1dec8eb8b0 ("btrfs: Use folio_invalidate()").
895586eb6898 ("btrfs: Convert from invalidatepage to invalidate_folio")
...

You know you can slap a CC: linux-btrfs@vger.kernel.org to the patch
tag and forget about it, is that unreasonable? No. If you're updating
the same filesystems repeatedly you can copy the CC list for all of
them.