Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp910553pxb; Wed, 6 Apr 2022 04:02:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxK7zmk6DpCIPrlMeN1biKMTC7Vrz3LlxAFHOBRmHQ0K+CXDWPFj0fXUxDNGCUIOD3EXXC7 X-Received: by 2002:a17:902:b70c:b0:156:16f0:cbfe with SMTP id d12-20020a170902b70c00b0015616f0cbfemr7834935pls.152.1649242973973; Wed, 06 Apr 2022 04:02:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649242973; cv=none; d=google.com; s=arc-20160816; b=AqnVSIyf+Q0I5EYnFm+U537m3Dk7TdaOQEBnGHeYpWZl4UcVLt/JoGelMMBeoUpjQ5 WdqUWYwGKQVq4OCbHvjtDW96HD0NE7P7oE97nU17r/aCQa6KN6LUmSXi8WaCIj2jAPoi URq94wmMciOj78nbqDrdmHknAk4YRd4v67PdEnuBQJZP0mnXE9ZDpV2WjKXq+Lf33jIF 0Xy/yHlieDZAdQChLhNUnMk95VtUHLryTIrFU1gDuajFyTiJFbMjtoafg5uQpZnstrQL y7JVnKqzVIKZp68WPkFhILZ8Q5EQIbELZd1PKvo75MVghrZqRiyBwLNp6+SHmsE0wEnD P5Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WlP/lcCxf/3rnNKicJ/zFvPykcxlzRffnLxEUKoZRNo=; b=jIIFSZ9eiozI7i7GV6CwgNmEJzpeYHjVe+PWFcDeuSiVM9u7ZJqLFT3b2q760sKNA3 KIM7NxhMudE4V1vLMpphDaJDKAGQlLMQ1mFQf+g4YZxAThh+M0BRxMLkQgd6o1sN+iq1 mfP7WrypkpX0a5h/Qgf+4aqQo/gBigabjOHGMZ8ByvCnwkAVw056ZzVUo6iQpooC1AiK wuI128As2+hdjamMp50TkO+e3Fed1PYbCiNcfi4EDADlqIrSlEbYOj5Pzxt5GC3dbl2j zb4nsfpVfgseqRe72CxTLy14VPNdpNX/5Ms25KFzk2zDNwSvjJIdauqVQeagcQk8xLsC HVKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uBTJMYh1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id t124-20020a637882000000b003816043f0f2si15795748pgc.743.2022.04.06.04.02.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 04:02:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uBTJMYh1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 430DB171ECF; Wed, 6 Apr 2022 02:25:52 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350347AbiDEUWt (ORCPT + 99 others); Tue, 5 Apr 2022 16:22:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354759AbiDEKPe (ORCPT ); Tue, 5 Apr 2022 06:15:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F389E49256; Tue, 5 Apr 2022 03:02:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8FB4F6172B; Tue, 5 Apr 2022 10:02:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B434C385A1; Tue, 5 Apr 2022 10:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649152958; bh=k04tRHaCCcaSw16B5b4zqxD/SIoqsMzrPWW5b4SpaUY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uBTJMYh1kpH9daBvUzCX2ZnVWkt5yq09suIO2yPIesh2sIX+o25O2vl7bbH7pawb4 mXLMzzGqhbDq7sgdEfS2LhzRFhHVXATieIv2hXbpGc5KjnezZiKY1A9BebQkw+gIdh iCS3Oe/kZy6MczG3qzcsQXxv9A0Q116hhxc6KD9E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alistair Delva , Rishabh Bhatnagar , Ohad Ben-Cohen , Bjorn Andersson , Mathieu Poirier , Sibi Sankar , linux-remoteproc@vger.kernel.org, kernel-team@android.com Subject: [PATCH 5.10 051/599] remoteproc: Fix count check in rproc_coredump_write() Date: Tue, 5 Apr 2022 09:25:45 +0200 Message-Id: <20220405070300.346945793@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070258.802373272@linuxfoundation.org> References: <20220405070258.802373272@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alistair Delva commit f89672cc3681952f2d06314981a6b45f8b0045d1 upstream. Check count for 0, to avoid a potential underflow. Make the check the same as the one in rproc_recovery_write(). Fixes: 3afdc59e4390 ("remoteproc: Add coredump debugfs entry") Signed-off-by: Alistair Delva Cc: Rishabh Bhatnagar Cc: stable@vger.kernel.org Cc: Ohad Ben-Cohen Cc: Bjorn Andersson Cc: Mathieu Poirier Cc: Sibi Sankar Cc: linux-remoteproc@vger.kernel.org Cc: kernel-team@android.com Reviewed-by: Bjorn Andersson Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20220119232139.1125908-1-adelva@google.com Signed-off-by: Greg Kroah-Hartman --- drivers/remoteproc/remoteproc_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/remoteproc/remoteproc_debugfs.c +++ b/drivers/remoteproc/remoteproc_debugfs.c @@ -76,7 +76,7 @@ static ssize_t rproc_coredump_write(stru int ret, err = 0; char buf[20]; - if (count > sizeof(buf)) + if (count < 1 || count > sizeof(buf)) return -EINVAL; ret = copy_from_user(buf, user_buf, count);