Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp918149pxb; Wed, 6 Apr 2022 04:15:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzY/ZkW09KiZMuVeRkuw7vhPI4fA5km5YVaUDNSjsmhLA7wl+BIx0B9C9HnbVDxS8EC4lpl X-Received: by 2002:a17:90a:f189:b0:1ca:c279:1bdf with SMTP id bv9-20020a17090af18900b001cac2791bdfmr9332843pjb.185.1649243706258; Wed, 06 Apr 2022 04:15:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649243706; cv=none; d=google.com; s=arc-20160816; b=jASEr+8wXQKM12xad+iOs62tpwigGhiCnbnvjUKsH/vXmZ1gm6IdfUiT9TaX2x2QQ0 z02AaiCsiwUkhe20suW4f+IS0E5ehHFbPm7JTVt+OgkbNK26ylvn76eZIkWHkyH0bpBa GTtH8X/hg9p9pCL0yKKsDGROqr0TW/TMJPZhShSqjNJXM1avdaQ8v12uhE3YojkKuYTx fd2L0RFSCGi4quhoCUU2SMsihf5SDs5wdr1tCv3McZrbncRn5R5qQdppN2DGKstUpquF RhI0IVvfTfoMB174TfioiGACF4/iE2TDPXBUw+0jl31lRQ0ubhk+L0FZo4C43dIazqBD qLPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4+1zGMjyYzeM4RER6EdvXUrFCj3V/zP9ghLi6HzHQTg=; b=l+5Na+jCP/EcdcV0tHcCT6nslkvBDSVIct2HbhOXmnqdremL716lOCNmpNOL13pS1P CS/1Gq4lpg5iREkHnnCs+wIg+SuihKHJcSSXiiXJtJzZMYB/40JzTSPIE2NfRd4Vlol4 FXdAQ7w1jAxvg7Z93gsEM9BDHRliogvRr7Cs9ZJnSQk3P8EzQLQKhvXAZVXYukW2xW0t GSYmNPyyzlgdFpt2wGfvvyVaK3fRFHwaVuP1iLK8SRLxxOfX+CWaS0LSOFoE2C2zGaAA 90PQxTBZ/K6WopFnc4MI7QhIMwDejGMK+pU0pqSxIHl5X+sX3wBsX9XtiKxS3KPpTAlb aY1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=02UkOuyI; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id f9-20020a635549000000b003816043ef50si15661439pgm.325.2022.04.06.04.15.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 04:15:06 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=02UkOuyI; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5488A5DDA9A; Wed, 6 Apr 2022 02:40:27 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1578348AbiDEXT2 (ORCPT + 99 others); Tue, 5 Apr 2022 19:19:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349883AbiDEJvx (ORCPT ); Tue, 5 Apr 2022 05:51:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E68F2AC7F; Tue, 5 Apr 2022 02:49:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 05C666164D; Tue, 5 Apr 2022 09:49:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13D89C385A2; Tue, 5 Apr 2022 09:49:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649152194; bh=p7xJ9qpWfezlsKnmcqhlhATGgUbph48s1/5K73DMHN0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=02UkOuyIGa6TPa0BxVSAdy3+P9N5p+vzrrLZu3/AlpACjfNsz9Ok7FWNPmRoA2QH5 bG3rgqHJFrl9o787IybAIJoB3Rbg1f6iIWsbMBv9bKlCrg6aVrBAIVYsPIGQPqLGyY B+t/o1mcd0VeX5iF0xphjN/41jH4sTWciKroOP5M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yahu Gao , Paolo Valente , Jens Axboe , Sasha Levin Subject: [PATCH 5.15 688/913] block/bfq_wf2q: correct weight to ioprio Date: Tue, 5 Apr 2022 09:29:10 +0200 Message-Id: <20220405070400.457208824@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070339.801210740@linuxfoundation.org> References: <20220405070339.801210740@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yahu Gao [ Upstream commit bcd2be763252f3a4d5fc4d6008d4d96c601ee74b ] The return value is ioprio * BFQ_WEIGHT_CONVERSION_COEFF or 0. What we want is ioprio or 0. Correct this by changing the calculation. Signed-off-by: Yahu Gao Acked-by: Paolo Valente Link: https://lore.kernel.org/r/20220107065859.25689-1-gaoyahu19@gmail.com Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- block/bfq-wf2q.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c index b74cc0da118e..709b901de3ca 100644 --- a/block/bfq-wf2q.c +++ b/block/bfq-wf2q.c @@ -519,7 +519,7 @@ unsigned short bfq_ioprio_to_weight(int ioprio) static unsigned short bfq_weight_to_ioprio(int weight) { return max_t(int, 0, - IOPRIO_NR_LEVELS * BFQ_WEIGHT_CONVERSION_COEFF - weight); + IOPRIO_NR_LEVELS - weight / BFQ_WEIGHT_CONVERSION_COEFF); } static void bfq_get_entity(struct bfq_entity *entity) -- 2.34.1