Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp919663pxb; Wed, 6 Apr 2022 04:17:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2r9XjZE5/DA75miTb2sB+B4Z3Zgjdv/G/+GyXfR+9rjtYO+681JylM8HbokZHPXtl3IMh X-Received: by 2002:a17:903:22cb:b0:156:c64b:fa34 with SMTP id y11-20020a17090322cb00b00156c64bfa34mr8058000plg.100.1649243875866; Wed, 06 Apr 2022 04:17:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649243875; cv=none; d=google.com; s=arc-20160816; b=WASz7WTcE4GVNjTAz+aX9WZ3wFeww/15xLmobavUMTvrdYYz+AQdanrqlWIJZq5lma v7yMUAwHSAlt5M/ee3VJR3EzbU0uRDSPKturYqcV9TZz054hewleq0WMaXSwTkmWBmj9 ERfdArn6ua6DTeBDIqd25CExrtG3k5ePL0q0t0ixScuQOMKgF0HQbksLwJKdBRmC0Qnt DT4OM0rNPMUQUKq6Qq7kwRPCxge1biFA2cAjYetOx6KYJ8od4Wu+geU69+w3WEo99MJK yXZbJ+aEW9gdXbicnOkj9f42pE20T+amRy1y8jlI8BsnIp9h2/a+5jJ1kPjDaeY+T+NW tdPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Jl2ec3/yxS30V1vQbqG/l1LTSdHlaP2QCSpf8ykPqag=; b=MI+UEgn57wHr/I7u7+37PpxJcZiuCxb8HqC+mkSYc+4f+D6+MCPv35uIfAyUlCt3oM Urnar5hJNNTrTYFBsMjN9/hfwgiA74PVkLvxrMTLEVE58ARTrXuIPK5vyKkMbS1WGqC0 PJDQOZtFKXOLRwZHmdPVSenqnWdfqEc9sBQKIXyBMNbYn8f+RgbTh47PDEvrYlxlXdi+ Y+px6X/q/eS9S5RRaAdMY8GJod+4hqKyxW3mdFRtM9E7U5dNzx3I8BJ18JM19Zh0AmjT Xr4cuWHHg50toAqe2M1C1fdE1jETXOtDpSfccjdlzOmgtBNG1EOVhyjE3lN2fS2U+siq 0Q7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lt5M4mKW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id q184-20020a632ac1000000b003816043f08bsi15306400pgq.640.2022.04.06.04.17.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 04:17:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lt5M4mKW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BE6093B3F90; Wed, 6 Apr 2022 02:41:46 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1844921AbiDFBxZ (ORCPT + 99 others); Tue, 5 Apr 2022 21:53:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358071AbiDEK15 (ORCPT ); Tue, 5 Apr 2022 06:27:57 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA96946654; Tue, 5 Apr 2022 03:14:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7F8CFB81C88; Tue, 5 Apr 2022 10:14:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC9E8C385A0; Tue, 5 Apr 2022 10:14:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649153665; bh=itq4pk8FAdxy92cH1h7fiSh2F6sNhVLjhlu07L9RDyk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lt5M4mKWkbZuG2stHem0sk5eZdZ6yEGcVajwHt018mJah+wgCE2pNzwMe0W0TdKfh 6fGTTi1tciHvzokBDUYwyzoA0/wwpk2eUv9aQ3+vhILzR/MYx3dRrnfCUbTGs7yyxc R3smlWJWuL8M47Kb1Ec+UDZ7pKV/kTMnldhlEEd0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Luca Coelho , Sasha Levin Subject: [PATCH 5.10 303/599] iwlwifi: Fix -EIO error code that is never returned Date: Tue, 5 Apr 2022 09:29:57 +0200 Message-Id: <20220405070307.850369109@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070258.802373272@linuxfoundation.org> References: <20220405070258.802373272@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King [ Upstream commit c305c94bdc18e45b5ad1db54da4269f8cbfdff6b ] Currently the error -EIO is being assinged to variable ret when the READY_BIT is not set but the function iwlagn_mac_start returns 0 rather than ret. Fix this by returning ret instead of 0. Addresses-Coverity: ("Unused value") Fixes: 7335613ae27a ("iwlwifi: move all mac80211 related functions to one place") Signed-off-by: Colin Ian King Link: https://lore.kernel.org/r/20210907104658.14706-1-colin.king@canonical.com Signed-off-by: Luca Coelho Signed-off-by: Sasha Levin --- drivers/net/wireless/intel/iwlwifi/dvm/mac80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/dvm/mac80211.c index 423d3c396b2d..1e21cdbb7313 100644 --- a/drivers/net/wireless/intel/iwlwifi/dvm/mac80211.c +++ b/drivers/net/wireless/intel/iwlwifi/dvm/mac80211.c @@ -304,7 +304,7 @@ static int iwlagn_mac_start(struct ieee80211_hw *hw) priv->is_open = 1; IWL_DEBUG_MAC80211(priv, "leave\n"); - return 0; + return ret; } static void iwlagn_mac_stop(struct ieee80211_hw *hw) -- 2.34.1