Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp922060pxb; Wed, 6 Apr 2022 04:22:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIX8bFxFZ5InNwcPFfN/oy5D8P12mvuCjTkvBZW6IbsLEP5PNjRNUgJisDJsoV7QdGzadZ X-Received: by 2002:a17:90a:7bc1:b0:1ca:a95e:bfde with SMTP id d1-20020a17090a7bc100b001caa95ebfdemr9426677pjl.67.1649244127553; Wed, 06 Apr 2022 04:22:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649244127; cv=none; d=google.com; s=arc-20160816; b=LoUrJOycRdvOwDQlwP0x63nUc8RI7MP7nPm9iD5i5VCRfr8gTi8RrUYOO2HSiz4TlB gJ5paK5my2y/rJDVjBQeNcdTN2D4zoZRJcriW2yUjaQJ6AW5oSxANacGbvlOKOC4hlec xWZJGmOQIU5wq5dttvdA9ebuv1RN9fLD69scWY1vkvVK1595Lm0SyY1R0CCTk4B+aUlm b0T01wMO/fVmg0AcZsQHo1PnFMqKfhaJof+xstAK06fNJO+DSyGMAZ08kyOOTWkdYHfz 7rOsPtS2lwq1K6G834AfTaUNkIrmDjNfD+RJhQAkes4abU77628hDU7kmGcP/wLoiIwm Xg9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MRmtFC+4vIpmhBHfuzpGfs7/C3gMwULee1Jqanynk20=; b=q9h9M1cNLbCVOSyPirN721wYqUAxS8b4xLTdwLoCJZ9JAUQbPNHG5x+XD7u50hj9c8 7dgTXuZaBWo98II2VgpROAjaaBMDAqHx6rlOtp4eGCnnpPmfbjiI+5JDtYJcG9T8f64o T9/PVlCh+qb71DxMX7N5QneHK9IAgeNUNOFqd1WpWKrDeIocHg7s/Ko37XTFcsJnRoFh OiN6qJh8p32HG6gFz4H2IUdJilpYW86VDtnPCijB8Fe7vecANUV2lLVQudLzMrHhDAWe PZFtqG7uFeOUgaqoeTbIAzAGvya+mQ2zi1x5VY73VxWUtqDUUbxJ4Nnh6ODuS89Xnc/R 0Hpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zKbdUiSp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id f11-20020a6547cb000000b0039ca61832e8si1772198pgs.577.2022.04.06.04.22.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 04:22:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zKbdUiSp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F0F6E5EC199; Wed, 6 Apr 2022 02:43:45 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354614AbiDEVYp (ORCPT + 99 others); Tue, 5 Apr 2022 17:24:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350031AbiDEKvD (ORCPT ); Tue, 5 Apr 2022 06:51:03 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22D72A7758; Tue, 5 Apr 2022 03:27:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C6AC2B81B18; Tue, 5 Apr 2022 10:27:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12294C385A0; Tue, 5 Apr 2022 10:27:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649154468; bh=wXCQH6QP5X6EUlJs4U9BH9qhWh3wALpbUoz21iTuBFA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zKbdUiSpTouF49qPrY8nmAe9+HJ0W6rdGGJeD5VLoLqjWog4CZkeZpQNyQuErByta oitywbc5YcpM3mo4p6gpDSZKPYx9v1BdNutHNja1V2LoV/4f0AxKcul1sBnhG+rxwc HboaLZ08m98R6uLdhYk1iO0aew7s8zeUoJYCiUqM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Anton Ivanov , Richard Weinberger Subject: [PATCH 5.10 589/599] um: Fix uml_mconsole stop/go Date: Tue, 5 Apr 2022 09:34:43 +0200 Message-Id: <20220405070316.368502131@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070258.802373272@linuxfoundation.org> References: <20220405070258.802373272@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Anton Ivanov commit 1a3a6a2a035bb6c3a7ef4c788d8fd69a7b2d6284 upstream. Moving to an EPOLL based IRQ controller broke uml_mconsole stop/go commands. This fixes it and restores stop/go functionality. Fixes: ff6a17989c08 ("Epoll based IRQ controller") Signed-off-by: Anton Ivanov Signed-off-by: Richard Weinberger Signed-off-by: Greg Kroah-Hartman --- arch/um/drivers/mconsole_kern.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/arch/um/drivers/mconsole_kern.c +++ b/arch/um/drivers/mconsole_kern.c @@ -223,7 +223,7 @@ void mconsole_go(struct mc_request *req) void mconsole_stop(struct mc_request *req) { - deactivate_fd(req->originating_fd, MCONSOLE_IRQ); + block_signals(); os_set_fd_block(req->originating_fd, 1); mconsole_reply(req, "stopped", 0, 0); for (;;) { @@ -246,6 +246,7 @@ void mconsole_stop(struct mc_request *re } os_set_fd_block(req->originating_fd, 0); mconsole_reply(req, "", 0, 0); + unblock_signals(); } static DEFINE_SPINLOCK(mc_devices_lock);