Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp927044pxb; Wed, 6 Apr 2022 04:31:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEuDSalwSJtKPiwMIA95Dbw4gAHO41E/2SpQJNWfmGvzMZe1SqtmumOUP0V3plCZ5q23hi X-Received: by 2002:a17:902:a710:b0:156:5650:f94a with SMTP id w16-20020a170902a71000b001565650f94amr8004100plq.86.1649244675908; Wed, 06 Apr 2022 04:31:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649244675; cv=none; d=google.com; s=arc-20160816; b=t2Wa85loLRL6uiBEfJHTupCiqYCCEJjSNF/DWkjM4eVFzp/BLSTiVptDYTwJPw6Naa 6cDBC6PhDFJb0pGt8EiO4KPMzkzK0I4TbfpC5fqIrCUKYRp+CBA6bWzMo5gw025rrPaJ MnGbm6J70Ur1Eif9n78ZgFNXTyY4xY0s64ZuKH7aFjRkZtUY44DVJaQ87KKcZ3/N/bVY th5RJXgae78mWWc669saL4rXBADUOPtxsBFSThJPhsXZ09nwUzptkFHkMDn3X/ymkrkm TC4AyRPWOysn7wrl3Z4snGs3AaZQ47ssJArBVId5wvq7kzTl3+5FpAWG86iLYjF2jOMv Ox4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=x+v7dSAGZJOqPIgz5VAVkOvouMSkrLpa97zSTIlVB1w=; b=GUWMK0BMaVEntQ35PG3W32IfJCQW/hpYf8lcdVXzb5IAv6vFqyOHyK8U8qFg+/L01Y 62rXMNgumYmXVFGzYuih5pV5A08vmwFpsbuV/Yk8p3IMdpB34Lqvlopg+nbp6KoPx0ha VkosqpybvHi25LeqmeSivet9UwMe2cE1CD+68LMV06jxkLNRht/UZxmCX26Uks5T/Ev/ jo/YMztoh/I7e9jm+WNAUPYbBH8+tkanRclBiwh20W+bt/DpHIu0C6kV3A87+DPlfJky oFrU4MQdmxXahoXpbkfmglJFXNYnzekDxtSOW5aPlV/yEnOC3lIQm20X2fJ6zioWtD22 6ETw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=L+qsJBdL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id d16-20020a056a0024d000b004fa3a8e00adsi14596388pfv.356.2022.04.06.04.31.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 04:31:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=L+qsJBdL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2A29060703D; Wed, 6 Apr 2022 02:53:19 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237813AbiDFATZ (ORCPT + 99 others); Tue, 5 Apr 2022 20:19:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358155AbiDEK2C (ORCPT ); Tue, 5 Apr 2022 06:28:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5947C9D4F8; Tue, 5 Apr 2022 03:16:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EA8916179E; Tue, 5 Apr 2022 10:16:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03618C385A0; Tue, 5 Apr 2022 10:16:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649153762; bh=M++LqbkOcaNMdYU7FwBHBjnWXZ7kMQuwGOw1w2rIsQU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L+qsJBdLg6oVvm9TpQrxhG097nhBR+GdT9ivUXU22wa9ULVfHzILdpFmsSGiX01S7 fFsFbANMtdozmXqNp0AcYxUc/17D9UbKQ7vIOb+TzQPJQGiQ/t1syMwwXU9lEKUgV7 /Zg7zTmIl6vImoTgOuV73QCZDU3ZuyptJeilsYkQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.10 339/599] IB/hfi1: Allow larger MTU without AIP Date: Tue, 5 Apr 2022 09:30:33 +0200 Message-Id: <20220405070308.921133002@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070258.802373272@linuxfoundation.org> References: <20220405070258.802373272@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mike Marciniszyn [ Upstream commit b135e324d7a2e7fa0a7ef925076136e799b79f44 ] The AIP code signals the phys_mtu in the following query_port() fragment: props->phys_mtu = HFI1_CAP_IS_KSET(AIP) ? hfi1_max_mtu : ib_mtu_enum_to_int(props->max_mtu); Using the largest MTU possible should not depend on AIP. Fix by unconditionally using the hfi1_max_mtu value. Fixes: 6d72344cf6c4 ("IB/ipoib: Increase ipoib Datagram mode MTU's upper limit") Link: https://lore.kernel.org/r/1644348309-174874-1-git-send-email-mike.marciniszyn@cornelisnetworks.com Reviewed-by: Dennis Dalessandro Signed-off-by: Mike Marciniszyn Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/hfi1/verbs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c index 3591923abebb..5f3edd255ca3 100644 --- a/drivers/infiniband/hw/hfi1/verbs.c +++ b/drivers/infiniband/hw/hfi1/verbs.c @@ -1439,8 +1439,7 @@ static int query_port(struct rvt_dev_info *rdi, u8 port_num, 4096 : hfi1_max_mtu), IB_MTU_4096); props->active_mtu = !valid_ib_mtu(ppd->ibmtu) ? props->max_mtu : mtu_to_enum(ppd->ibmtu, IB_MTU_4096); - props->phys_mtu = HFI1_CAP_IS_KSET(AIP) ? hfi1_max_mtu : - ib_mtu_enum_to_int(props->max_mtu); + props->phys_mtu = hfi1_max_mtu; return 0; } -- 2.34.1