Message-ID: <3C03315C.5060203@zytor.com>
Date: Mon, 26 Nov 2001 22:23:24 -0800
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.5) Gecko/20011012
MIME-Version: 1.0
To: Nathan Myers <ncm-nospam@cantrip.org>
CC: linux-kernel@vger.kernel.org
Subject: Re: [RFC] [PATCH] omnibus header cleanup, certification
In-Reply-To: <20011127061714.A41881@cantrip.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

Nathan Myers wrote:

>> 
> Please review at least the portion that you are responsible for,
> and verify that the changes are safe and cannot change the semantics 
> of otherwise-correct code that uses the affected macros.  (That will
> be easy, they're all trivial parenthesizations.  It seems worth noting 
> here that in the C grammar, "-1" is not a numeric literal, but a unary 
> expression.)  Then, pass on your evaluation to Linus and Marcelo.  
> 


It's also worth noting that there is nothing that it can get confused 
with and still have a compilable expression.

I don't believe the unary-expression patches are necessary.  They are, 
of course, harmless, except for the fact that my eyes glazed over 
staring at page after page of these, which very few actual potential (!) 
bugs (there were a couple, like the iopage+ ones...)

	-hpa

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/