Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220405150912.GA625670@euclid> <YkxdasBGZ3m2Yu66@kroah.com>
 <CAMWRUK7c-hqiz+KEFkqBuvu1syCwSnF4UZzbkPFw-VWABm9qOw@mail.gmail.com>
 <CAMWRUK7Jgs3evt3bC0pnRkbRw3CS1XCULPi8NzjgGh7aLTFKCQ@mail.gmail.com> <YkxnJvJyo75c/3yk@kroah.com>
In-Reply-To: <YkxnJvJyo75c/3yk@kroah.com>
From:   Sevinj Aghayeva <sevinj.aghayeva@gmail.com>
Date:   Tue, 5 Apr 2022 12:05:22 -0400
Message-ID: <CAMWRUK6Hamw9bg8-O+xqP0DKy=zcbXHaG4RQtqXo3keFj=KJyA@mail.gmail.com>
Subject: Re: [PATCH v2] staging: rtl8723bs: fix indentation
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        outreachy linux kernel <outreachy@lists.linux.dev>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Apr 5, 2022 at 11:58 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Tue, Apr 05, 2022 at 11:45:29AM -0400, Sevinj Aghayeva wrote:
> > On Tue, Apr 5, 2022 at 11:19 AM Sevinj Aghayeva
> > <sevinj.aghayeva@gmail.com> wrote:
> > >
> > > On Tue, Apr 5, 2022 at 11:17 AM Greg Kroah-Hartman
> > > <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > On Tue, Apr 05, 2022 at 11:09:12AM -0400, Sevinj Aghayeva wrote:
> > > > > Adhere to Linux kernel coding style.
> > > > >
> > > > > Reported by checkpatch:
> > > > >
> > > > > WARNING: suspect code indent for conditional statements
> > > >
> > > > You are also removing unneeded comments, right?  Please explain that as
> > > > the documentation link the bot pointed you to showed.
> > >
> > > I specified that under the --- line:
> > >
> > > v1 -> v2: Remove the comments that became irrelevant with proper indentation.
> >
> > I think I misunderstood the bot's response. It looks like you
> > triggered it because you wanted me to write a more complete
> > description of what the commit is doing. I thought I received it
> > because it was the second version of the patch from a previous
> > patchset (the last bullet point in the bot response) that didn't
> > include v2 in the subject and a v1 -> v2 after the --- line.
>
> That is one reason, yes, but you also need to update the changelog text
> to say everything you are doing in the commit.

Got it.

>
> > I can do a fresh patch with a complete description and no v2 stuff;
> > please let me know.
>
> It will be a v3 patch, right?

Right.

>
> thanks,
>
> greg k-h


-- 

Sevinj.Aghayeva