Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp936512pxb; Wed, 6 Apr 2022 04:48:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxR0P+Kb2qbklUa7fTMoG/GT213XFt3hgj66/7TcWXexkfwL2rnQi2BAHKzzI1MqH1U5fRf X-Received: by 2002:a63:9d4d:0:b0:398:4583:9067 with SMTP id i74-20020a639d4d000000b0039845839067mr6936254pgd.220.1649245686466; Wed, 06 Apr 2022 04:48:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649245686; cv=none; d=google.com; s=arc-20160816; b=wQH5ItVcBYJ+20udk4fc9UFC0U2Ropyeocx2LqomjD8BFC/+CVPGXgX4Yr3StCi3sK J3kvRw6es6m1ajmKzE/hRsmNHqViiIWiR0jK8O9xhC7xwjtSaGVBunAyT5OV5KcEnYCp Fg5CEbBE/ydKdeW03WCghQs0ecKGaGZmvnXVwoOhgDB8pKIafX+TF/WQ8Ls36wkSv6zw 5LxcV3OmY3opqKSnK1ctuaumvxKFdToU/oLTNc1iXLQ4pUAj8/a6oxQu4Dh42ghUed2B GhB5rscMYWmVBm9ibCB2tjmucvD/4f3Ysqf4w7p90nSTWrq6Es28m9lB8rNDK6v8zwli iUTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=85HojFJ1QLo1NqAQ2Q62lImbeqbUZHtqZFm17uCPyec=; b=fRABvyQceeNwoJYF/+Ing0hk2N6Q8W6DtnsB5KECWu06yQCfOxPgtLbC/N563tiG85 RABTE0rQOv37R2p9UZeDSz+jyW3i3bMq9V7Of9zbf7mJsogHeq/pQEfvfnlwA8mZ9H03 Ee9rJaDTXXPiTqtcZKEkDXQI9Ls8l4l4G+KVrUx8vnOUbAyftAeaEh/Gr7hMK9/+5Rpe oafq8C+qSepFHB/VD1bip3cAZiGwGHzYB8Fn+omiFqDkc4cEtfGRdaapy6OpkQgF26CT l+NLI5Y79y02L6kR6LsADGMlLoZexVr9xaYHo7NQ9TQaF6+61WoEgRqe2zdlNcc38e5j TTzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="MpJ/eikW"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id l15-20020a170903244f00b00156cd2cc94csi5297010pls.576.2022.04.06.04.48.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 04:48:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="MpJ/eikW"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3B0FB62E2AB; Wed, 6 Apr 2022 03:04:53 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1582997AbiDEXus (ORCPT + 99 others); Tue, 5 Apr 2022 19:50:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349459AbiDEJtx (ORCPT ); Tue, 5 Apr 2022 05:49:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6051D1004; Tue, 5 Apr 2022 02:46:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F0B4F61680; Tue, 5 Apr 2022 09:46:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05FB9C385A2; Tue, 5 Apr 2022 09:46:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649151986; bh=0UVw1YIHqiI61x9atIvc1XzjmQZco7kHz8d5msPmZN4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MpJ/eikWk/0kguYsDFk6NpAjyZ9DsBE4mUjy79TCHxXZWrMAIEuJA6dNom4xdqzCP m02c4jLKbz9oqewlNXUvLPlx9MQE7hv+gbjCNCpL1MhlFwY3llpB+Tw381bTkfVE1U UY4/scL9CY+673n0XNMfuytEzfEP8guU4TOGWSLI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Taniya Das , Bjorn Andersson , Sasha Levin Subject: [PATCH 5.15 612/913] clk: qcom: clk-rcg2: Update logic to calculate D value for RCG Date: Tue, 5 Apr 2022 09:27:54 +0200 Message-Id: <20220405070358.186115662@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070339.801210740@linuxfoundation.org> References: <20220405070339.801210740@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Taniya Das [ Upstream commit 58922910add18583d5273c2edcdb9fd7bf4eca02 ] The display pixel clock has a requirement on certain newer platforms to support M/N as (2/3) and the final D value calculated results in underflow errors. As the current implementation does not check for D value is within the accepted range for a given M & N value. Update the logic to calculate the final D value based on the range. Fixes: 99cbd064b059f ("clk: qcom: Support display RCG clocks") Signed-off-by: Taniya Das Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20220227175536.3131-1-tdas@codeaurora.org Signed-off-by: Sasha Levin --- drivers/clk/qcom/clk-rcg2.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c index e1b1b426fae4..b831975a9606 100644 --- a/drivers/clk/qcom/clk-rcg2.c +++ b/drivers/clk/qcom/clk-rcg2.c @@ -264,7 +264,7 @@ static int clk_rcg2_determine_floor_rate(struct clk_hw *hw, static int __clk_rcg2_configure(struct clk_rcg2 *rcg, const struct freq_tbl *f) { - u32 cfg, mask; + u32 cfg, mask, d_val, not2d_val, n_minus_m; struct clk_hw *hw = &rcg->clkr.hw; int ret, index = qcom_find_src_index(hw, rcg->parent_map, f->src); @@ -283,8 +283,17 @@ static int __clk_rcg2_configure(struct clk_rcg2 *rcg, const struct freq_tbl *f) if (ret) return ret; + /* Calculate 2d value */ + d_val = f->n; + + n_minus_m = f->n - f->m; + n_minus_m *= 2; + + d_val = clamp_t(u32, d_val, f->m, n_minus_m); + not2d_val = ~d_val & mask; + ret = regmap_update_bits(rcg->clkr.regmap, - RCG_D_OFFSET(rcg), mask, ~f->n); + RCG_D_OFFSET(rcg), mask, not2d_val); if (ret) return ret; } -- 2.34.1