Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <1474e665-c619-1a01-3a28-51894161e316@redhat.com>
Date:   Tue, 5 Apr 2022 16:14:25 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [RFC PATCH v5 037/104] KVM: x86/mmu: Allow non-zero init value
 for shadow PTE
Content-Language: en-US
To:     Kai Huang <kai.huang@intel.com>, isaku.yamahata@intel.com,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     isaku.yamahata@gmail.com, Jim Mattson <jmattson@google.com>,
        erdemaktas@google.com, Connor Kuehl <ckuehl@redhat.com>,
        Sean Christopherson <seanjc@google.com>
References: <cover.1646422845.git.isaku.yamahata@intel.com>
 <b74b3660f9d16deafe83f2670539a8287bef988f.1646422845.git.isaku.yamahata@intel.com>
 <968de4765e63d8255ae1b3ac7062ffdca64706e4.camel@intel.com>
 <3cfffe9a29e53ae58dc59d0af3d52128babde79f.camel@intel.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <3cfffe9a29e53ae58dc59d0af3d52128babde79f.camel@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/1/22 09:13, Kai Huang wrote:
> Btw, I think the relevant part of TDP MMU change should be included in this
> patch too otherwise TDP MMU is broken with this patch.

I agree.

Paolo

> Actually in this series legacy MMU is not supported to work with TDX, so above
> change to legacy MMU doesn't matter actually.  Instead, TDP MMU change should be
> here.