Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220405082503.61041-1-iivanov@suse.de> <20220405082503.61041-3-iivanov@suse.de>
In-Reply-To: <20220405082503.61041-3-iivanov@suse.de>
From:   Dave Stevenson <dave.stevenson@raspberrypi.com>
Date:   Tue, 5 Apr 2022 12:21:25 +0100
Message-ID: <CAPY8ntArikrec3DOv_yB9kdhZex97B2aY5bfK7ye_fkjjRSgxQ@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] clk: bcm: rpi: Handle pixel clock in firmware
To:     "Ivan T. Ivanov" <iivanov@suse.de>
Cc:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Maxime Ripard <maxime@cerno.tech>, linux-clk@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 5 Apr 2022 at 09:25, Ivan T. Ivanov <iivanov@suse.de> wrote:
>
> The clk-bcm2835 handling of the pixel clock does not function
> correctly when the HDMI power domain is disabled.
>
> The firmware supports it correctly, so add it to the
> firmware clock driver.
>
> Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>

Acked-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

> ---
>  drivers/clk/bcm/clk-raspberrypi.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c
> index 2e2491d85835..530820d13104 100644
> --- a/drivers/clk/bcm/clk-raspberrypi.c
> +++ b/drivers/clk/bcm/clk-raspberrypi.c
> @@ -129,6 +129,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
>         [RPI_FIRMWARE_V3D_CLK_ID] = {
>                 .export = true,
>         },
> +       [RPI_FIRMWARE_PIXEL_CLK_ID] = {
> +               .export = true,
> +       },
>         [RPI_FIRMWARE_HEVC_CLK_ID] = {
>                 .export = true,
>         },
> --
> 2.26.2
>