Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp954527pxb; Wed, 6 Apr 2022 05:14:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZVMapdRQJjFjLclKdBhcaybmRd6UmNEWdUFgu1+qdXwl4H7PrAmrhPl20pR02+HgsznyU X-Received: by 2002:a63:e30a:0:b0:385:fcae:d4a9 with SMTP id f10-20020a63e30a000000b00385fcaed4a9mr7099595pgh.85.1649247247209; Wed, 06 Apr 2022 05:14:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649247247; cv=none; d=google.com; s=arc-20160816; b=rLmr/MDPJsBWCWXJPhhamNG1MIGMUhqwcBXIXxVuktXIuOh2pbHFzNr2r4sJDgf2AO vDrn6j+n3ot+unAqZDOQBEgQ2mx/QuaNh3vDNGMUo5rfk/hZLH9mDleeaRB06RVIRhHG N6zWR7Q+e2JUptw6THGafxrPz0u23srsdUxxeFqjWkK5HoPwKVtUEpeXz3sOr8TVP6+j a+I6Wykijza4hKq1XBYRged0RcV1Kga43mrsIv9Z4GBfiXIhMjydPZuJSPm0A+XmcRcW i5ffDhdW6sbrqXdjuRmJFHIo/jdr8X0CP9BQ2KgsrSbSVL7B+GDz/WSm2tNJ70hIICxu I1Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=8HBpgOGIWG9ETgsG7Wst3wSQlsF6QqlUH/m56PYbcF4=; b=fBvrFhfOfRKQ7mA0iPLwyhOeX+cUa44X6J67vFWrLH8NL8ikcE8S9PJhJz2AWHRG3j yNRfKKwCFQV9Vybl1reGPYs8dZMBAFuDV1pJHGRDg+GE899T4gUN57L49029Zs4GVjqR CcMBxqQsKzCe9o92e/8EzHg2QFvLV5JEhBaK0/vf3egNMa01xIIkJr6bXtjAy8DwdGcp 1LqaG47Zg5WCQRB9I8ENqjWHiuWrpdRL9Urs7tM3lEaWULYhi0CIFkIiwfFP2BILVCq2 PDuTyLlMf0aPn2Yij2BwvG82rsSrmCemn+mGzeITOZC4roNkdvT+TC8UUUT/tkbs1gAQ k0yQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@raspberrypi.com header.s=google header.b=r+WQ67jW; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=raspberrypi.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id q3-20020a17090a2e0300b001ca86a1e430si3962619pjd.121.2022.04.06.05.14.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 05:14:07 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@raspberrypi.com header.s=google header.b=r+WQ67jW; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=raspberrypi.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 64B51515F6D; Wed, 6 Apr 2022 03:53:12 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1385133AbiDEVtJ (ORCPT + 99 others); Tue, 5 Apr 2022 17:49:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352119AbiDEMI2 (ORCPT ); Tue, 5 Apr 2022 08:08:28 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AE7284EE0 for ; Tue, 5 Apr 2022 04:21:43 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id i27so18890903ejd.9 for ; Tue, 05 Apr 2022 04:21:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8HBpgOGIWG9ETgsG7Wst3wSQlsF6QqlUH/m56PYbcF4=; b=r+WQ67jWrMQNbPPlSV6FaBSfL3cneBxyAUt8105r5J1wNlYb7d2d4cmBZogrNadtBD 4wbXAeKy3Fu17tpfyBJprZ5HroGpb+HIUitxYNkt//jw3+QfW0dkNKorw/46F+jpI6fB ax8MJ3H3ufgSqV5PqItN5Skfbn/UhW0h9QMww4RXGg8rut3iqu7ZV0eBGk2oLAQOLXPA ahCOX/6pCMCF3W7Y8HbW8F11M4gLfIPaNB/LFi9mnznGKmrPHOsi5JPuzyyjElkWielN utf8nZEecvkvtE6HZ0eXr/nxd+eezu9DXFbd3u5FJhLEXmLGuBVeBwbz/gc4tlioJPO+ pQfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8HBpgOGIWG9ETgsG7Wst3wSQlsF6QqlUH/m56PYbcF4=; b=i1De71E/mGZBTEQ50JUhZ2+nOSku1yyJLrzcnvgXzhv6X5jinhdaXB7ThcxYDmT28Z Xi81Tw9Xmi+8nTGynwM0dHOF13eR9kpiV+zDZ6JvgZxcFzZYgra152vp0wXEZgcwVE5l NZV6erABP3t02NiOaPPGbdk1CjARvmbqOO2RvSur6oPc2meAkKHoQp+pXagkYQefvmJ6 /au/Y4Kyu465LTPbdLatWAVFLfZQMKPz/9hE9Q018ICtxEC54L/UJWv5j0HcusgQ/RHM N3hv5RDnbqBb7QG0NS/HIsAnZF3J7SUdpNWVAPr/6VQcO98p7c7z9gw0J0TlLo6qW1Kl CTcA== X-Gm-Message-State: AOAM532EC0lT0EEoT4LPpKi3P0+0BGolgjQFtOjSR6lUszcgiyDE+Yzg eqWUttM6/0zstfI+8zLn2u9iEQptcnDrv5tinjG2glDfSAo2DQ== X-Received: by 2002:a17:907:1b1f:b0:6e4:b202:db68 with SMTP id mp31-20020a1709071b1f00b006e4b202db68mr3138316ejc.294.1649157702311; Tue, 05 Apr 2022 04:21:42 -0700 (PDT) MIME-Version: 1.0 References: <20220405082503.61041-1-iivanov@suse.de> <20220405082503.61041-3-iivanov@suse.de> In-Reply-To: <20220405082503.61041-3-iivanov@suse.de> From: Dave Stevenson Date: Tue, 5 Apr 2022 12:21:25 +0100 Message-ID: Subject: Re: [PATCH v2 2/2] clk: bcm: rpi: Handle pixel clock in firmware To: "Ivan T. Ivanov" Cc: Michael Turquette , Stephen Boyd , Maxime Ripard , linux-clk@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 5 Apr 2022 at 09:25, Ivan T. Ivanov wrote: > > The clk-bcm2835 handling of the pixel clock does not function > correctly when the HDMI power domain is disabled. > > The firmware supports it correctly, so add it to the > firmware clock driver. > > Cc: Dave Stevenson > Signed-off-by: Ivan T. Ivanov Acked-by: Dave Stevenson > --- > drivers/clk/bcm/clk-raspberrypi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c > index 2e2491d85835..530820d13104 100644 > --- a/drivers/clk/bcm/clk-raspberrypi.c > +++ b/drivers/clk/bcm/clk-raspberrypi.c > @@ -129,6 +129,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = { > [RPI_FIRMWARE_V3D_CLK_ID] = { > .export = true, > }, > + [RPI_FIRMWARE_PIXEL_CLK_ID] = { > + .export = true, > + }, > [RPI_FIRMWARE_HEVC_CLK_ID] = { > .export = true, > }, > -- > 2.26.2 >