Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <6a74d717535179188606dea3c68f56d35a86bac8.camel@linux.ibm.com>
Subject: Re: [PATCH] ima: remove redundant initialization of pointer 'file'.
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Colin Ian King <colin.i.king@gmail.com>,
        Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
        James Morris <jmorris@namei.org>,
        "Serge E . Hallyn" <serge@hallyn.com>,
        linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
Date:   Tue, 05 Apr 2022 08:43:24 -0400
In-Reply-To: <20220301120732.670168-1-colin.i.king@gmail.com>
References: <20220301120732.670168-1-colin.i.king@gmail.com>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2022-03-01 at 12:07 +0000, Colin Ian King wrote:
> The pointer 'file' is being initialized with a value that is never read,
> it is being re-assigned the same value later on closer to where it is
> being first used. The initialization is redundant and can be removed.
> 
> Cleans up clang scan build warning:
> security/integrity/ima/ima_main.c:434:15: warning: Value stored to 'file'
> during its initialization is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

thanks,

Mimi