Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp962302pxb; Wed, 6 Apr 2022 05:25:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZ3FilaEGNSZykjKFFP+SIWc9FNintWu9VuT4UDnLSUlGD9RFElSmXtsSy3pD0kbLZGmzT X-Received: by 2002:a17:903:1210:b0:151:fa59:95ef with SMTP id l16-20020a170903121000b00151fa5995efmr8628452plh.57.1649247939552; Wed, 06 Apr 2022 05:25:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649247939; cv=none; d=google.com; s=arc-20160816; b=ZBH1BiLM3Dzhl+MiqrYQY7qqu6os3GONqhwmqWRTgHaT7GQLiKU0nCGYiEhf5EBGw8 CdP4V6nNPkEQjcLk+dDPE44KJv+3bQuXXz3G+kShRaB1zjSIdK7RWHgPuV1OGsnuPhu5 4tbyOczvn25qFz97hyNNmHy2N+l1v+yjaL0h2Nc58tJ7bdVdbfdc/lbc+5Hr6CtDo4rO mVmYnz586/NufaHuPX4PPO8KARgLG6Njpm/aeahzaYgZrp9TB56YYyII4n0ta27raPop 2h0VqnN2Jq/4TrytxyF/34X28TyQTHoVpDj48FK8G8TiIKWcBKAullfKBEJKVL+U1xUW liSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=5ihDC8svoYNzIK8hMFPyp1shfnbI2+1sTt6+M9occ8s=; b=Z8CvyXMBQkRDJBX2gDJPzmNM0/1M79vtiCfNabzJS6gX/MEMsEbt6SB0gWPKPbN+eC Q10WRyJjl2mXt9ZVHkLFTfZNuJ5eZO7jOIXzUZdnG4EpwALtO2U+onRcUurMcTkms6xA yZm/vUSfIdZa9HJaN6WJfwYmi0Yzr7QYAgQfgwku9XFHPDxjRlDknEebyfOI6a1LOEXE 8EdB7EOJ7U4U9MH4t2HaeO2C05lIp18PjoGpfduEHh3N1NCtPVkO99lG9QGrpNdkyl5Q 6+c8iZfDlj538s6fNyVYnl1K8RehmUhcr8uEU1T1gXBWztbF9x91tUA0cI/uhMgnb3Ey ssZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=IUkkLfim; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id a13-20020a65418d000000b00398b858c5d4si15707124pgq.525.2022.04.06.05.25.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 05:25:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=IUkkLfim; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 52B3F6E2632; Wed, 6 Apr 2022 04:35:21 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573853AbiDEWxd (ORCPT + 99 others); Tue, 5 Apr 2022 18:53:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1458142AbiDERKP (ORCPT ); Tue, 5 Apr 2022 13:10:15 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96BB853E0D for ; Tue, 5 Apr 2022 10:08:10 -0700 (PDT) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 3F46B3F7F8 for ; Tue, 5 Apr 2022 17:08:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1649178489; bh=5ihDC8svoYNzIK8hMFPyp1shfnbI2+1sTt6+M9occ8s=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=IUkkLfimBJWf98kUMI2g9SirAuVXQOUPA3bh6YbbqNWxS3lgf7t/5zA6RflitTCXs 41HLAJtp1A9U4o7JeMLl9l2TJ6P1vjIfMA8NxvppLlEwoz6u633oTtGVUXNp95nemM IEzCMIzuFKWRs4Q7DgtXA6JvSSBR7RjD8VHQ0nECVlSAtxWxBGxvhBCIvyeGR4La0o ATEwFzYYfPz3ue8rsJfddPbmFOXnsfnKgnuJopniPUIws7tCE0S/2DmJy4EsXEbRD8 TI78+BnSjHtKOS9CoceoCh+S7CB2IrkUW4/VVyR0PUDHf3A+xNNhvZORbXJZiuJXe8 ZAea2dKoz/1vQ== Received: by mail-wr1-f70.google.com with SMTP id e4-20020adfa444000000b002060b7347f8so1774897wra.6 for ; Tue, 05 Apr 2022 10:08:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5ihDC8svoYNzIK8hMFPyp1shfnbI2+1sTt6+M9occ8s=; b=LzdtEnWw6B+LkEinl205j07VAqNbZL90SRMcQM1AaXTamf1AFYNypaR/5CeipNh/rc YJcefi0t2ffxYloQADmqz6DNf6pj36ckRQrKZWcVdt/zUaT2f5cmekpFO3WeIZtjJ3me DTPUcBlkZOHE1YwZoAIaWyQ3HPFPoF1ODiRBbC5GOD8pzZoEo6yH2HOxfGoNGIdLwhqW nKMIQ6Dk03e+acqWqAtRWWYq29ErtjfribZf8XvZ8mGcIa/wxySuqqC70oqejZO2K3Hv t1uW9RPwEPfE4ox6Chbo0K0C8aruZCBnul9PV3ZP/wQULMcfrGOgI1AYGzUnC/063xx+ P5ow== X-Gm-Message-State: AOAM532NSTiQ3WOfAGk/r19Gm/ZWqa3bz3YkqsWDBm8wvpmXmDo6rPFG I2XrhxURBdxND1yJjoqsbuvWlwsON230+r36pGoOVKBQO/1tqVTs8XNNPM4AolZTUamSyf+ALMk qWRnr7959fzwG916mteYssIEDgHrj+WoDLiTPgOx6t073izQKfAexhInkog== X-Received: by 2002:a05:6000:1203:b0:206:1837:b5a8 with SMTP id e3-20020a056000120300b002061837b5a8mr3473856wrx.232.1649178486071; Tue, 05 Apr 2022 10:08:06 -0700 (PDT) X-Received: by 2002:a05:6000:1203:b0:206:1837:b5a8 with SMTP id e3-20020a056000120300b002061837b5a8mr3473845wrx.232.1649178485847; Tue, 05 Apr 2022 10:08:05 -0700 (PDT) MIME-Version: 1.0 References: <20220405070354.155796697@linuxfoundation.org> <20220405070400.156176848@linuxfoundation.org> In-Reply-To: From: dann frazier Date: Tue, 5 Apr 2022 11:07:53 -0600 Message-ID: Subject: Re: [PATCH 5.16 0199/1017] PCI: xgene: Revert "PCI: xgene: Fix IB window setup" To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Marc Zyngier , Lorenzo Pieralisi , Rob Herring , Toan Le , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , =?UTF-8?Q?St=C3=A9phane_Graber?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 5, 2022 at 11:00 AM Greg Kroah-Hartman wrote: > > On Tue, Apr 05, 2022 at 09:42:37AM -0600, dann frazier wrote: > > On Tue, Apr 05, 2022 at 09:18:32AM +0200, Greg Kroah-Hartman wrote: > > > From: Marc Zyngier > > > > > > commit 825da4e9cec68713fbb02dc6f71fe1bf65fe8050 upstream. > > > > > > Commit c7a75d07827a ("PCI: xgene: Fix IB window setup") tried to > > > fix the damages that 6dce5aa59e0b ("PCI: xgene: Use inbound resources > > > for setup") caused, but actually didn't improve anything for some > > > plarforms (at least Mustang and m400 are still broken). > > > > > > Given that 6dce5aa59e0b has been reverted, revert this patch as well, > > > restoring the PCIe support on XGene to its pre-5.5, working state. > > > > > > Link: https://lore.kernel.org/r/YjN8pT5e6/8cRohQ@xps13.dannf > > > Link: https://lore.kernel.org/r/20220321104843.949645-3-maz@kernel.or= g > > > Fixes: c7a75d07827a ("PCI: xgene: Fix IB window setup") > > > Signed-off-by: Marc Zyngier > > > Signed-off-by: Lorenzo Pieralisi > > > Cc: stable@vger.kernel.org > > > Cc: Rob Herring > > > Cc: Toan Le > > > Cc: Lorenzo Pieralisi > > > Cc: Krzysztof Wilczy=C5=84ski > > > Cc: Bjorn Helgaas > > > Cc: St=C3=A9phane Graber > > > Cc: dann frazier > > > Signed-off-by: Greg Kroah-Hartman > > > --- > > > drivers/pci/controller/pci-xgene.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Hi Greg, > > > > I don't think it makes sense to apply this to 5.10.y, 5.15.y & > > 5.16.y w/o also applying a backport of 1874b6d7ab1, because without > > that we will regress support for St=C3=A9phane's X-Gene2-based systems.= The > > backport of 1874b6d7ab1 was rejected for these trees because it doesn't > > apply cleanly, but I've just submitted new versions that do. > > Where were those patches sent to? I don't seem to see them on the > stable list, did I miss them? These are the message IDs: <20220405142505.1268999-1-dann.frazier@canonical.com> <20220405153419.1330755-1-dann.frazier@canonical.com> I've just bounced them directly to you as well. Thanks Greg! -dann