Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <495705cc-be0e-9eba-48d4-231f851354b0@amd.com>
Date:   Tue, 5 Apr 2022 12:46:04 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 1/2] x86/mce: Extend AMD severity grading function with
 new types of errors
Content-Language: en-US
To:     Yazen Ghannam <yazen.ghannam@amd.com>
Cc:     bp@alien8.de, tglx@linutronix.de, mingo@redhat.com,
        dave.hansen@linux.intel.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
        bilbao@vt.edu
References: <20220331163849.6850-1-carlos.bilbao@amd.com>
 <20220331163849.6850-2-carlos.bilbao@amd.com> <Ykx59WvoWKi2y23x@yaz-ubuntu>
 <ec7dc7e7-5808-58f8-cbe9-d8fdd2de4c35@amd.com> <Ykx/RYZpKi5SQ/NN@yaz-ubuntu>
From:   Carlos Bilbao <carlos.bilbao@amd.com>
In-Reply-To: <Ykx/RYZpKi5SQ/NN@yaz-ubuntu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2xtd1RXallxdzZlZUVYL2RmZlQrd2dBNU8vVXdEZ1QzT2U1VFQrc2htRmlK?=
 =?utf-8?B?OWdIY3hWWmR0WU9NcUpVQ28zWDZLcFVRMitVR09GaDVseG4zd3RYZkM3WWhy?=
 =?utf-8?B?WkR5QnFweWU2ZFIzZHNIbklIbHdsWjB6cENFSHI4cmRNRGlzRDM4Zjc0VlRC?=
 =?utf-8?B?RlJRUFo1Vk5ZTFlRVUEwVWdqNEVCNS9HOXc4UGt4TWk4cm9HTnFIUHM4SWVv?=
 =?utf-8?B?SGF6SWp0aEpZT1h0NUpLRng5bk1RazNxQmp3eDVYU1FOMVlHQTZJaGZFVjlr?=
 =?utf-8?B?UVpSOHIxdllQUUhBNUNkL295L3pTNXg1U2dpbkcyTytiQXpQVEJCR2QrUlVy?=
 =?utf-8?B?MUV1bGErdGlGZzFwdHhNM3JGSXJraEFJQTlaZUYvR0ZOQzVOSUZZeVB4L2xY?=
 =?utf-8?B?ZUs1dE9tQTZMZnVKdkY3NHAxUkRObnpXWDQwTDlaU1BGL3FIaFNMVTBFSjlB?=
 =?utf-8?B?elNnWlR0RWVueHg5NUZrWWJuREN3a1hhMjhUaC9yNVduNVRibDJiRk5CWFAv?=
 =?utf-8?B?dzB3cGtKenA1WW4zYU4vYmdVSzlSZnlhSFBKN00zS1IrckhUVTFZaDlDeGl5?=
 =?utf-8?B?ekhkNkVDSWwrTmdiNWFiWGN1SUpiVXJucmc3Vnh1OWlKTHdHd3l3S01NcWdJ?=
 =?utf-8?B?MDBCZVAxTEhPelJCQlRobnV2MDQzVCtVcCtNcVhVQTZ0RG13SWlseE5tdGRh?=
 =?utf-8?B?V3JwV1pYeEY1Vnh1LzNKeFdrdFpWMTYrMTRlcTh5RHZJeXhDTTUxT3FxMjh5?=
 =?utf-8?B?VHJwcjdrS1J3dWp2aWlXdVFEbiszc09IN2RaVTZoVldIZDk2aGgvVWNiR1lw?=
 =?utf-8?B?WkZTTktOc3FzWjNTMk8wUEUwenZTbGhKVng2cDVsbW5aSDhYZC9mSWgzenBv?=
 =?utf-8?B?SUhvQVNrZ1N3TmlBN0tvNmh2YTlQV3IvdjBEWktwY2RxRmplUTVleEJiQ2F2?=
 =?utf-8?B?eUVDcXN2UmFFbnhiSDN4VzRsbkZ5YjU5WHlxemZ1c281d1JhZHVON0ZPN25S?=
 =?utf-8?B?dHZLSkJTNTh6amc2WEltejcxRXpjMEgrS0Evc2txV090aGpiNTJBN1lNYzV3?=
 =?utf-8?B?SWl6UFZDRWo0c3JHSEZDUVdzZG15eVRGYnFNTVhhQkdRZ3JPUG91enRCNDN4?=
 =?utf-8?B?c1lTUkE4VElva2pJMlJWOTU5NmJzZWdZandNZ3N4dFd2dG5mcmc1dldiazh5?=
 =?utf-8?B?TTlWZGZCR3l6Z2xsenRpaC9OMGoyd0s1OEEzdUhGYUcycTFUMWd5eTdvL1dh?=
 =?utf-8?B?TnJZNG53enJxTDZOK0pYWldibFBjVmFlWlgyWGEyVGZ5YnhtUVpzeXkrbGE0?=
 =?utf-8?B?ck8xelhuNEIrOUI0N09uenkzWDZSSEJiL09LR0JTMXg3TkZpd3hIUXY4cHBJ?=
 =?utf-8?B?SFpXWlFQSzluU1FoeHY4TnZOM3Q1ZDdXY2RQdktsZWpLMUlPMTJTbDBUajZB?=
 =?utf-8?B?d0hrOS8yVm12ZjVmMGtxRjNDUkN1WnVsZVZ3M2JjSDROT05ZeTRhOVIzSTRW?=
 =?utf-8?B?K1U3ZEY3bm5vUUNpYlZtZG9zV2kyaHhkM2xURVJNZHV6S2FKWkExYlNYdzlV?=
 =?utf-8?B?UzZZUWxUOVpqbm83VmQ5MGhQM2pQVndYQVVUNDRvenVNcmd5MWkybENTNzM4?=
 =?utf-8?B?NVhIYmw5bFBSMVZFYm9zYlJzYVdLS0JVYVp1SkI0SjZsT1dEM0NHeHNZanl2?=
 =?utf-8?B?VThKclMxdnhJRWVFYmtEV3hqQUIyWks3Tmh4Qm13QU5SNHNucDFYUVBwMktp?=
 =?utf-8?B?MXNReG1UdEZFc2VUNW51cFJveGp6UVlpUmErckRHZlRXeXdPd0d0a0x1WXdz?=
 =?utf-8?B?MUdYZjdaZVFVemlCWVNML3NyV1JwOUN0dDZDamZPS2FFWU8xbEdqTUZwekd5?=
 =?utf-8?B?UzZpeVpKMEdmTVlWaWhBTmhjTys3OGJ5Z3hHQWZTSGJMSXRPNUFTeTA3amRl?=
 =?utf-8?B?dGlqZkdRdERORm9QTytSRDZveXdxTGtkRStFMmVENnl1VmxENFdEYkRMMTh2?=
 =?utf-8?B?VkNOcG5pTHBIeFFpcVBheUZwRHY2UVF3MWFsVFNLTG1UK1JkWWE3RFJOdjEy?=
 =?utf-8?B?TktVMU9Ic2w2VzRyY2lCZExTOFNYNDFDZnVlakdZa0xQUzg1OXpKU1pBUG1W?=
 =?utf-8?B?Tm1mL3JML0ppa2lnak1xVkZFMlZHWDlJNy9uK282U1hST2JXQ1pwNTF6Slhu?=
 =?utf-8?B?WWlFYjJTVzhDOUxtNG5jUk1NaGFMc2RNUXJDT0ZTU0JSM3ZUdTkrY3NaRUxy?=
 =?utf-8?B?RjBlVnhaVmkvOTJwU29SODZzejg4QWYzTmYxTmNnSUJuTzlqNHBXTnd2VEVT?=
 =?utf-8?B?UDgvU09maExGZFVyMjhRdGkyVkpLd3RIRzEwMjc4dzRsMUxCQ3Q3QT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b4e4ac35-5344-4b2a-c5c4-08da172c2947
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 17:46:06.6622
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1QIRfoIBNXQMXDixNgxKJwSLM+30Icx2ulmokqoeH8gUmTkxClbph1vmjGA0AmSKpoJgoizuSJea39bO1AHhvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4486
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/5/2022 12:41 PM, Yazen Ghannam wrote:
> On Tue, Apr 05, 2022 at 12:24:31PM -0500, Carlos Bilbao wrote:
>> On 4/5/2022 12:18 PM, Yazen Ghannam wrote:
>>> On Thu, Mar 31, 2022 at 11:38:49AM -0500, Carlos Bilbao wrote:
>>>> The MCE handler needs to understand the severity of the machine errors to
>>>> act accordingly. In the case of AMD, very few errors are covered in the
>>>> grading logic.
>>>>
>>>> Extend the MCEs severity grading of AMD to cover new types of machine
>>>> errors.
>>>>
>>>
>>> This patch does not add new types of machine errors. Please update the commit
>>> message (and cover letter) to be consistent with changes made between patch
>>> revisions.
>>>  
>>
>> I'm thinking "cover error cases not previously considered".
>>
> 
> Please elaborate. It seems that all the cases in this patch are already
> covered in the existing code. This patch seems to simplify the existing code.
> 

You are right, will update. Since we don't "extend" the severity grading anymore,
i.e. will change commit message, it's probably best if I send a completely new patch set 
instead of considering the next iteration v3.

> Thanks,
> Yazen 

Thanks,
Carlos