Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp972656pxb; Wed, 6 Apr 2022 05:43:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGzSIvwK1ebkCNSCsYSj6r/9ZCPFyTt8CtP9xjboY3IE+hSrM0Oy5D538Vo1aaX+lfM9Sq X-Received: by 2002:a63:1847:0:b0:381:8214:3a7d with SMTP id 7-20020a631847000000b0038182143a7dmr6806570pgy.134.1649249031346; Wed, 06 Apr 2022 05:43:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649249031; cv=none; d=google.com; s=arc-20160816; b=zkugb0RapnL7d9qHtqdTNxxlIIK7L6H3YwzQvhsJUFw1x8ILwY6V2HxjMSendTghG/ B7emqDz+TSWskm0ohukD5lbw512Z+uIdeVwrtDUEZd8cYjg4E2/C2hjAHrSKrwHA87DG PEAoPmQGtj8fxKDTMmqYVmNdzW7MKkmt4Ytdkq3EPD/XX9Jk8nVFpoNRVgw8y7A/pZ3+ OI+02A/GEU/FdhBD/qeHdpnmtKWzY+DaEqa4iiuHJ+GMIaQPJWwj60EDgOgvFm6bEJ8G 7b4H69f7KFMBnR6lD3bRWoP0OgGwC6NzImA27kiKppFvEw3XQpfxZCiwNrduTurASA1f /LEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=FHn0PwEiin7LlMUr494svix6/+oIcBJvm4+uNXinND0=; b=EzQZ+igrV0rXqniLI4kvMPDDLJzJiDMcU1HErP2fh0bLhGUsVTF1lAV9Om4iWznIHU fXM5X8KY6a+klev6XKMZikAoVg/NJBnLHuLaWG/zvA+AwT+Bau34Q4VYaUXq6mpoj4dL V/KWwvCVmolq3uIEPY/i41384OKDPVrLv9NmuV3hbnPpUzn1EGMelEMA0gMbEsqRQRmb wbE8YbnDxrek1FR9yT1anrlT8olVCko0laAqGz+boCrNWSSIAH3tMRw2yyUPU97u3RlP pcdOVEOMJ/25Lu4SHOkN+Z4dgFN39BwhmAzsITSciIJclE9oJokQoJg6tXYhcjzHdSJ5 Se2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=YHL0QdBT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id t13-20020a63eb0d000000b003816043f127si16080045pgh.796.2022.04.06.05.43.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 05:43:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=YHL0QdBT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 30D8D2B4DD8; Wed, 6 Apr 2022 02:22:03 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1844728AbiDFBvw (ORCPT + 99 others); Tue, 5 Apr 2022 21:51:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383922AbiDEPOu (ORCPT ); Tue, 5 Apr 2022 11:14:50 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A4C9176D2B; Tue, 5 Apr 2022 06:28:10 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 5C7E11F45039 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1649165288; bh=Z7ly7VhlEOXC12e1olu1To154Rm7ZW9SK4TYqH7rDZo=; h=Date:Subject:To:References:From:In-Reply-To:From; b=YHL0QdBT1QmRtgT1WU9noVhfECYnV9pv95Lc/V6R++QnDzUSC2k02WMDvZxPYIqfC gLEPY9mGBOB3Ne3oJ9Fvio2HgVmNjVcTPPJywzKLqnLMgSHzyyxNm2VU+OKPP7xUgS NxHwaXlNkMsQ/0RoyXHb0SeMz7dJ9xRxhR6tUCYcwGWgKSpCG91s4GtEhC5WjcfAQ8 fdMxOZq/UtoMGw2siwvAgd0HgX4GvVXbRt1i/W+IOsTvRtIQZFxYAEieFZrDEHzDRx TsPLd3kKeLSeWHpX3guu/wf6Vy4idnvwHtLUOAFiBAH4HGkH1w0w6y+HElgwdZltN7 8yKI1tAXvkkaw== Message-ID: <4bf0e4e0-6b87-5de3-22ff-b1f6b4cde0b4@collabora.com> Date: Tue, 5 Apr 2022 15:28:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] rtc: mt6397: Fix potential NULL dereference in mtk_rtc_probe Content-Language: en-US To: Miaoqian Lin , Eddie Huang , Sean Wang , Alessandro Zummo , Alexandre Belloni , Matthias Brugger , Tianping Fang , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220404132553.28064-1-linmq006@gmail.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220404132553.28064-1-linmq006@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 04/04/22 15:25, Miaoqian Lin ha scritto: > platform_get_resource() may return NULL, add proper check to > avoid potential NULL dereferencing. > > Fixes: fc2979118f3f ("rtc: mediatek: Add MT6397 RTC driver") > Signed-off-by: Miaoqian Lin Reviewed-by: AngeloGioacchino Del Regno