Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp976616pxb; Wed, 6 Apr 2022 05:50:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVoPtU4lJ+p9xt3E1t3TAGL317v+5GigP5P0PPYqknUuERuGIe6ZZLVfYdbLdkEUKVT4Lm X-Received: by 2002:aa7:88d6:0:b0:4fa:ba98:4f5d with SMTP id k22-20020aa788d6000000b004faba984f5dmr8737051pff.5.1649249443564; Wed, 06 Apr 2022 05:50:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649249443; cv=none; d=google.com; s=arc-20160816; b=VSVLwXCzZCLz1jQt5gs34f4G88JrZQPOe8yFEo24ids85c8wZ6SNUCNQvdaKQVVed9 lxQu7x49SJhGMW8ubtqrdOsoxk+y1/LR5qEdtVFSTl8TomCJfD79CTONgkoWTdiTn0iM GTrwj5fdneIZecpFj1Gbuc3IQU38ypBi7x2/LIeoZvVZkDqnur7y2moV6kQ3U+XfpbjI ZLcq5CCc+XUhotg/s/rKfugwB12ecuHVOMmDzjryAGNWGRP5PseRitr5T0kJ2eUV/kwk Ebi+xj6nkqrfXVKbdpwo8irzNv2k5k1+wQDeJVCPkg30BrbRfeOWfoCaQB5X7d6Zv+Bv NXhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ejfNCBLg/ySFah4/4qZcOM5AUO69i4q3mA/rv+9wN00=; b=FyBcI/b95MI9tXCVulAkIZxSpckFZAuWgXQhCExbn3xoXsNJ6Kuw6zD/Vy6FIlhl9V 72K6zIyIJdS4QmWLu4ZpSxgwtKKZ5h/HNxm5euEfi2LZ56i/byYa3fLJOhqmL+LNC//7 7j3+dmlns4Ib7EN07RXWpG048Gm1r0wxP71e+G/pZz67GUkBR8e7hFAkoG8z/qHv962F I0CAmvEJBebxUl3GSu3jP32gRfk8Xvc87VldUhk9+mrZrUyA/dPxPTZwbn4lRELFySDm Zj6RK7cMRQMWX0yZHiROdsS7wBbUd9bV5fMyzYG/1MvEXRpKvFRlV3Gh38IzZSaIAbJA /nuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uitfP1z2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id b12-20020a65668c000000b003821f536216si16769243pgw.578.2022.04.06.05.50.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 05:50:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uitfP1z2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9A8345D9BAB; Wed, 6 Apr 2022 02:39:42 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231431AbiDEVUZ (ORCPT + 99 others); Tue, 5 Apr 2022 17:20:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349606AbiDEJue (ORCPT ); Tue, 5 Apr 2022 05:50:34 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B8F4ED; Tue, 5 Apr 2022 02:48:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 7EA96CE1C6C; Tue, 5 Apr 2022 09:48:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9343EC385A1; Tue, 5 Apr 2022 09:48:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649152112; bh=Vsd42PPUK3t7g0u09QB28bdvrrlD0K9u5QGtoOtoB+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uitfP1z2FF9KSPj2aj6JOfkRiqNL1uzI6M2rLl0I14lVN030IDHCyENGTwVaJFtfE aJuHgqTJKtBbgUgmalyfBAS//AcWs20/8mz3uNwPhSZK7RmgHkmeiYnWChtSXi9lOx Sv+EZFo7C+jrY2lwN32aR3ztt+4e/j9GTbxGZizE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stefano Garzarella , "Michael S. Tsirkin" , Stefan Hajnoczi , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15 657/913] vsock/virtio: enable VQs early on probe Date: Tue, 5 Apr 2022 09:28:39 +0200 Message-Id: <20220405070359.531891031@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070339.801210740@linuxfoundation.org> References: <20220405070339.801210740@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stefano Garzarella [ Upstream commit 88704454ef8b00ea91537ae0d47d9348077e0e72 ] virtio spec requires drivers to set DRIVER_OK before using VQs. This is set automatically after probe returns, but virtio-vsock driver uses VQs in the probe function to fill rx and event VQs with new buffers. Let's fix this, calling virtio_device_ready() before using VQs in the probe function. Fixes: 0ea9e1d3a9e3 ("VSOCK: Introduce virtio_transport.ko") Signed-off-by: Stefano Garzarella Acked-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/vmw_vsock/virtio_transport.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c index 4a8548bdf86c..c5f936fbf876 100644 --- a/net/vmw_vsock/virtio_transport.c +++ b/net/vmw_vsock/virtio_transport.c @@ -627,6 +627,8 @@ static int virtio_vsock_probe(struct virtio_device *vdev) vdev->priv = vsock; + virtio_device_ready(vdev); + mutex_lock(&vsock->tx_lock); vsock->tx_run = true; mutex_unlock(&vsock->tx_lock); -- 2.34.1