Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 5 Apr 2022 17:38:59 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Carlos Bilbao <carlos.bilbao@amd.com>
Cc:     bp@alien8.de, tglx@linutronix.de, mingo@redhat.com,
        dave.hansen@linux.intel.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
        bilbao@vt.edu
Subject: Re: [PATCH v2 2/2] x86/mce: Add messages to describe panic machine
 errors on AMD's MCEs grading
Message-ID: <Ykx+swi/SBjaEzLq@yaz-ubuntu>
References: <20220331163849.6850-1-carlos.bilbao@amd.com>
 <20220331163849.6850-3-carlos.bilbao@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220331163849.6850-3-carlos.bilbao@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1YVhyDev0ieWpFJB7fKcEsRr7BT67TQ0LpHBHZWGhfHBE6fafTXg9NxAv0Po?=
 =?us-ascii?Q?YcYVR3/bG8KhlMmQ89gu+4pR8x2E/8tINlKJWvAHDuU/3OWyv8MnJMkdZjjA?=
 =?us-ascii?Q?/jdx+TsZGVJz2Y0/Y6gkvG7EtIGyC9CBDOa8IA3AMTOOkDM8Ud5zPwvWQQRn?=
 =?us-ascii?Q?OhorgQrATkTxWWGPfUl/4FM9bsQOLA+PSjchNK9ijcd+93bx4MjePa0ekGbN?=
 =?us-ascii?Q?HZ0cPD7ti6DFa1HlfM3SA5o49hi+MuwnfWMr2J8byt7FDnC6gkFP2ED4ZbRy?=
 =?us-ascii?Q?KF/uSy/7mfiZmptRQwI5Dt8W8CMEXb1tDwujnh9/DDc0DyCir8F8S2h70Qvd?=
 =?us-ascii?Q?45gRP1mcAHFBHsrz55A0+ym455ga8z9J9ZGzgdHsjlz/1+GfjaU/97YvV3e3?=
 =?us-ascii?Q?i4Mm6FFz9MPAceYqYEdpZlEN5c9d3A6myssMFHYg/JCWIfQZ/d4gp4tYhi1v?=
 =?us-ascii?Q?oF8TW7x5cqq6A12K3h40CfD3D2DF5wDYiAZ7lLoH3ndq0xqcaED1ioWdaram?=
 =?us-ascii?Q?ny7ZGBq0ferkMMIQo4ecn2ggMCq/5rAMyp+VD4z1SVrM1SC9ixQlWCLF50iB?=
 =?us-ascii?Q?SOTyizq9iW7MoFmblovZxTaGrUZS5lbZVAtyZX1xiwxR3gaJBhA6umnDq1DQ?=
 =?us-ascii?Q?XIKMSitwu7EHqYQ9279icUxOrFBpHP9hYdAD0t4M3eXmFxBObNrqrd50ARCB?=
 =?us-ascii?Q?QSBPesWJWRvoq9xq+ejJNvprb3itWI/58zx+ZxVCDnwyV9Oip2G7WQt2bdxe?=
 =?us-ascii?Q?SmIsyk7tGq+6WfX45JC5kUrJU8PKimbgFAM0/vU/V5mAdAaOLdPmXd2lqs4F?=
 =?us-ascii?Q?PUjPp6q2/eKxkacfo4LAKP7dLA7yU/ngfBm6Ck+icrOBc/AuplobMDKcVmeu?=
 =?us-ascii?Q?RZkAgDktVQoWxW9sDSy06DnxZ+WcRVP7ibcE7+2b+bloGvbDZ959rGe9qqN1?=
 =?us-ascii?Q?/IckDMeHkbX+aXsIjjh0+LJEgAQ342RDB7pI2KrICYXwLoHiCyeIZkHWvqKq?=
 =?us-ascii?Q?R57mWnHW+3MH9lCXxd/1I6iPsiVEl+PWAzDdHGPOXRaJAv+OKz/riYp7r6ic?=
 =?us-ascii?Q?jnmoGksm91r5Uo1ZiDgjlP3ifxNgAmObF8nWiaeV5mMujI1mJoMzKviptj0Z?=
 =?us-ascii?Q?dcF+HY6p38SnyMrmpAS+ZZvM0dgBaKizDfAMlP7wytakrlbXMt9KoBt1K3rZ?=
 =?us-ascii?Q?B2thi3yx3KOzEKtBXkLDsex8UuVvvc8UCRDDRT/F4SNfCWtTrZU8Tu0/S6wO?=
 =?us-ascii?Q?mqneWDgBTtiDuvDoxSJcGVxrLxbGag+G0cM73iezw1DXmNHBreTblCpI9eKz?=
 =?us-ascii?Q?N99Rs00YMsuVlx7eNI82zrb393oa71Zra2HyQgHyMEFeUoY8yuIuy51C8A+u?=
 =?us-ascii?Q?XZJ/b20ubaCHO+p0YpWntxOD4suKL1IA6+PkywCoQIdM8TfAp7o5VHn2Vjrf?=
 =?us-ascii?Q?RvUNiBydQcQTukeTEN7oH/DVJ4JqipZFYm9s+wUiwDs/LYP5NOJ88jsgKHrm?=
 =?us-ascii?Q?BkuQwftGpmgX4mf+IkNY/ddwPjIr2VKVRb22WvY8oLJfEMj0UeNiLBDJv9kj?=
 =?us-ascii?Q?8V5Pp/tMq+BKbdVwZKx51lOTnnn9pZhK72b7T5jESvYO8yEMouPfCkAsMFZ7?=
 =?us-ascii?Q?3iX4IKkLIQzkXqTkFWUGkBVRK/YpPD+Yr7ij2bybH1t7Q0e+bwYSks6rqVR7?=
 =?us-ascii?Q?wU68ceRGumolI4ADBthneZLylhdLJNp1Z1JXRYeSWSY5CcKKO3EXwToRCgHV?=
 =?us-ascii?Q?/EykJZKStw=3D=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 026e821a-cb4d-46c7-45b5-08da172b2c64
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 17:39:02.4022
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OLMCdZgI+xwpcJGufoGGDNzpuI7TUIZIBXPLWCnX+mDR5OkzQTl/IVUwrQHFclamDHqTqjAnZgEpSgEWzV8a9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3226
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 31, 2022 at 11:38:50AM -0500, Carlos Bilbao wrote:

...

>  static noinstr int mce_severity_amd(struct mce *m, struct pt_regs *regs, char **msg, bool is_excp)
>  {
>  	int ret;
> +	char *panic_msg;

Order variable lines from longest to shortest.

And the pointer should be initiliazed to NULL like Mike said also.

>  
>  	/*
>  	 * Default return value: Action required, the error must be handled
> @@ -316,6 +317,7 @@ static noinstr int mce_severity_amd(struct mce *m, struct pt_regs *regs, char **
>  
>  	/* Processor Context Corrupt, no need to fumble too much, die! */
>  	if (m->status & MCI_STATUS_PCC) {
> +		panic_msg = "Processor Context Corrupt";
>  		ret = MCE_PANIC_SEVERITY;
>  		goto amd_severity;
>  	}
> @@ -339,16 +341,21 @@ static noinstr int mce_severity_amd(struct mce *m, struct pt_regs *regs, char **
>  
>  	if (((m->status & MCI_STATUS_OVER) && !mce_flags.overflow_recov)
>  	     || !mce_flags.succor) {
> +		panic_msg = "Uncorrected unrecoverable error";

So these two cases should definitely be separate. One is "Overflowed
uncorrected error without MCA Overflow Recovery", and the other is
"Uncorrected error without MCA Recovery".

>  		ret = MCE_PANIC_SEVERITY;
>  		goto amd_severity;
>  	}
>  
>  	if (error_context(m, regs) == IN_KERNEL) {
> +		panic_msg = "Uncorrected error in kernel context";

This should be "Uncorrected unrecoverable error in kernel context". There is
the IN_KERNEL_RECOV error context for a recoverable error in kernel context.

Thanks,
Yazen