Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp984996pxb; Wed, 6 Apr 2022 06:03:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzRUnZH04MWXfD35ll/Md1rbyl13QtnVx6rET4KCJ40A4YVcXYTzfIZub5XpS2f/b7NcYS7 X-Received: by 2002:a92:6907:0:b0:2bc:4b18:e671 with SMTP id e7-20020a926907000000b002bc4b18e671mr3717662ilc.299.1649250224169; Wed, 06 Apr 2022 06:03:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649250224; cv=none; d=google.com; s=arc-20160816; b=cqFT9YR/jzswkmGrGZ7vaG6TKDuhq4/MKqYlFHX8feAdNdMlarn4Cf+UFtXS4yVoBK JJvaQgcWAAK8+MbiC/mCUu61nvy1i5zr0C4klzX9iLWtos0kTcgGYy0md3pCG2ABjC9Z bMKMhogNFwevByLQpgCr+moaMjluLFOFhrm8en17vp5UO0sByBT/VRj7cxj1++Mg+9bf SDu8zKI8LwKrzLNVsAv9H5RTvoNvdcsILS/whjN7lMxyChL7OzqMo4a+tvt6j1K48RS/ kjGib/2Y8z2ihshlf2mANlyNBVfT/6QLTC670v1fZ/RnX4/XOtUGhHOzGETZvYVp1EOy SlpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DPrUnX4NIhCA+QuZOFd9fdeyF/YLjz4imXZWJ/E5Aow=; b=XoGyZpAEeB++NJe/KDtky9q02Pwp5eEX90S76XEFl/qtbKONQg9Q9uOs2so7NtlrEP XlAlD294ooplMNbJDO0jRNon/vzWMQhTUwNSNNDSwyeVcvx7tg7Tju2U3b4SvwDazrtl /0QzNZ3gsmkrTa3CypIwc/FNz8X6Hk9rQ9eavE0ZDiq9IpDE2ERa/Rmm3T3VUA5AN+id 5gLYiDG6gTTG1MmLLREedpjLXJjE0Bcfymnzxoyx7xF4g6rJRc2tedbZ1hkxKQLH/ZzL 1+3JYPk8GD2BdeclDzTdmJagBeFjjDfsmxHFKQHLJ4OqBg+b6flnQ1o0TCbyA8he4M1q f6cA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=X3mSb92w; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id a17-20020a92c711000000b002ca30fb2b34si5662947ilp.12.2022.04.06.06.03.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 06:03:44 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=X3mSb92w; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3DCF119BFC2; Wed, 6 Apr 2022 03:23:34 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245500AbiDEW5O (ORCPT + 99 others); Tue, 5 Apr 2022 18:57:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354020AbiDEKKs (ORCPT ); Tue, 5 Apr 2022 06:10:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60788C6242; Tue, 5 Apr 2022 02:56:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EE76F6157A; Tue, 5 Apr 2022 09:56:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CC82C385A3; Tue, 5 Apr 2022 09:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649152600; bh=ordbT1ol/NytMCy2eDm57yDhNZz58uR1lbLYcHMG7BA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X3mSb92wBALZ8mhI7WdNxgFLCsMVMOvVP4P9jk2HvNtjU+opCIcRW6qDQBhX8qCz9 BZc//NH1pfoNa1cAbI0MtVTLyviqpghN6iel/K68gf5734NpZg9BGCb5/bz7eHgcxn aklI1NGSg+ES2rbIM0BPDSgj4R/JnZEnCpKqKDY4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Masahiro Yamada , Mark Brown , Nick Desaulniers Subject: [PATCH 5.15 836/913] modpost: restore the warning message for missing symbol versions Date: Tue, 5 Apr 2022 09:31:38 +0200 Message-Id: <20220405070404.888997988@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070339.801210740@linuxfoundation.org> References: <20220405070339.801210740@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Masahiro Yamada commit bf5c0c2231bcab677e5cdfb7f73e6c79f6d8c2d4 upstream. This log message was accidentally chopped off. I was wondering why this happened, but checking the ML log, Mark precisely followed my suggestion [1]. I just used "..." because I was too lazy to type the sentence fully. Sorry for the confusion. [1]: https://lore.kernel.org/all/CAK7LNAR6bXXk9-ZzZYpTqzFqdYbQsZHmiWspu27rtsFxvfRuVA@mail.gmail.com/ Fixes: 4a6795933a89 ("kbuild: modpost: Explicitly warn about unprototyped symbols") Signed-off-by: Masahiro Yamada Acked-by: Mark Brown Reviewed-by: Nick Desaulniers Signed-off-by: Greg Kroah-Hartman --- scripts/mod/modpost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -669,7 +669,7 @@ static void handle_modversion(const stru unsigned int crc; if (sym->st_shndx == SHN_UNDEF) { - warn("EXPORT symbol \"%s\" [%s%s] version ...\n" + warn("EXPORT symbol \"%s\" [%s%s] version generation failed, symbol will not be versioned.\n" "Is \"%s\" prototyped in ?\n", symname, mod->name, mod->is_vmlinux ? "" : ".ko", symname);