Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp993889pxb; Wed, 6 Apr 2022 06:15:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzStF6j0WioRWx8jPEPaGYa5gJ0HdV/QE+UErQeCYpK9bqBQ65y43lSE82Qc0KIPK5BQgzg X-Received: by 2002:a17:902:e543:b0:156:c93c:6a13 with SMTP id n3-20020a170902e54300b00156c93c6a13mr8768268plf.60.1649250911322; Wed, 06 Apr 2022 06:15:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649250911; cv=none; d=google.com; s=arc-20160816; b=iNJcD8yhrIN3BZWRgl8Ob2yeko5Q04xY0SOzciFfv2597g6jsQBbnfN52A39R/mNvO AorBKErCq126CWG9gUxfJwPjrdt/U9j61Rcw9JPKBQBOPBWVqGnet69BLqOvmrz9eQJr UilgBu30KX6yxO+ZlIUKcuaocZfMczhy4D8pfEqM7MqG36tIn5NZkGM09NCegYTu5RC5 gTnjLvn65LhzQwbFJFdhedDvGeNY/CXcdOb8pCvL4TxE/a+1DpOVBt0HTVuvxPHwMxis zCEWtzLvKs8bV5LC7TKWyvOyKN7XWGxcKPp+AtZbMu0rK7Zxb6A5HrfaZn9ZTe7jfzTr el/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=nbEMiEpi+4rATZaEBTzSH6W5FqcisHVNyEzEz9jAd6g=; b=OZVrYb/ksRgiyJEC9ymvOjmO8Y3YCQ4X0G5aJkTlctDmmaGBL5avE1zSo+WwxctUTM unIPfce+zUonA+8HF4alfeu/TNuCy14NmV/mQL2jynlONbuy5VKjKFXrYiFNIYZFreJg YQCH7EBlcMIQ6xI13Y1r6UAF8WQa13/tLWg6Iv1GTtTZUmiCUS/GjL9+keo4il1Mr7dP BI+bzxyqRejvOqFhEzLbFXJIGaN7E/JpXXWhOIqg6E4CubMotzPvC1ZoSxgb4CLBVVXR 3QvwK1fhUYheuQd1MLA6IWhX+l/PNxdxqedUNasGhkn0E5tMPFqTKxB6pR7A6GR+R5/0 prQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tdMfxVS0; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id oa13-20020a17090b1bcd00b001c5f4e39398si756496pjb.127.2022.04.06.06.15.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 06:15:11 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tdMfxVS0; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 079664FD691; Wed, 6 Apr 2022 03:43:45 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1450073AbiDEUKb (ORCPT + 99 others); Tue, 5 Apr 2022 16:10:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358108AbiDEK17 (ORCPT ); Tue, 5 Apr 2022 06:27:59 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D5277007C; Tue, 5 Apr 2022 03:15:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3C77AB81C8A; Tue, 5 Apr 2022 10:15:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BBD4C385A0; Tue, 5 Apr 2022 10:15:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649153739; bh=GRVYjGN0oVU3bLQLZkS30dh2b8ueNqwEcosPDjmYZFA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tdMfxVS0mYZ0ne+mJs5kAKZRsVCTt9rmXccX8GdQLbMZhWvzuiMrmdYp9csCbKbWF rqCXZz31ZMu0q6j8PbbZ5b5ZsdibfkdLbmkBT+q1Udns1TFcBP+wIgfIS8rnG6Lw59 RNovPksRB3rSJrhQYfWhJl0hn2aAod3I1APNmRZw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Linus Walleij , Sebastian Reichel , Sasha Levin Subject: [PATCH 5.10 282/599] power: reset: gemini-poweroff: Fix IRQ check in gemini_poweroff_probe Date: Tue, 5 Apr 2022 09:29:36 +0200 Message-Id: <20220405070307.227685516@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070258.802373272@linuxfoundation.org> References: <20220405070258.802373272@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit ba18dad0fb880cd29aa97b6b75560ef14d1061ba ] platform_get_irq() returns negative error number instead 0 on failure. And the doc of platform_get_irq() provides a usage example: int irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; Fix the check of return value to catch errors correctly. Fixes: f7a388d6cd1c ("power: reset: Add a driver for the Gemini poweroff") Signed-off-by: Miaoqian Lin Reviewed-by: Linus Walleij Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/reset/gemini-poweroff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/reset/gemini-poweroff.c b/drivers/power/reset/gemini-poweroff.c index 90e35c07240a..b7f7a8225f22 100644 --- a/drivers/power/reset/gemini-poweroff.c +++ b/drivers/power/reset/gemini-poweroff.c @@ -107,8 +107,8 @@ static int gemini_poweroff_probe(struct platform_device *pdev) return PTR_ERR(gpw->base); irq = platform_get_irq(pdev, 0); - if (!irq) - return -EINVAL; + if (irq < 0) + return irq; gpw->dev = dev; -- 2.34.1