Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <efbe06a7-3624-2a5a-c1c4-be86f63951e3@redhat.com>
Date:   Tue, 5 Apr 2022 17:48:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [RFC PATCH v5 101/104] KVM: TDX: Silently ignore INIT/SIPI
Content-Language: en-US
To:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     isaku.yamahata@gmail.com, Jim Mattson <jmattson@google.com>,
        erdemaktas@google.com, Connor Kuehl <ckuehl@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Tom Lendacky <thomas.lendacky@amd.com>
References: <cover.1646422845.git.isaku.yamahata@intel.com>
 <d0eb8fa53e782a244397168df856f9f904e4d1cd.1646422845.git.isaku.yamahata@intel.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <d0eb8fa53e782a244397168df856f9f904e4d1cd.1646422845.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/4/22 20:49, isaku.yamahata@intel.com wrote:
> +		if (kvm_init_sipi_unsupported(vcpu->kvm))
> +			/*
> +			 * TDX doesn't support INIT.  Ignore INIT event.  In the
> +			 * case of SIPI, the callback of
> +			 * vcpu_deliver_sipi_vector ignores it.
> +			 */
>   			vcpu->arch.mp_state = KVM_MP_STATE_RUNNABLE;
> -		else
> -			vcpu->arch.mp_state = KVM_MP_STATE_INIT_RECEIVED;
> +		else {
> +			kvm_vcpu_reset(vcpu, true);
> +			if (kvm_vcpu_is_bsp(apic->vcpu))
> +				vcpu->arch.mp_state = KVM_MP_STATE_RUNNABLE;
> +			else
> +				vcpu->arch.mp_state = KVM_MP_STATE_INIT_RECEIVED;
> +		}

Should you check vcpu->arch.guest_state_protected instead of 
special-casing TDX?  KVM_APIC_INIT is not valid for SEV-ES either, if I 
remember correctly.

Paolo