Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 05 Apr 2022 18:16:17 +0200
Message-ID: <s5hilrn5wvi.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Borislav Petkov <bp@alien8.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org
Subject: Re: [PATCH 02/11] ALSA: usb-audio: Fix undefined behavior due to shift overflowing the constant
In-Reply-To: <Ykxo+0p5IeeM7mge@zn.tnic>
References: <20220405151517.29753-1-bp@alien8.de>
        <20220405151517.29753-3-bp@alien8.de>
        <s5hwng35yvz.wl-tiwai@suse.de>
        <Ykxo+0p5IeeM7mge@zn.tnic>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 05 Apr 2022 18:06:19 +0200,
Borislav Petkov wrote:
> 
> On Tue, Apr 05, 2022 at 05:32:48PM +0200, Takashi Iwai wrote:
> > > +#define USB_ID(vendor, product) ((((unsigned int)vendor) << 16) | (product))
> > 
> > Parentheses are needed around vendor (as usual for a macro).
> > Could you resubmit with it?
> 
> Or you can fix it up while applying. :)

If you prefer, sure.


Takashi