Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <70962fc4-1624-2fd8-4d8d-f1a31001e165@intel.com>
Date:   Tue, 5 Apr 2022 11:59:58 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.7.0
Subject: Re: [PATCH V3 17/30] x86/sgx: Support modifying SGX page type
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>
CC:     <dave.hansen@linux.intel.com>, <tglx@linutronix.de>,
        <bp@alien8.de>, <luto@kernel.org>, <mingo@redhat.com>,
        <linux-sgx@vger.kernel.org>, <x86@kernel.org>, <seanjc@google.com>,
        <kai.huang@intel.com>, <cathy.zhang@intel.com>,
        <cedric.xing@intel.com>, <haitao.huang@intel.com>,
        <mark.shanahan@intel.com>, <hpa@zytor.com>,
        <linux-kernel@vger.kernel.org>
References: <cover.1648847675.git.reinette.chatre@intel.com>
 <bac6e77fe04100d6bfebd4e13aa9b916f82bfea6.1648847675.git.reinette.chatre@intel.com>
 <Ykvqf3Ws6jlN5g+p@kernel.org>
 <b41d81ebcb6934765d7f37d4ce95baa16ec9b5d2.camel@kernel.org>
 <d8cc2142-c50d-fbd9-425f-01e279c9a0f1@intel.com>
 <94f62e19a630792f78e3c48895dfb792ecb02c6c.camel@kernel.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <94f62e19a630792f78e3c48895dfb792ecb02c6c.camel@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SCthbkgyaEw2azMvZkZ4ZHJmT3d5UVBUOXB2L0JmaHZwSksrVmluQWsxQXpI?=
 =?utf-8?B?VkVGVEVaRnRIVnFkZVc0SmJlQUpEM0kzbWluaVowSnFNQjlHeENVSHJ3cE01?=
 =?utf-8?B?dzhucCt4bFc4VmVWK1orMmtPd056WDM0L1h6cXpoWUVHMmRHUjRnd05NZ1RX?=
 =?utf-8?B?ZXRKRk1TajVjaTBmYTA4ait6bC9wSVFoZGx5R2xaMENLaXRmTWtLL3JQZ2dv?=
 =?utf-8?B?OHIwZ3U1Q2hOOTFobUtUZWNhZG9JYUlidU9IN20vVTRZNmJ3WjhDTW1VLzk0?=
 =?utf-8?B?V01ZeitNdUs2TEh1RXlBMS93OWZFU2Q3WldidGw0TFk5a0JZM2FrYWJSYVNy?=
 =?utf-8?B?NjJNWWsvSElBdDY2Sm9mVEZZL2pIUDJSNXJick5lblplQWJ0RkdBUS9PamRr?=
 =?utf-8?B?ZVRBcENTaUNkRmo3UEJUTlc1OUV6bFRLN3B5NlB3TXduMlBwa1BaSnk1bzJu?=
 =?utf-8?B?WXA3QUdGTm8xbDJ2Yit5QjEvdmFTUk5JMWVUY1pob0lzSEhkaDlaZFpaLzIy?=
 =?utf-8?B?RWVEeGZDUE14Z3VsYzBibVd0cVlYNWZReU9aZU9sc3daOUFsS3p0UDZ6akwr?=
 =?utf-8?B?dlQ0cS9kZ3ErY1c4L2g2ZlVLaE9xOTJQYlZKT0QxOGh0My8vVzlEQWZyNXJR?=
 =?utf-8?B?L0ZOTVYvSzVxQUJBNnkzMDBjTXJoekJJRFNCSGZXOWkxMVNWTHFLMllwdnhQ?=
 =?utf-8?B?cFVSUG1FOFZyc1F2T1doa0hQNEhaNllVUHpmZU9FQUdCNENZS2RTd3N2WmF0?=
 =?utf-8?B?NTZMbkk3ODE5ckE2enJQQ3hnNmppUmwvaTUvQ3ZLQXdNakRLTHNzeWJYQit6?=
 =?utf-8?B?YjVIais4OUJPUUFrVTl1cFU1cDNnZWdJbUJ5K29rbDd2cEEzQ01IWnQ3MzFM?=
 =?utf-8?B?U1p5ekErSXphTmp5VFpxcmFDakJ5cDN1cEFEZ0xYcmdqL2ptU0RIaFViOWNM?=
 =?utf-8?B?UWVPaHhXRHg1TDFjWWJaSzlsUmVwc3JyRzRTbEZFSUlvRlJiMHRudWxVbFdz?=
 =?utf-8?B?OFBNckE5NHFBWWN1bUxPL2lkWEo0UnNSQm4yZlJLeHd4YmxzbFE3Vkt3aEZ2?=
 =?utf-8?B?cFY1dzhvSklBZTZHVjVzNWRpMnNobGpLMStXSVNZbi9SQ0dTZGRpOUU4Y1BK?=
 =?utf-8?B?azJiZUFtRVFnd1dxVU4reUlpcmhlOStPNjhVQ0crZ2lwNDdjbmdWTW44WGtM?=
 =?utf-8?B?UWFGLzM2dHpsQVEzWlFNNVpJcjRBOTZzNXV1Sld1aWtFaDZ1NXF2K3Q0aTdX?=
 =?utf-8?B?bmNhaHhEcHkwUlJpVmdudUZzTkFDSzJhOHBQNFZqaTdDU240c1BOUzNqRnB6?=
 =?utf-8?B?L0ZTQlVxQUI5VmlHeHVDYUlUWUh6Vy9wV05qby9TMitnWkt6Q010U3ZHeWNy?=
 =?utf-8?B?ZFYxU0k4UnJXa3VTbXZuLys3N1RIMHFselpYdE01cWJqQTJhOFhuekdLVm8z?=
 =?utf-8?B?UFBMYVJuSWgwcTVjK1dabEJVV2diTmNEaytRdnc2YlhYcTZKVnorcUtabHFY?=
 =?utf-8?B?aW42M2duZHBZeUYrYVF4MW1ncmVxQkpMd2RTOFNEWHQrL0ZVSW9sMHQ3UGNB?=
 =?utf-8?B?K1BaWmZJd3VWNzE2ZG5TR0JYUE9BK2p6d1Q3NTA3ejZQelpNUThVaDNXL0VP?=
 =?utf-8?B?VkE3ejBOUGdkdUF2SFlFUFFmMXg2Q0RudFRIMmZYQ2kvZU5YcGg1eG1mTjU2?=
 =?utf-8?B?YUVZek9qVG9YelpjcVZxWDV2ZEdKTU04M0JzVnpwTVBqejlRdzFDVTQ4V1lm?=
 =?utf-8?B?Wjcybi90VHFyZkprYWl5aXRpMFhWTVVSbTNOZy91NHZCSk53dEcrMldCVjlv?=
 =?utf-8?B?NGYvemJzdllUdjVhQTVkZkdIMmdYVFoyd1pHZjJsejQ2YWxlL1ZqZmFHZDVu?=
 =?utf-8?B?V25Fd242cWRqL2lVblVYbUtDZTBBRGdremxPNFBRbVVydUtDdm85Y2QyeDRW?=
 =?utf-8?B?WWtCT3JFUkltZ3UzNHZoVnRBYUdDdXN6b05HWUhJUnhtR1dNbkgzUCthRmFS?=
 =?utf-8?B?Z2VnV1AzWm9Wc0wxcVhsTXpENk81RzBnMjFxY1N1WC9uZzVxT3lhNXFRUmV6?=
 =?utf-8?B?QWFLekxpajFxUDZkY3JDOGdDR1N4L2c4Y0ZsOUVuc2k2RDF5aGowYUM1TDRh?=
 =?utf-8?B?Zjh1eERMazJzMkc1ZW5CRGR1ZFRJeFhxazNXaEV1Z24zamVDT0gvQzNiUEE1?=
 =?utf-8?B?eG5ObjlENjR2TlRYeCtIb0ZBNEduWmttOTRkM3k4ankxZ1YvbSt1d3RSRUs4?=
 =?utf-8?B?aFJzVlBFcGlDZE84R3NHMkJFU1ZEWTBNUyt5V3ZTdCs1K05FS1k3ZzlYT0pv?=
 =?utf-8?B?OHVrVW8vRlVMTGtlZVd6SkxRbkduMWRaNEpMeDQwc2FQdGhYSlZISFFOWTJL?=
 =?utf-8?Q?tXb/rIAKRxJvAnwo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: de564746-f7b9-438a-3e99-08da17367d02
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 19:00:02.1505
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: //Qg4jt7H7M71NeXr7ctP8NMxvA1hukS436iTxO4GUWDuwrV68n0ENgkhR8/VVkTJ9LPlaaFy+9+t70NDgNcMUJFWJJbMogrtZkP/RfpjoY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4751
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 4/5/2022 11:41 AM, Jarkko Sakkinen wrote:
> On Tue, 2022-04-05 at 10:05 -0700, Reinette Chatre wrote:
>> Hi Jarkko,
>>
>> On 4/5/2022 8:34 AM, Jarkko Sakkinen wrote:
>>> On Tue, 2022-04-05 at 10:06 +0300, Jarkko Sakkinen wrote:
>>
>>>>>
>>>>
>>>> To be coherent with other names, this should be
>>>> SGX_IOC_ENCLAVE_MODIFY_TYPES.
>>
>> This is not such a clear change request to me:
>>
>> SGX_IOC_ENCLAVE_ADD_PAGES - add multiple pages
>> SGX_IOC_ENCLAVE_RESTRICT_PERMISSIONS - restrict multiple permissions
>> SGX_IOC_ENCLAVE_REMOVE_PAGES - remove multiple pages
>> SGX_IOC_ENCLAVE_MODIFY_TYPE - set a single type
>>
>> Perhaps it should rather be SGX_IOC_ENCLAVE_SET_TYPE to indicate that
>> there is a single target type as opposed to the possibility
>> of multiple source types (TCS and regular pages can be trimmed).
>>
>>>

What is your opinion about what the ioctl() name should be? I prefer
to obtain a confirmation from you since you originally [1] requested
SGX_IOC_ENCLAVE_MODIFY_TYPE.

>>> This should take only page type given that flags are zeroed:
>>>
>>> EPCM(DS:RCX).R := 0;
>>> EPCM(DS:RCX).W := 0;
>>> EPCM(DS:RCX).X := 0; 
>>>
>>
>> ok, this was how it was done in V1 [1] and I can go back to that.
> 
> I would name the fields as "flags" and "page_type" just to align
> names with SGX instead of trying to mimim "posix names". Otherwise, 
> I support that.

I will move this ioctl() to use "page_type" instead of "secinfo"
within struct sgx_enclave_modify_type.

Your guidance of "flags" is not clear to me. I assume that you
refer to the field for struct sgx_enclave_restrict_permissions
where I think "permissions" to only contain the new permissions
would be more appropriate. None of the other values in
secinfo.flags are relevant.

Reinette

[1] https://lore.kernel.org/linux-sgx/Yav9g4+L8zg48DRf@iki.fi/