Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1006821pxb; Wed, 6 Apr 2022 06:33:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpPKvQCfpp+/V9wl437qhl79lkd9KqnKZ7jF1TmdhxNYX5K67t7T0PfLo27m+eLkwdqbvx X-Received: by 2002:a65:418b:0:b0:382:250b:4dda with SMTP id a11-20020a65418b000000b00382250b4ddamr7363321pgq.428.1649252038443; Wed, 06 Apr 2022 06:33:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649252038; cv=none; d=google.com; s=arc-20160816; b=kEBm2eeVHGgMnG+5e1HWCEJJaK78xHxxduUOGDYCI5qvHY1B4TteCiH9t7XzqSEu8z 5PxxNoET8ka7bb6GCSt2czlH51GWiudWyaY6u0KrakRJRl9CB1G4VjQcqSK6Cr+qAZsa 97iyG1lWm04A/lvCSccFNjmp01z9y3EmAPkOBZqRHj/L+bi4ax80SD87DGJkvhCH7ept iKubHzZDqF0fJM8UUeGNVFTHIWjn0awaH5uQW1nSxZjEwMrOffF/PcmTBM8HoqcqTJy7 o2HSgxs0Q9jVgLVJfN33jkAd8e4HIKWD8lb2UUoLo45bujvJ5vjxmdv85J+cT8TSD2T5 vaMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HaMju4MJGPuJEuWy3Js9i7yx8ZeGbHQ/L9UkDEaNBiM=; b=NYINmGWnEi+5nu1XRdaxJiBju7Ciwr9jVMXBw/rmhoRkoBF2raUEDKyrlZ401GAL1q PcWmDZeHQQ2lorhWg0VAhdsZLsmyKGmRK7OZNwJi+sGksOR8SBbAeLIK24VXcJUicSGJ KymropW6gonSujsf/SqTGC54Rt79g/fxCY+NEtXhjnPegEGzZYi/UzaMMtloUW5BwkVB Bo0lcy3fG7o1yi8lBJ3VOewrHpjdadnaDGKMj6m2mRYQdkkGubWddqGyClTDT0fYsWJX ywOLw3pb2fvjODWph3n3VlxHzmmPUAUx+xiLeSAlkszARSGxX/YhKsi0hTVqlQ5QL95v mceQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Z7djd2FV; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id y5-20020a056a00180500b004e1a25384f6si17216109pfa.3.2022.04.06.06.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 06:33:58 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Z7djd2FV; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1509253A797; Wed, 6 Apr 2022 04:13:34 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1840891AbiDFBNn (ORCPT + 99 others); Tue, 5 Apr 2022 21:13:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349077AbiDEJtE (ORCPT ); Tue, 5 Apr 2022 05:49:04 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A575AA9940; Tue, 5 Apr 2022 02:40:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 535C6B818F3; Tue, 5 Apr 2022 09:40:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BBC3C385A1; Tue, 5 Apr 2022 09:40:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649151604; bh=jf/0EApObABORwS/DhG/9UsbVEQxtDbTazbrKwfT8wI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z7djd2FVzQ6M0GVtSFpu0P1KVwIDQdQ92SZIFFzWd2KDbGlyPZ/XkYQVqXRHlEtyf v/UGbxtUgz98nmBfsDsyWpSdE00cfRM+HqgODEQ2SDngbDCS4RukBOQgN/LHkPZF7i B3x3DNKIVTBPgOkD0Sh3nYrDzEmTlMALGW38Z0Ls= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Abhinav Kumar , Bjorn Andersson , Stephen Boyd , Dmitry Baryshkov , Sasha Levin Subject: [PATCH 5.15 475/913] drm/msm/dpu: fix dp audio condition Date: Tue, 5 Apr 2022 09:25:37 +0200 Message-Id: <20220405070354.093780241@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070339.801210740@linuxfoundation.org> References: <20220405070339.801210740@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dmitry Baryshkov [ Upstream commit 1e0505a5a7a2fea243f8e6d7e13fcde65f9e41bc ] DP audio enablement code which is comparing intf_type, DRM_MODE_ENCODER_TMDS (= 2) with DRM_MODE_CONNECTOR_DisplayPort (= 10). Which would never succeed. Fix it to check for DRM_MODE_ENCODER_TMDS. Fixes: d13e36d7d222 ("drm/msm/dp: add audio support for Display Port on MSM") Reviewed-by: Abhinav Kumar Reviewed-by: Bjorn Andersson Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov Link: https://lore.kernel.org/r/20220217035358.465904-2-dmitry.baryshkov@linaro.org Signed-off-by: Dmitry Baryshkov Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 0e9d3fa1544b..6bde3e234ec8 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -1107,7 +1107,7 @@ static void _dpu_encoder_virt_enable_helper(struct drm_encoder *drm_enc) } - if (dpu_enc->disp_info.intf_type == DRM_MODE_CONNECTOR_DisplayPort && + if (dpu_enc->disp_info.intf_type == DRM_MODE_ENCODER_TMDS && dpu_enc->cur_master->hw_mdptop && dpu_enc->cur_master->hw_mdptop->ops.intf_audio_select) dpu_enc->cur_master->hw_mdptop->ops.intf_audio_select( -- 2.34.1