Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1008825pxb; Wed, 6 Apr 2022 06:36:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHub2xpFNWKkkAK61/K4GghREIFuZx4dn9B+4F5i7k8N8gtaUEDbiM0hGtYlryNMhJJ21H X-Received: by 2002:a17:90b:4a06:b0:1c7:2020:b5b9 with SMTP id kk6-20020a17090b4a0600b001c72020b5b9mr9943806pjb.58.1649252200684; Wed, 06 Apr 2022 06:36:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649252200; cv=none; d=google.com; s=arc-20160816; b=W+yR5aD91Zv5pp+UQ1b1ab2C8465xxQEG7lh6Rcs3sWejmjmpVE3wqXNFHQhuvd0uL MXvY5ekO4c0vLeAmRUFPXi/xOJxOW7gqg60ZTozNviY9tzGV38/h/oryHEkow2rRFL0V ae5gUUYYbJFKtxW4LjmGVz+6hi1jNT/6QukmAtY2YlSn91t4hEMa7wGy5d96JAwkxDur uq0BPmDFWcdW72b1GaqFGWuMlNs8/zQyzVbwGvCndRf4D8x8tDSstLuYSIsHLPbCHlJL iVFyWwlfcmO+hsbphu+mB4pnVuc/vx6ICU2kf0nxRV9kuphbTNQ/2c2g5vtScjWZ+2B0 QTZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=b2/yKAnkerkqyi0zgsuEh1LAKeXaQZ6qRmMxgcrXEkc=; b=qZT2+g20JcOcHm7EwSX1oh4/fxYmNVdUY/7t6aUtGvOz19CK/hmHMibVC9u6ktYYE3 f//lNR8ohA188sRLw0Hj+LH4JJOVGz3aYCAWKR1+Zm39r790ZW5TVJZrd19EipiCdCbP +A8LqRi2TAxn1vwfKuitnDOfA4XoNNjkPH9qMuC+K3uTON5ZQcigvP8JRm8Kb4njg+mj G+S/vDEZaVX4f8wUahR/YhOeWV7Kz6UOXdS7HfBdoWxrPCsjBS7+bl0tIZEWhChZ2ueu 8F/XnfXuRTAgG5uiq39hVRmDZVvf34WUgUtqoJZJlIbLvMQCDKPPXUp7PUk4djlwZEDc NtoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0kNxkY9Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id y3-20020a056a00180300b004fa3a8dff53si17515756pfa.10.2022.04.06.06.36.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 06:36:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0kNxkY9Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 864C25497E2; Wed, 6 Apr 2022 04:20:17 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1846360AbiDFCEA (ORCPT + 99 others); Tue, 5 Apr 2022 22:04:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349138AbiDEJtM (ORCPT ); Tue, 5 Apr 2022 05:49:12 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28EFD12C; Tue, 5 Apr 2022 02:41:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C848CB81B14; Tue, 5 Apr 2022 09:41:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3471BC385A3; Tue, 5 Apr 2022 09:41:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649151681; bh=P9cAgoMeroWf2nVM2LaYjb9TMKAdQKYO1vUZvOl9bT4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0kNxkY9Qgzu8gltdfTD9gefy7QHYnNw0FcYP6P1epUCkQ68UIDdmTuWf+aEjRxqrI HOORAlvclLYNLgmv0UYU+xCheoTM2RlthZkMBSwAgXClMNqDLqMwWzg3+YbU9mhQqv YE6iArVZVgkj6mx0ROuQ/gv3zBRVolvbRJv2lnoE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mustafa Ismail , Shiraz Saleem , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.15 504/913] RDMA/irdma: Remove incorrect masking of PD Date: Tue, 5 Apr 2022 09:26:06 +0200 Message-Id: <20220405070354.964596858@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070339.801210740@linuxfoundation.org> References: <20220405070339.801210740@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mustafa Ismail [ Upstream commit 17850f2b0b4b806e47cc44df94186bfc2cdd490b ] The PD id is masked with 0x7fff, while PD can be 18 bits for GEN2 HW. Remove the masking as it should not be needed and can cause incorrect PD id to be used. Fixes: b48c24c2d710 ("RDMA/irdma: Implement device supported verb APIs") Link: https://lore.kernel.org/r/20220225163211.127-4-shiraz.saleem@intel.com Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/irdma/verbs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c index 8bbc4620a97a..4a6fdd5c09e3 100644 --- a/drivers/infiniband/hw/irdma/verbs.c +++ b/drivers/infiniband/hw/irdma/verbs.c @@ -2506,7 +2506,7 @@ static int irdma_dealloc_mw(struct ib_mw *ibmw) cqp_info = &cqp_request->info; info = &cqp_info->in.u.dealloc_stag.info; memset(info, 0, sizeof(*info)); - info->pd_id = iwpd->sc_pd.pd_id & 0x00007fff; + info->pd_id = iwpd->sc_pd.pd_id; info->stag_idx = ibmw->rkey >> IRDMA_CQPSQ_STAG_IDX_S; info->mr = false; cqp_info->cqp_cmd = IRDMA_OP_DEALLOC_STAG; @@ -3018,7 +3018,7 @@ static int irdma_dereg_mr(struct ib_mr *ib_mr, struct ib_udata *udata) cqp_info = &cqp_request->info; info = &cqp_info->in.u.dealloc_stag.info; memset(info, 0, sizeof(*info)); - info->pd_id = iwpd->sc_pd.pd_id & 0x00007fff; + info->pd_id = iwpd->sc_pd.pd_id; info->stag_idx = ib_mr->rkey >> IRDMA_CQPSQ_STAG_IDX_S; info->mr = true; if (iwpbl->pbl_allocated) -- 2.34.1