Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 5 Apr 2022 17:41:25 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Carlos Bilbao <carlos.bilbao@amd.com>
Cc:     bp@alien8.de, tglx@linutronix.de, mingo@redhat.com,
        dave.hansen@linux.intel.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
        bilbao@vt.edu
Subject: Re: [PATCH v2 1/2] x86/mce: Extend AMD severity grading function
 with new types of errors
Message-ID: <Ykx/RYZpKi5SQ/NN@yaz-ubuntu>
References: <20220331163849.6850-1-carlos.bilbao@amd.com>
 <20220331163849.6850-2-carlos.bilbao@amd.com>
 <Ykx59WvoWKi2y23x@yaz-ubuntu>
 <ec7dc7e7-5808-58f8-cbe9-d8fdd2de4c35@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ec7dc7e7-5808-58f8-cbe9-d8fdd2de4c35@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wp8R3/I+P/r8ymHkilP0dMKkPlXCh4FUIVLwVRFLS9yzzKzLXyWSYoxa/dun?=
 =?us-ascii?Q?xNC7OvrbOb7rEPWLjpfauQQ19A9BMv703CH04LcyGt7aehfTjf4qREKiu166?=
 =?us-ascii?Q?lj1IWnU6zft+yZ6pKYTGBlRoqQkQhNR7kPQ3busyHAie3+LSImhvdAd57S6n?=
 =?us-ascii?Q?TNvOUktt7iV8vs8JJUu1MtbXb025RJAuVTGfYw1X9XU4nAU2scce4zwqMMTE?=
 =?us-ascii?Q?p9s02TOPfA0eipUt1mcbQ1uKjjhdqLo3j0hydP+p7uIiddB8CI0H1ZBXdtcD?=
 =?us-ascii?Q?HFX2JUmR4AyRPM3qzfEYzwhwwqK2nP2Tl9YewZ/ABLvHJwnHN0gj8Rb3Y06a?=
 =?us-ascii?Q?4ZBPhsqxmBvCYb6NI1MjtdUkyaeaf2Hd32w4asEhRhPyj8e0pAfC7EbsVDbb?=
 =?us-ascii?Q?Cb2+guRqOaMHMxR30noz7jNRwWTq+A83FhzWcE+KTPhbRwOUpcPXvqK29adE?=
 =?us-ascii?Q?32191C60+aebLxMlRUn19m1EDXJi4NQW899jzP0b8IBqkhGPQ+yThRPb3YIw?=
 =?us-ascii?Q?6oi4qJHGqqzdaxZ43whv9z1+ZGEwnhBQ5U1pA8T2Yx3C/ltTDxdTYYfaboTU?=
 =?us-ascii?Q?GqOD4xBjQoIqslf9yYSA/7xdMDk4/6r+riGNr3XDHKhfnP6WefE1AwH+ElVl?=
 =?us-ascii?Q?cxMglIfGxUE5+cF69EA2kGT9gmua1aZtCwjxOzEbayAErLN6zLemXJY9jF3h?=
 =?us-ascii?Q?TY8lRcseNs40LUyf3PsvWEP1hdcEqilXALIcMvpKAMMJGhS8EF7eNsqDRnSm?=
 =?us-ascii?Q?ticeowW6yHE5PvZ3nofY4GttrDFodMCJt6ggkMbcifZ3b2Bj9Hl3xl5pwmEo?=
 =?us-ascii?Q?s+MKsFDvBv/cJHJiT3br4aXxVfdmNNwZOlao21U8e1YfbHJttv3GmHUU/MmI?=
 =?us-ascii?Q?rHWmmSX6mNXcYW8pobuAIaZdItdYMD9GVfnEWkLNtBT4Kejtrp24A3adykcv?=
 =?us-ascii?Q?OqCYSniVX1jT/QpxCbVKincBIYIlRZOTC3mj6yp5gNuOXM57gUasxsmWAW7I?=
 =?us-ascii?Q?dn7Us5VXc6PIKyERMfOkCre9s6mFIZsJNQysRcXLRbiLv+XQ5/28h+YPIKQu?=
 =?us-ascii?Q?7/Bmk+I00ykh3tlQP0O/OJGUvAEKtw4tzZiLt9v8pd8Msyw/ZbNP9WNpLiVk?=
 =?us-ascii?Q?3Q/hn2B7fDmyy+rOx9WRzN9NfznxLViixVwaX7tPu/dkPUP97Y9sF6Z3570d?=
 =?us-ascii?Q?r8oulUz85crCKIOgC9ujlm5+hsHY7FfeA7eYoe53YqdAvuV3b+hbypXv0D8G?=
 =?us-ascii?Q?uYRGxnttLCHc7z01QRgOa/3+3oXR6SaWwRqIPUQi2kcGv17b7sG2fehVhC2G?=
 =?us-ascii?Q?4LCp4qVb9MUOPROFYwXZG+i0LHIGPO8XIMTZ5ylXv+S4vW+QtxPfbWnCkHXR?=
 =?us-ascii?Q?yjSU4ZHJowB+o82OuayX9r0d6Avb3FbWhp5AH8P3mAIFz8D81MZpi2K+zSI6?=
 =?us-ascii?Q?KlNOOonpV/iXee+dxygU+EAfYWkFRosFkJpxTfJ22M48McFACchfOkA4LPxE?=
 =?us-ascii?Q?MctvJlz0s5AkIGGtpCI+qecQ/m4gow+sv3s3viiT29GNV7rQ2uDupnWyM/xl?=
 =?us-ascii?Q?8ftEAyIUPWKKwbJPuXXci+D6h8cSjH61WFg0UbVGcOvkAg9sNCV96kWeXb+5?=
 =?us-ascii?Q?oMCJJB2br/AUhWWTXQEbV0kJAT4gcuHN/WsJmvK5zLX41WEj3O2KPG28zjxB?=
 =?us-ascii?Q?ZoMD1i1DTtZzdUYGsSX2OIRWUj+By1YdQjG8inNZXnyHlxVRXIXVvM67Ls+S?=
 =?us-ascii?Q?9DXwQDkb8A=3D=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12fb42e3-6d10-4781-7533-08da172b83d8
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 17:41:29.0473
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V1K7wbHUquIhfHAaLhaCLxnvfiHufGoLDgdiuTrjfQEy1ZYgeKIncsQ/ujAKLR5QdlY+LGY/2jgCfjjuf9K8Gg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4252
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 05, 2022 at 12:24:31PM -0500, Carlos Bilbao wrote:
> On 4/5/2022 12:18 PM, Yazen Ghannam wrote:
> > On Thu, Mar 31, 2022 at 11:38:49AM -0500, Carlos Bilbao wrote:
> >> The MCE handler needs to understand the severity of the machine errors to
> >> act accordingly. In the case of AMD, very few errors are covered in the
> >> grading logic.
> >>
> >> Extend the MCEs severity grading of AMD to cover new types of machine
> >> errors.
> >>
> > 
> > This patch does not add new types of machine errors. Please update the commit
> > message (and cover letter) to be consistent with changes made between patch
> > revisions.
> >  
> 
> I'm thinking "cover error cases not previously considered".
>

Please elaborate. It seems that all the cases in this patch are already
covered in the existing code. This patch seems to simplify the existing code.

Thanks,
Yazen