Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1013494pxb; Wed, 6 Apr 2022 06:43:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGHMfGj8EbEfW6FOiwk4TQXPZp883tZ13vF7uaBnYZA1FCj/fXvI76flmM4QH+2BtAKHUj X-Received: by 2002:a17:903:32c4:b0:156:8fd2:4aae with SMTP id i4-20020a17090332c400b001568fd24aaemr9105261plr.150.1649252639493; Wed, 06 Apr 2022 06:43:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649252639; cv=none; d=google.com; s=arc-20160816; b=ZBRx0RKxp4LMJU34YfBx5kKffX+ckAzcMNM0F9oaseIeeF+Ys3vYvOLEtoxbAw7YMF vL046SMuXMGdVXJd7iGcJC+dFUBpV/tKltL24MWAOrNemvplVf2albcWrOmHjjC6nvAF URG0WdAjg1cjbkPitjD3hyknnxw+Z+3q44VC/SH9xi1t3b3e61hUUv2XM/Uts4HEVzhF bExW2XsOo6q/mO9nu0Mu+G0bTVDxwcSAOIXt6BIk9SVU6PU9L9dlwt/DJi9HkA5Jy471 DchxA3MHY7LaKkjKAzgcteNm2gNzmmGhPefAznXDVM8jYL/gk2RrfvYDPGR2QcuCtzan Q+oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VslTwnKZGqqFniTYuiijL+R9sblSuy9SwYWrv6aRKb4=; b=bVdSyVv4evKIoRlPnrY2NFQAk1G9DNdzFXIZ8YMgheEZqKhd9ReH+phps1N/lxCiKG cJUYNkjQmwMYx0r6kzzfFCODTLAhA8FCAkZoLpvDsyfXDUzBUAvlSUBz0ZrthFStdaPL Toft0DdOHSPAPNvcKL6QONHjMTgS+dO9Qr90bDlfVXGOTvvaoeAIYkf+rZgczRyOZN/v uksJ3evaqlwPz14T4cJtYnT++VeC2Xmpzu8qygAb1bcIq1GsJ68Z3WfApfq8r6xAGaiZ IA7IMg37QKESFFhhuZ8gzFH9HjN/SrL391XTE8aC9EmtObySBvP0HXy5U4Al6ISb821V WTAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bj33oiR0; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id 1-20020a631241000000b003821ef7e1b7si16634349pgs.191.2022.04.06.06.43.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 06:43:59 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bj33oiR0; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C3B2A60700E; Wed, 6 Apr 2022 04:32:36 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1838866AbiDFA5N (ORCPT + 99 others); Tue, 5 Apr 2022 20:57:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358091AbiDEK16 (ORCPT ); Tue, 5 Apr 2022 06:27:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6191F66C8C; Tue, 5 Apr 2022 03:15:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 011C7617AC; Tue, 5 Apr 2022 10:15:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D952C385A1; Tue, 5 Apr 2022 10:15:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649153712; bh=do5Wi18Fah0j3dGa06fMFlms+yMjfqPHRKwBB8HgvdQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bj33oiR0A/3U9oB6aw/mdcjk6e0+mJaONbeSV1N34tW1RLfz5QqVU5/LYzPRKg7Kz Wa0wQy3QAU0TSbSrQdztNP0nvFF83r000mEwimUKswByW00G5uLLfhx7N3lgBsJbyL GkRKbKMwJT0J8uJZJFwirqX1WrezXmezCNSJE14Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aharon Landau , Leon Romanovsky , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.10 319/599] RDMA/mlx5: Fix the flow of a miss in the allocation of a cache ODP MR Date: Tue, 5 Apr 2022 09:30:13 +0200 Message-Id: <20220405070308.325820580@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405070258.802373272@linuxfoundation.org> References: <20220405070258.802373272@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aharon Landau [ Upstream commit 2f0e60d5e9f96341a0c8a01be8878cdb3b29ff20 ] When an ODP MR cache entry is empty and trying to allocate it, increment the ent->miss counter and call to queue_adjust_cache_locked() to verify the entry is balanced. Fixes: aad719dcf379 ("RDMA/mlx5: Allow MRs to be created in the cache synchronously") Link: https://lore.kernel.org/r/09503e295276dcacc92cb1d8aef1ad0961c99dc1.1644947594.git.leonro@nvidia.com Signed-off-by: Aharon Landau Signed-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/mlx5/mr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c index 19346693c1da..6cd0cbd4fc9f 100644 --- a/drivers/infiniband/hw/mlx5/mr.c +++ b/drivers/infiniband/hw/mlx5/mr.c @@ -575,6 +575,8 @@ struct mlx5_ib_mr *mlx5_mr_cache_alloc(struct mlx5_ib_dev *dev, ent = &cache->ent[entry]; spin_lock_irq(&ent->lock); if (list_empty(&ent->head)) { + queue_adjust_cache_locked(ent); + ent->miss++; spin_unlock_irq(&ent->lock); mr = create_cache_mr(ent); if (IS_ERR(mr)) -- 2.34.1