Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1015055pxb; Wed, 6 Apr 2022 06:46:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwP0+SaKXtNJGZEwkbv3QEDL1UfIoKmo2fwp5suT2G89KHMz8RCR2RpA1SEFxcusRpZ7UKE X-Received: by 2002:a63:e1a:0:b0:380:fba9:f6e8 with SMTP id d26-20020a630e1a000000b00380fba9f6e8mr7231828pgl.384.1649252779227; Wed, 06 Apr 2022 06:46:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649252779; cv=none; d=google.com; s=arc-20160816; b=CB62ncdw6yWs1cHPWTI92Ik5+eHKMD4p+GZ+ERWutH2jiv6r63dUZoXbsqGFHS+fsz 2LeWwbSiRKybzWRe0UgqWgGY5/LIAG4G9lEdGkbWLI6bTXDSBVbbe2owYY5YEYPcy8Eq vlg6ZaJsmAQRYbKLsbUgGAJDi0OAhkDJ067bYYQCobBq2fd2x5V0rn8E/sUyWv3WD0jj CMBSjVSwRe8vzIhjQdrBSiIOKUPyVg19L7XSaenoKRE7Q4/UeHAn/GE5gC5ematPt0IY bCrGsMBOym24pjp3M2UgjEwvhCQ81rQEtR5WbMd3HUObrFJnA780EWKpie/c8ZooJynw TrRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+l8x0npVHQPxXN8Jiw+gTLW632Eoh0dwy+8lcfQVWk8=; b=Xzfh+RW8HRvBwkzuFniPdAgProcmvl5CofcFma9P+uOcnDskuSDtt76wJeg8Gl2f+f mML4wV8PxtkRKGalowZv5oXSitGvb1F6WS+W9PkbCThA0T9pu5bdLKpCasXVD7VWBntR ES8jMrAVp23DYq5H2atU1Bebf96nJQIRHJPdAuR2UJj1KYIn7wS3BOIZK5gZrq5ckLPo ZNA8FV/m4y8oRP7uC9rkc1IieeZ/+CBwX/Ox2ivW0beXjLZie4WU6AY45ikuAv2QUZ8m ohIvZCqUOXfd1SZN9LkUJ5i0Pb2aQe/8QpGHbTTdm3JlmwOd0HeWkaN/XsHEQxXW3tE9 TFeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=gegC6rwL; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id r17-20020a170902be1100b00153fd4c3dcdsi14161882pls.64.2022.04.06.06.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 06:46:19 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=gegC6rwL; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 96B4D4D66DE; Wed, 6 Apr 2022 05:37:16 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1582094AbiDEXl7 (ORCPT + 99 others); Tue, 5 Apr 2022 19:41:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1457541AbiDEQI0 (ORCPT ); Tue, 5 Apr 2022 12:08:26 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C022825CD for ; Tue, 5 Apr 2022 09:06:27 -0700 (PDT) Received: from zn.tnic (p2e55dff8.dip0.t-ipconnect.de [46.85.223.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 752E21EC0502; Tue, 5 Apr 2022 18:06:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1649174782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=+l8x0npVHQPxXN8Jiw+gTLW632Eoh0dwy+8lcfQVWk8=; b=gegC6rwLvXB2k5OYbibB7lCieya+klwRoI9ayiojrjzhL5+dgOrStUCrd9Zuge5TiWA+qx hqxZKJiVM/6bxN5fLDL7xISUUDmvsibLMFEtFzQRUT65RwM/EvUdZwy97j0+8nhQmrqrwS 9mOhd7Kerbl6Tv7wZS6hITMkaS4j51Y= Date: Tue, 5 Apr 2022 18:06:19 +0200 From: Borislav Petkov To: Takashi Iwai Cc: LKML , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Subject: Re: [PATCH 02/11] ALSA: usb-audio: Fix undefined behavior due to shift overflowing the constant Message-ID: References: <20220405151517.29753-1-bp@alien8.de> <20220405151517.29753-3-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 05, 2022 at 05:32:48PM +0200, Takashi Iwai wrote: > > +#define USB_ID(vendor, product) ((((unsigned int)vendor) << 16) | (product)) > > Parentheses are needed around vendor (as usual for a macro). > Could you resubmit with it? Or you can fix it up while applying. :) Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette