Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1016926pxb; Wed, 6 Apr 2022 06:49:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrPoPiTByc+1PP8R3p2CZ1XTvROlIb6+Ir82wlSMcl5Jm8nP+iKFInFvxTORi7Ez9QmRd4 X-Received: by 2002:a63:6a88:0:b0:398:7866:5ce4 with SMTP id f130-20020a636a88000000b0039878665ce4mr7056094pgc.240.1649252949569; Wed, 06 Apr 2022 06:49:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649252949; cv=none; d=google.com; s=arc-20160816; b=wHIO7EdBPr46yKaX+I7MY6V+4C5fDZDuyJZ+3mur7Sc7kZsQj2cMcJDYM1/xJDIsnl kgmpzQzMrRE6uTlnm6pwJQhlqVl7ddc8VJ7RNqd8kPdjYE1F8ejFAa+MC1C5pndRk+8B aL8ZK54owxrbKIz3FM9dDSkyEYNIhO4qswK4puRuYiOK5St+pTTWKchszNEcdNTehzMF /KuZbuEPHW5yv69FxFgLKng+Xd74enRMnOHDTdZy6UEPXYGy03U2aNVOL7gM/Z+7R5Pn sgecEO8BfEix3YYkY8EZ+f4cNwPKgynS6egWF1AvUhImSk7yswLfT1WDgMIQrp3DRjha aaRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eiC67LvkcRptZ4vBTwfJLFk18efdkgw7h4pbP4PEKXY=; b=S04f8lzpngNL5lFGrQRapo3mhS7WlPdDUPddx0rb002HueYad9gFY+Rrk+90HsH7ml xRuGAnnzWzSLZBDPizNz21KlNCOWTWRRpSPoRjMTUXVpMhB5QI3Hoxn1lR+eYfL9AJ9z LLWywiS1UYR8BZQNr55a6wj5AwimB+3ecKauuFPPJq/ry+Mr9yKAtOgQvnHo0qSOJumz UiTWmdBKO9CCkIvOh0ZHPZRcoUZAfQL66sj7DQEjH29Gn0uUgj+YpO6Q47sLzR+NyZGA MXqVDbSHccjfBc+U9y05+FOEpU2Hve/3Nd2AtunHFOpLVGcP3K5m08N2k3zkg7TdRetW YuAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=hEUAFCh5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id b10-20020a63e70a000000b003816043f0d5si15699880pgi.714.2022.04.06.06.49.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 06:49:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=hEUAFCh5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CA1F8399CAA; Wed, 6 Apr 2022 04:44:21 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1450905AbiDEUKo (ORCPT + 99 others); Tue, 5 Apr 2022 16:10:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1455446AbiDEQAC (ORCPT ); Tue, 5 Apr 2022 12:00:02 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE2D837A0D; Tue, 5 Apr 2022 08:15:33 -0700 (PDT) Received: from zn.tnic (p2e55dff8.dip0.t-ipconnect.de [46.85.223.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A17AB1EC0502; Tue, 5 Apr 2022 17:15:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1649171728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eiC67LvkcRptZ4vBTwfJLFk18efdkgw7h4pbP4PEKXY=; b=hEUAFCh5v61AOluFcbWJkVxBkYfuIDLTWZWTaNKwVuVmu8wc+ckaad77AK2YlaNTKYaKYr PFWhwwmQ9gQeF8jRu3SmcKDmXrgnwAArO/a7S61IZhA6h2tlUYrDO9pU2nhCnoYP+GqDpb 1jWA7ewvTWjdwVvE2eQxHNCiexjNsnM= From: Borislav Petkov To: LKML Cc: Adaptec OEM Raid Solutions , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 01/11] scsi: aacraid: Fix undefined behavior due to shift overflowing the constant Date: Tue, 5 Apr 2022 17:15:07 +0200 Message-Id: <20220405151517.29753-2-bp@alien8.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220405151517.29753-1-bp@alien8.de> References: <20220405151517.29753-1-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Borislav Petkov Fix drivers/scsi/aacraid/commsup.c: In function ‘aac_handle_sa_aif’: drivers/scsi/aacraid/commsup.c:1983:2: error: case label does not reduce to an integer constant case SA_AIF_BPCFG_CHANGE: ^~~~ See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory details as to why it triggers with older gccs only. Signed-off-by: Borislav Petkov Cc: Adaptec OEM Raid Solutions Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org --- drivers/scsi/aacraid/aacraid.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h index f849e7c9d428..5e115e8b2ba4 100644 --- a/drivers/scsi/aacraid/aacraid.h +++ b/drivers/scsi/aacraid/aacraid.h @@ -121,7 +121,7 @@ enum { #define SA_AIF_PDEV_CHANGE (1<<4) #define SA_AIF_LDEV_CHANGE (1<<5) #define SA_AIF_BPSTAT_CHANGE (1<<30) -#define SA_AIF_BPCFG_CHANGE (1<<31) +#define SA_AIF_BPCFG_CHANGE (1U<<31) #define HBA_MAX_SG_EMBEDDED 28 #define HBA_MAX_SG_SEPARATE 90 -- 2.35.1